Status Update
Comments
ch...@google.com <ch...@google.com>
mk...@google.com <mk...@google.com> #2
It seems the print is benign so I'll remove it; Could be worth it to find out how the message carrying information about "cb 0" (0 is not a valid color buffer handle) ever arrives to that line though
lo...@clearscore.com <lo...@clearscore.com> #3
mk...@google.com <mk...@google.com> #4
I agree with Sergey -- while I think it's fine to remove some logging messages that aren't necessary, the root problem here is that Studio shows everything emitted as if they are errors, with one notification bubble per message. We don't do that for other tools that Studio launches, and in particular, this isn't specific to the "cb 0" message I showed here; there were earlier (different) error messages during the boot as well.
lo...@gmail.com <lo...@gmail.com> #5
This behavior was requested specifically by the emulator team (vharron@ iirc, so at least 3-4 years ago). Let me see if I have any more details on why this was requested.
mk...@google.com <mk...@google.com> #6
I couldn't find any relevant threads. IIRC, the main concern at that time was that warnings at startup (e.g. missing acceleration) really needed to be bubbled up to the users. If that is not an issue anymore, and the emulator team only wants errors to be visible, then the proposed change SGTM.
ap...@google.com <ap...@google.com> #7
Yes, I vaguely remember that in some cases, you'd hit run, and then the emulator would fail to start (for example aborting because of some missing thing it needed), so we needed a way to surface these reasons. I don't know if there are any fatal startup errors like this. It seems like there are several things we could do here:
(1) Simplest: just reroute the errors into the log, and if emulator fails to start, that's where people can look. (I think that's what Sergey has already implemented?)
(2) If emulator could update itself to prefix truly fatal error messages in some way (such as error:) and use that for only fatal/exit(-1) reasons, then we could multiplex the output -- errors are shown in notifications as today, everything else is silently dumped to the log
(3) Hold on to the emulator output, and if there's a problem starting the emulator (say if it exits within a few seconds), then show all the emulator output.
mk...@google.com <mk...@google.com> #8
(2) More discipline in the emulator's messages would definitely help. Right now they don't seem to follow any simple set of rules (the "Emulator: " prefix is added by Studio):
2020-05-06 11:07:04,587 [ 38858] INFO - manager.EmulatorProcessHandler - Emulator: /usr/local/google/home/sprigogin/Android/Sdk/emulator/emulator -netdelay none -netspeed full -avd Nexus_10_API_29 -no-window -gpu auto-no-window -grpc-use-token
2020-05-06 11:07:04,976 [ 39247] INFO - manager.EmulatorProcessHandler - Emulator: pulseaudio: Failed to initialize PA contextaudio: Could not init `pa' audio driver
2020-05-06 11:07:04,985 [ 39256] INFO - manager.EmulatorProcessHandler - Emulator: E0506 11:07:04.983601525 31440 socket_utils_common_posix.cc:201] check for SO_REUSEPORT: {"created":"@1588788424.983585430","description":"SO_REUSEPORT unavailable on compiling system","file":"/mnt/tmpfs/src/android/emu-master-dev/external/grpc/src/core/lib/iomgr/socket_utils_common_posix.cc","file_line":169}
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: Your emulator is out of date, please update by launching Android Studio:
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Start Android Studio
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Select menu "Tools > Android > SDK Manager"
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Click "SDK Tools" tab
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Check "Android Emulator" checkbox
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Click "OK"
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator:
2020-05-06 11:07:06,475 [ 40746] INFO - manager.EmulatorProcessHandler - Emulator: emulator: INFO: LoggingInterceptor.cpp:70: 1588788426470945, rcvTime: 84, sndTime: 995, UNARY, rcv: 24, snd: 12156, /android.emulation.control.EmulatorController/getStatus() -> [...], OK
2020-05-06 11:07:07,355 [ 41626] INFO - manager.EmulatorProcessHandler - Emulator: emulator: INFO: LoggingInterceptor.cpp:70: 1588788426597819, rcvTime: 34, sndTime: 12945, SERVER_STREAMING, rcv: 48, snd: 1104071, /android.emulation.control.EmulatorController/streamScreenshot(format: RGBA8888 width: 665 height: 1064) -> [...], OK
lo...@gmail.com <lo...@gmail.com> #9
I can confirm it's working now, wonderful! Would you be able to tell me in which release it will be included?
ap...@google.com <ap...@google.com> #10
Branch: 2.0
commit c9a6c5a9028dbe728fdb2c4da1117d8f26aa520d
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Fri Mar 06 13:59:43 2020
Version 2.0.47
Cherry pick: Determine the use of not mapped types lazily for
applymapping
CL:
Bug: 149946708
Change-Id: Ia8f168e43e4889fd2f8173da91270b3d0267345e
M src/main/java/com/android/tools/r8/Version.java
M src/main/java/com/android/tools/r8/dex/ApplicationWriter.java
M src/main/java/com/android/tools/r8/naming/ApplyMappingError.java
M src/main/java/com/android/tools/r8/naming/MinifiedRenaming.java
M src/main/java/com/android/tools/r8/naming/NamingLens.java
M src/main/java/com/android/tools/r8/naming/ProguardMapMinifier.java
A src/test/java/com/android/tools/r8/naming/ClassNameMinifierOriginalClassNameTest.java
M src/test/java/com/android/tools/r8/naming/applymapping/shared/NameClashTest.java
A src/test/java/com/android/tools/r8/naming/testclasses/A.java
A src/test/java/com/android/tools/r8/naming/testclasses/B.java
mk...@google.com <mk...@google.com> #11
It could either be included in 4.0 beta 3 or 4.0 stable, depending on the release schedule for Android Studio. It was not feasible to port back to the current release. You can point to the 2.0.47 version by adding the following to your top-level build.gradle file:
buildscript {
repositories {
maven {
url 'https://storage.googleapis.com/r8-releases/raw'
}
}
dependencies {
classpath 'com.android.tools:r8:2.0.47' // Must be before the Gradle Plugin for Android.
classpath 'com.android.tools.build:gradle:X.Y.Z' // Your current AGP version.
}
}
Description
```
AGPBI: {"kind":"error","text":"'java.lang.Object get(java.lang.Object)' and 'java.lang.Object create(java.lang.Object)' map to same name: 'a'","sources":[{}],"tool":"R8"}
AGPBI: {"kind":"error","text":"'void updatePreLayout(androidx.constraintlayout.widget.ConstraintLayout)' and 'void updatePostMeasure(androidx.constraintlayout.widget.ConstraintLayout)' map to same name: 'a'","sources":[{}],"tool":"R8"}
'java.lang.Object get(java.lang.Object)' and 'java.lang.Object create(java.lang.Object)' map to same name: 'a'
```
In my real project, the error has been surfaced by adding the Google Play core library to the project and resulted in the same exception but different error message:
```
'Lcom/google/android/play/core/appupdate/j;' because it is in conflict with an existing class with the same name. This usually happens when compiling a test application against a source application and having short generic names in the test application. Try giving 'Lcom/google/android/play/core/appupdate/j;' a more specific name or add a keep rule to keep 'com.google.android.play.core.appupdate.j'.
```
I've attached a repro sample. Simply unzip it and run `./gradlew connectedCheck` to reproduce the error.