Range slider or range option for the `Slider` composable [150221060]

Fixed

Feature Request

Status Update

No update yet.

Description

fl...@gmail.com

created issue #1

Feb 25, 2020 11:00PM

The `Slider` component in Jetpack Compose currently does not have an option for ranges.

As specified in the material docs

https://material.io/components/sliders/#usage
"Sliders can have icons on both ends of the bar that reflect a range of values"

An option like this as is pictured in material spec would be great.

Comments

lp...@google.com <lp...@google.com> Feb 25, 2020 11:25PM

Assigned to ma...@google.com.

cl...@google.com <cl...@google.com> Aug 13, 2020 03:15PM

Reassigned to je...@google.com.

ni...@google.com <ni...@google.com> #2Jun 15, 2021 01:09PM

Status: New

sgtm, we can add the same API for FileSpec:

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:room/compiler-processing/src/main/java/androidx/room/compiler/processing/XFiler.kt;l=28?q=XFiler.kt&ss=androidx%2Fplatform%2Fframeworks%2Fsupport

I recommend using github for a small checkout size: https://github.com/androidX/androidx

Looks like we do have kotlin poet in the repo: https://github.com/androidx/androidx/blob/androidx-main/buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt#L75

So just need to add it as an API dependency to the room-compiler-processing's build file.

If you can add a test to the generated code match test, that would be great: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:room/compiler-processing-testing/src/test/java/androidx/room/compiler/processing/util/GeneratedCodeMatchTest.kt

lmk if you hit any blocker in getting started, thanks!

ma...@google.com <ma...@google.com> #3Jun 16, 2021 01:25PM

Marked as fixed, reassigned to ma...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 4a2360456d817b3101f289aac55ea1f3f610cfef
Author: Gabriel Freitas Vasconcelos <gfreivasc@gmail.com>
Date: Thu Mar 11 14:54:53 2021

[GH] Adds KotlinPoet integration to Room Processing

## Proposed Changes

Adds `write()` method that accepts KotlinPoet's an instance of
`FileSpec`. Also adds KotlinPoet as an API dependency and an extension
function similar to that of JavaPoet.

## Testing

Test: ./gradlew test connectedCheck without benchmarks

## Fixes
Fixes: [

b/182195680

](

https://issuetracker.google.com/issues/182195680)

This is an imported pull request from

https://github.com/androidx/androidx/pull/137.

Resolves #137
Github-Pr-Head-Sha: 96dc315b7e0e417e6a5e3d8cd6a8adda5c1b6c6a
GitOrigin-RevId: c5e4de3ab28fed968982e572c47b5ff07d210af7
Change-Id: I9d3aaa0a752447d9ba3978ce3fb705c0e74b3d13

M room/compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/CompilationResultSubject.kt
M room/compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/Source.kt
M room/compiler-processing-testing/src/test/java/androidx/room/compiler/processing/util/GeneratedCodeMatchTest.kt
M room/compiler-processing/build.gradle
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/XFiler.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/javac/JavacFiler.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/javac/JavacProcessingEnv.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspFiler.kt
M room/compiler/src/test/kotlin/androidx/room/testing/test_util.kt

https://android-review.googlesource.com/1627560

so...@google.com <so...@google.com> #4Jun 16, 2021 02:19PM

Status: Assigned (reopened)

All

ma...@google.com <ma...@google.com> Jun 16, 2021 05:07PM

Reassigned to ma...@google.com.

co...@google.com <co...@google.com> Feb 3, 2022 08:12PM

Accepted by ma...@google.com.

ma...@google.com <ma...@google.com> Mar 2, 2022 03:39PM

Marked as fixed.