"NullPointerException during IR Conversion" with gradle plugin 3.6.1 [150688800]

Fixed

Bug

Status Update

No update yet.

Description

aw...@gtempaccount.com

created issue #1

Mar 4, 2020 06:23AM

Our build is fine when building with gradle plugin version 3.5.3 but we get the error below with plugin 3.6.0 and 3.6.1:

=== LOG ==============
$ ./gradlew clean build
...
... <<snip>>
...
> Task :app:minifyReleaseWithR8
R8: Library class android.test.AndroidTestCase extends program class junit.framework.TestCase
R8: Library class android.test.AndroidTestRunner extends program class junit.runner.BaseTestRunner
R8: Library class android.test.InstrumentationTestCase extends program class junit.framework.TestCase
R8: Library class android.test.InstrumentationTestSuite extends program class junit.framework.TestSuite
/Users/awardak/.gradle/caches/transforms-2/files-2.1/fef1474bbb7e9b673f1d467589f0ef14/jetified-cnc-android-sdk-3.15.9-runtime.jar: R8: NullPointerException during IR Conversion

> Task :app:minifyReleaseWithR8 FAILED
====================

I've tried the builds mentioned in the following comments of another ticket and they all give the above error as well:
-

https://issuetracker.google.com/issues/150330356#comment16
-

https://issuetracker.google.com/issues/150330356#comment26

Comments

mk...@google.com <mk...@google.com> #2Mar 4, 2020 06:29AM

Assigned to mk...@google.com.

Can I ask you to try and run with --info and --stacktrace to let us see the full stack trace and error.

aw...@gtempaccount.com <aw...@gtempaccount.com> #3Mar 4, 2020 06:51AM

Result of following command attached:
$ ./gradlew --info --stacktrace build >buildlog.txt 2>&1

buildlog.txt

9.7 MB

View

Download

ze...@google.com <ze...@google.com> #4Mar 4, 2020 07:43AM

This could very likely be a dup of

b/150330356

Could you try amending you top-level build.gradle with the below and see if that resolved the NPE error:

buildscript {

repositories {
maven {
url '

https://storage.googleapis.com/r8-releases/raw'
}
}

dependencies {
classpath 'com.android.tools:r8:1.6.78' // Must be before the Gradle Plugin for Android.
classpath 'com.android.tools.build:gradle:X.Y.Z' // Your current AGP version.
}
}

aw...@gtempaccount.com <aw...@gtempaccount.com> #5Mar 4, 2020 03:11PM

As mentioned in the description of this issue, I've already tried that solution and still get the NPE error.

" I've tried the builds mentioned in the following comments of another ticket and they all give the above error as well:
-

https://issuetracker.google.com/issues/150330356#comment16
-

https://issuetracker.google.com/issues/150330356#comment26 "

ze...@google.com <ze...@google.com> #6Mar 4, 2020 03:53PM

Thanks for the update. I had not notices the comment about those attempts. Could you try running the attached r8.jar from

b/150330356#comment8

That should provide the actual point of the NPE which may not be the same switch issue.

ze...@google.com <ze...@google.com> #7Mar 4, 2020 03:55PM

Also, if possible to share the classfile inputs to the program, you could make a dump as detailed in

b/150330356#comment6

and attach it here or share it privately with zerny@google.com and/or mkroghj@google.com

With that we should be able to reproduce locally.

aw...@gtempaccount.com <aw...@gtempaccount.com> #8Mar 4, 2020 04:44PM

Here's the build log with the r8.jar. Please let me know if it helps. Thanks.

buildlog2.txt

9.7 MB

View

Download

ze...@google.com <ze...@google.com> #9Mar 4, 2020 05:14PM

Reassigned to ze...@google.com.

Thanks! The log shows this is not a dup (as your trials with the other builds showed). The relevant stacktrace is:

Caused by: java.lang.NullPointerException
at com.android.tools.r8.ir.code.IRCode.computeNormalExitBlocks(IRCode.java:888)
at com.android.tools.r8.ir.optimize.CodeRewriter.identifyReturnsArgument(CodeRewriter.java:1160)
at com.android.tools.r8.ir.conversion.IRConverter.rewriteCodeInternal(IRConverter.java:1418)
at com.android.tools.r8.ir.conversion.IRConverter.rewriteCode(IRConverter.java:1043)
at com.android.tools.r8.ir.conversion.IRConverter.processMethod(IRConverter.java:1020)
at com.android.tools.r8.ir.conversion.IRConverter.lambda$optimize$6(IRConverter.java:662)
at com.android.tools.r8.ir.conversion.MethodProcessor.lambda$forEachMethod$2(MethodProcessor.java:108)

ze...@google.com <ze...@google.com> #10Mar 4, 2020 05:47PM

Attached is another patched version of R8. Could you run that and post the error message. It should print the code block for which this happens.

Thanks!

r8.jar

26 MB

Download

aw...@gtempaccount.com <aw...@gtempaccount.com> #11Mar 4, 2020 07:47PM

Sure, attached.

buildlog3.txt

9.9 MB

View

Download

ch...@google.com <ch...@google.com> #12Mar 5, 2020 07:10AM

Thanks. It seems that the error is happening while optimizing the method

int com.penthera.virtuososdk.download.DownloaderImpl$n.a(com.penthera.virtuososdk.internal.interfaces.IEngVSegmentedFile, com.penthera.virtuososdk.internal.interfaces.IEngVirtuosoFileSegment, int, java.util.concurrent.atomic.AtomicBoolean)

Found it here: https://github.com/penthera/Download2Go-android/blob/master/libs/CnC_Android_SDK_3.15.14_release.aar.

Could you please try to build with the following command, which should enable extensive logging during the optimization of that method, and share the logs here:

./gradlew assembleRelease -Dcom.android.tools.r8.extensiveLoggingFilter="int com.penthera.virtuososdk.download.DownloaderImpl\$n.a(com.penthera.virtuososdk.internal.interfaces.IEngVSegmentedFile, com.penthera.virtuososdk.internal.interfaces.IEngVirtuosoFileSegment, int, java.util.concurrent.atomic.AtomicBoolean)" --no-daemon

Message last modified on Mar 5, 2020 07:25AM

aw...@gtempaccount.com <aw...@gtempaccount.com> #13Mar 5, 2020 06:38PM

Attached.

buildlog4.txt

561 KB

View

Download

ze...@google.com <ze...@google.com> #14Mar 6, 2020 06:47AM

Thanks for providing the log! We have identified the cause which is an off by one error. I'll post back here as soon as we have a fix you can try out.

ap...@google.com <ap...@google.com> #15Mar 6, 2020 08:01AM

Project: r8
Branch: master

commit 87596354ccfc17c8957b1f994f57e7efcbd99df6
Author: Ian Zerny <zerny@google.com>
Date: Fri Mar 06 08:57:53 2020

Fix count error in IdempotentFunctionCallCanonicalizer

Bug: 150688800
Change-Id: I80596d0889db6d2577409438268c75640653f247

M src/main/java/com/android/tools/r8/ir/optimize/IdempotentFunctionCallCanonicalizer.java
A src/test/java/com/android/tools/r8/regress/b150688800/IdempotentCountErrorTest.java

https://r8-review.googlesource.com/49531

ap...@google.com <ap...@google.com> #16Mar 6, 2020 08:40AM

Project: r8
Branch: 1.6

commit af6558a20601121ab08cb5c1a6aae78d564a7eac
Author: Ian Zerny <zerny@google.com>
Date: Fri Mar 06 09:31:16 2020

Version 1.6.81

Cherry pick: Fix count error in IdempotentFunctionCallCanonicalizer
CL:

https://r8-review.googlesource.com/c/r8/+/49531
Bug: 150688800
Change-Id: I4eb6f94a5bdabbc7fd6a5e0cb6cb721304aeea50

M src/main/java/com/android/tools/r8/Version.java
M src/main/java/com/android/tools/r8/ir/optimize/IdempotentFunctionCallCanonicalizer.java
A src/test/java/com/android/tools/r8/regress/b150688800/IdempotentCountErrorTest.java

https://r8-review.googlesource.com/49532

ap...@google.com <ap...@google.com> #17Mar 6, 2020 09:00AM

Project: r8
Branch: 2.0

commit cb14ff69f90a698fe30bd8d654d64f332fd6c71e
Author: Ian Zerny <zerny@google.com>
Date: Fri Mar 06 09:44:17 2020

Version 2.0.45

Cherry pick: Fix count error in IdempotentFunctionCallCanonicalizer
CL:

https://r8-review.googlesource.com/c/r8/+/49532
Bug: 150688800

Change-Id: I4ee383613c7d8a20e609a3da28a4e3435ec47255

M src/main/java/com/android/tools/r8/Version.java
M src/main/java/com/android/tools/r8/ir/optimize/IdempotentFunctionCallCanonicalizer.java
A src/test/java/com/android/tools/r8/regress/b150688800/IdempotentCountErrorTest.java

https://r8-review.googlesource.com/49533

ze...@google.com <ze...@google.com> #18Mar 6, 2020 10:40AM

Marked as fixed.

A fix for this has landed in 1.6.81. Could you try out and see if it resolves the issue for your build?

Amend you top-level build.gradle with:

buildscript {

repositories {
maven {
url '

https://storage.googleapis.com/r8-releases/raw' // NOTICE: no '/master' here!
}
}

dependencies {
classpath 'com.android.tools:r8:1.6.81' // Must be before the Gradle Plugin for Android.
classpath 'com.android.tools.build:gradle:X.Y.Z' // Your current AGP version.
}
}

aw...@gtempaccount.com <aw...@gtempaccount.com> #19Mar 6, 2020 02:52PM

Fixed. Thanks!

ze...@google.com <ze...@google.com> #20Mar 6, 2020 06:36PM

Awesome. Thanks again for reporting and for iterating with us to find the cause!

Issue 150688800

Description

Issue summary

Comments

mk...@google.com <mk...@google.com> #2Mar 4, 2020 06:29AM

aw...@gtempaccount.com <aw...@gtempaccount.com> #3Mar 4, 2020 06:51AM

ze...@google.com <ze...@google.com> #4Mar 4, 2020 07:43AM

aw...@gtempaccount.com <aw...@gtempaccount.com> #5Mar 4, 2020 03:11PM

ze...@google.com <ze...@google.com> #6Mar 4, 2020 03:53PM

ze...@google.com <ze...@google.com> #7Mar 4, 2020 03:55PM

aw...@gtempaccount.com <aw...@gtempaccount.com> #8Mar 4, 2020 04:44PM

ze...@google.com <ze...@google.com> #9Mar 4, 2020 05:14PM

ze...@google.com <ze...@google.com> #10Mar 4, 2020 05:47PM

aw...@gtempaccount.com <aw...@gtempaccount.com> #11Mar 4, 2020 07:47PM

ch...@google.com <ch...@google.com> #12Mar 5, 2020 07:10AM

aw...@gtempaccount.com <aw...@gtempaccount.com> #13Mar 5, 2020 06:38PM

ze...@google.com <ze...@google.com> #14Mar 6, 2020 06:47AM

ap...@google.com <ap...@google.com> #15Mar 6, 2020 08:01AM

ap...@google.com <ap...@google.com> #16Mar 6, 2020 08:40AM

ap...@google.com <ap...@google.com> #17Mar 6, 2020 09:00AM

ze...@google.com <ze...@google.com> #18Mar 6, 2020 10:40AM

aw...@gtempaccount.com <aw...@gtempaccount.com> #19Mar 6, 2020 02:52PM

ze...@google.com <ze...@google.com> #20Mar 6, 2020 06:36PM

Add comment

Issue metadata