Fixed
Status Update
No update yet.
Comments
mo...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit eb4ba29681b6eceb06c1cc154381514fd73518d7
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Mon Jan 18 16:36:00 2021
Add layoutDirection param to Shape's createOutline
Bug: 152756983
Test: ClipDrawTest
Relnote: Add layoutDirection param to Shape's createOutline. This allows to create layout direction aware shapes.
Change-Id: I57c20c45978b5468556159966bd9836653a2e40d
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BackgroundTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BorderTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/CornerBasedShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/CutCornerShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/RoundedCornerShapeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Background.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/CornerBasedShape.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/GenericShape.kt
M compose/integration-tests/src/main/java/androidx/ui/integration/test/core/ComponentWithTwoLayoutNodesTestCase.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ButtonDemo.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ColorPickerDemo.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AppBar.kt
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/ImageAssertions.kt
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/src/androidAndroidTest/kotlin/androidx/compose/ui/graphics/RectangleShapeTest.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/RectangleShape.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Shape.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidLayoutDrawTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/ClipDrawTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/GraphicsLayerTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/ShadowTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/OutlineResolver.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeLayer.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ViewLayer.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/OwnedLayer.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/OutlineCache.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/SkijaLayer.kt
M compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/SkijaLayerTest.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/graphics/GraphicsLayerScopeTest.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
https://android-review.googlesource.com/1553502
Branch: androidx-main
commit eb4ba29681b6eceb06c1cc154381514fd73518d7
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Mon Jan 18 16:36:00 2021
Add layoutDirection param to Shape's createOutline
Bug: 152756983
Test: ClipDrawTest
Relnote: Add layoutDirection param to Shape's createOutline. This allows to create layout direction aware shapes.
Change-Id: I57c20c45978b5468556159966bd9836653a2e40d
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BackgroundTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BorderTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/CornerBasedShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/CutCornerShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/RoundedCornerShapeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Background.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/CornerBasedShape.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/GenericShape.kt
M compose/integration-tests/src/main/java/androidx/ui/integration/test/core/ComponentWithTwoLayoutNodesTestCase.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ButtonDemo.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ColorPickerDemo.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AppBar.kt
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/ImageAssertions.kt
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/src/androidAndroidTest/kotlin/androidx/compose/ui/graphics/RectangleShapeTest.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/RectangleShape.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Shape.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidLayoutDrawTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/ClipDrawTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/GraphicsLayerTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/ShadowTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/OutlineResolver.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeLayer.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ViewLayer.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/OwnedLayer.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/OutlineCache.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/SkijaLayer.kt
M compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/SkijaLayerTest.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/graphics/GraphicsLayerScopeTest.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
an...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit dd1e77d4c753bd3e41d094987cee6e7e6c13124c
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed Jan 20 20:01:28 2021
Make RounderCornerShape/CutCornerShape layout direction aware
Relnote: Parameters on RounderCornerShape, CutCornerShape and CornerBasedShape were renamed from left/right to start/end in order to support the shape's auto mirroring in the rtl direction. AbsoluteRounderCornerShape and AbsoluteCutCornerShape were introduced for the cases when auto-mirroring is not desired.
Fixes: 152756983
Test: CutCornerShapeTest, RoundedCornerShapeTest, CutCornerShape
Change-Id: I61040b7bba950191361af89ff4c736ef6cb56235
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/AbsoluteCutCornerShapeTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/AbsoluteRoundedCornerShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/CornerBasedShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/CutCornerShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/RoundedCornerShapeTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/AbsoluteCutCornerShape.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/AbsoluteRoundedCornerShape.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/CornerBasedShape.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/CutCornerShape.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/RoundedCornerShape.kt
M compose/integration-tests/docs-snippets/src/main/java/androidx/compose/integration/docs/theming/Theming.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BackdropScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/ui/ui-tooling/src/androidTest/java/androidx/compose/ui/tooling/TestAnimationPreview.kt
M compose/ui/ui-tooling/src/androidTest/java/androidx/compose/ui/tooling/inspector/ParameterFactoryTest.kt
https://android-review.googlesource.com/1555239
Branch: androidx-main
commit dd1e77d4c753bd3e41d094987cee6e7e6c13124c
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed Jan 20 20:01:28 2021
Make RounderCornerShape/CutCornerShape layout direction aware
Relnote: Parameters on RounderCornerShape, CutCornerShape and CornerBasedShape were renamed from left/right to start/end in order to support the shape's auto mirroring in the rtl direction. AbsoluteRounderCornerShape and AbsoluteCutCornerShape were introduced for the cases when auto-mirroring is not desired.
Fixes: 152756983
Test: CutCornerShapeTest, RoundedCornerShapeTest, CutCornerShape
Change-Id: I61040b7bba950191361af89ff4c736ef6cb56235
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/AbsoluteCutCornerShapeTest.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/AbsoluteRoundedCornerShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/CornerBasedShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/CutCornerShapeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/RoundedCornerShapeTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/AbsoluteCutCornerShape.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/AbsoluteRoundedCornerShape.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/CornerBasedShape.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/CutCornerShape.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/RoundedCornerShape.kt
M compose/integration-tests/docs-snippets/src/main/java/androidx/compose/integration/docs/theming/Theming.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BackdropScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/ui/ui-tooling/src/androidTest/java/androidx/compose/ui/tooling/TestAnimationPreview.kt
M compose/ui/ui-tooling/src/androidTest/java/androidx/compose/ui/tooling/inspector/ParameterFactoryTest.kt
mo...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b0286ae80bb8901cc834a88d5fe66f55f4817de3
Author: George Mount <mount@google.com>
Date: Thu Feb 20 15:14:09 2020
Add support for a LayerModifier.
Fixes: 150774014
This is the first step of changing RepaintBoundaryNode
to use modifiers instead. The next step is to replace
all use of RepaintBoundaryNode.
Relnote: "Added LayerModifier, a modifier that allows
adding a RenderNode for a Layout. It allows setting
clipping, opacity, rotation, scaling, and shadows.
This will replace RepaintBoundary."
Test: ran AndroidLayoutDrawTest
Change-Id: I7100dfe7a795567a48c2d5b3094e3dbd47e0f9c7
M ui/ui-core/api/0.1.0-dev07.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev07.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/build.gradle
A ui/ui-core/integration-tests/samples/src/main/java/androidx/ui/core/samples/LayerModifierSamples.kt
A ui/ui-core/src/main/java/androidx/ui/core/DrawLayerModifier.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-geometry/api/0.1.0-dev07.txt
M ui/ui-geometry/api/current.txt
M ui/ui-geometry/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-geometry/api/public_plus_experimental_current.txt
M ui/ui-geometry/api/restricted_0.1.0-dev07.txt
M ui/ui-geometry/api/restricted_current.txt
M ui/ui-geometry/src/main/java/androidx/ui/geometry/RRect.kt
M ui/ui-material/src/main/java/androidx/ui/material/Drawer.kt
M ui/ui-platform/api/0.1.0-dev07.txt
M ui/ui-platform/api/current.txt
M ui/ui-platform/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-platform/api/public_plus_experimental_current.txt
M ui/ui-platform/api/restricted_0.1.0-dev07.txt
M ui/ui-platform/api/restricted_current.txt
M ui/ui-platform/src/main/java/androidx/ui/core/AndroidOwner.kt
M ui/ui-platform/src/main/java/androidx/ui/core/ComponentNodes.kt
M ui/ui-platform/src/main/java/androidx/ui/core/LayoutNodeWrapper.kt
A ui/ui-platform/src/main/java/androidx/ui/core/OutlineResolver.kt
A ui/ui-platform/src/main/java/androidx/ui/core/OwnedLayer.kt
A ui/ui-platform/src/main/java/androidx/ui/core/RenderNodeLayer.kt
A ui/ui-platform/src/main/java/androidx/ui/core/ViewLayer.kt
https://android-review.googlesource.com/1242671
Branch: androidx-master-dev
commit b0286ae80bb8901cc834a88d5fe66f55f4817de3
Author: George Mount <mount@google.com>
Date: Thu Feb 20 15:14:09 2020
Add support for a LayerModifier.
Fixes: 150774014
This is the first step of changing RepaintBoundaryNode
to use modifiers instead. The next step is to replace
all use of RepaintBoundaryNode.
Relnote: "Added LayerModifier, a modifier that allows
adding a RenderNode for a Layout. It allows setting
clipping, opacity, rotation, scaling, and shadows.
This will replace RepaintBoundary."
Test: ran AndroidLayoutDrawTest
Change-Id: I7100dfe7a795567a48c2d5b3094e3dbd47e0f9c7
M ui/ui-core/api/0.1.0-dev07.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev07.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/build.gradle
A ui/ui-core/integration-tests/samples/src/main/java/androidx/ui/core/samples/LayerModifierSamples.kt
A ui/ui-core/src/main/java/androidx/ui/core/DrawLayerModifier.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-geometry/api/0.1.0-dev07.txt
M ui/ui-geometry/api/current.txt
M ui/ui-geometry/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-geometry/api/public_plus_experimental_current.txt
M ui/ui-geometry/api/restricted_0.1.0-dev07.txt
M ui/ui-geometry/api/restricted_current.txt
M ui/ui-geometry/src/main/java/androidx/ui/geometry/RRect.kt
M ui/ui-material/src/main/java/androidx/ui/material/Drawer.kt
M ui/ui-platform/api/0.1.0-dev07.txt
M ui/ui-platform/api/current.txt
M ui/ui-platform/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-platform/api/public_plus_experimental_current.txt
M ui/ui-platform/api/restricted_0.1.0-dev07.txt
M ui/ui-platform/api/restricted_current.txt
M ui/ui-platform/src/main/java/androidx/ui/core/AndroidOwner.kt
M ui/ui-platform/src/main/java/androidx/ui/core/ComponentNodes.kt
M ui/ui-platform/src/main/java/androidx/ui/core/LayoutNodeWrapper.kt
A ui/ui-platform/src/main/java/androidx/ui/core/OutlineResolver.kt
A ui/ui-platform/src/main/java/androidx/ui/core/OwnedLayer.kt
A ui/ui-platform/src/main/java/androidx/ui/core/RenderNodeLayer.kt
A ui/ui-platform/src/main/java/androidx/ui/core/ViewLayer.kt
Description
As we moving towards modifiers looks like now LayoutNode.detach() should be calling this as well making sure the parent is invalidated when we remove from the tree LayoutNode which was drawing via DrawModifier as otherwise we can continue displaying this LayoutNode as it was not removed
WDYF?