Add RxJava 3 support to Room [152427884]

Fixed

Feature Request

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Mar 26, 2020 10:26AM

Room has support for RxJava 2 but since RxJava 3 is out, RxJava 2 is now in maintenance mode and it'll be supported until February 28, 2021. RxJava 3 is not as big update as RxJava 2 was so I think it may not be a lot of work to support it in Room.

From Room point of view I think the biggest difference is new package structure:

https://github.com/ReactiveX/RxJava/wiki/What's-different-in-3.0#package-structure

Not sure if it affects Room but RxJava 3 supports Java 8:

https://github.com/ReactiveX/RxJava/wiki/What's-different-in-3.0#java-8

RxJava 3 can live next to RxJava 2 in a project and there is an interop library that helps with making them work together:

https://github.com/ReactiveX/RxJava/wiki/What's-different-in-3.0#rxjava-2x
but I think that it would still be good to have direct RxJava 3 support in Room to make the adoption of RxJava 3 faster.

Comments

m4...@gmail.com <m4...@gmail.com> #2Mar 27, 2020 07:21PM

tz...@gmail.com <tz...@gmail.com> #3Apr 7, 2020 04:29PM

+1 interested in this update!

qn...@gmail.com <qn...@gmail.com> #4May 25, 2020 08:58PM

ai...@gmail.com <ai...@gmail.com> #5May 26, 2020 06:32AM

+1
Room is the only library I use that doesn't support RxJava 3 yet.

Meanwhile I'm using RxJavaBridge and these Kotlin extension to make the conversion as short as possible:

fun <T> io.reactivex.Maybe<T>.toV3Maybe(): Maybe<T> {
return RxJavaBridge.toV3Maybe(this)
}

fun <T> io.reactivex.Single<T>.toV3Single(): Single<T> {
return RxJavaBridge.toV3Single(this)
}

fun <T> io.reactivex.Observable<T>.toV3Observable(): Observable<T> {
return RxJavaBridge.toV3Observable(this)
}

fun <T> io.reactivex.Flowable<T>.toV3Flowable(): Flowable<T> {
return RxJavaBridge.toV3Flowable(this)
}

ap...@google.com <ap...@google.com> #6Jun 24, 2020 04:59PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 2056c169a0689090adc59d0229f05e8a815e8881
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Jun 03 17:12:43 2020

Add RxJava 3 support to Room

Create a new artifact, room-rxjava3 that contains RxRoom that
uses io.reactivex.rxjava3 types. The processor is also updated
to identify the RxJava3 types in DAO return types to correctly
generate code that uses the new runtime.

Bug: 152427884
Test: ./gradlew :room:integration-tests:room-testapp:cC \
:room:room-compiler:test \
:room:room-rxjava3:test
Change-Id: I08e68d0ebd36d7434d2716532c0a7ee77fda3da9

M buildSrc/src/main/kotlin/androidx/build/PublishDocsRules.kt
M jetifier/jetifier/core/src/main/resources/default.config
M jetifier/jetifier/core/src/main/resources/default.generated.config
M jetifier/jetifier/migration.config
M room/compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/compiler/src/main/kotlin/androidx/room/processor/TransactionMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/RxTypes.kt
M room/compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxCallableQueryResultBinderProvider.kt
M room/compiler/src/main/kotlin/androidx/room/solver/binderprovider/RxQueryResultBinderProvider.kt
M room/compiler/src/main/kotlin/androidx/room/solver/prepared/binderprovider/RxPreparedQueryResultBinderProvider.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/RxCallableDeleteOrUpdateMethodBinderProvider.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binderprovider/RxCallableInsertMethodBinderProvider.kt
A room/compiler/src/test/data/common/input/Rx3Room.java
A room/compiler/src/test/data/common/input/rxjava3/Completable.java
A room/compiler/src/test/data/common/input/rxjava3/Flowable.java
A room/compiler/src/test/data/common/input/rxjava3/Maybe.java
A room/compiler/src/test/data/common/input/rxjava3/Observable.java
A room/compiler/src/test/data/common/input/rxjava3/Single.java
M room/compiler/src/test/kotlin/androidx/room/processor/InsertionMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/ShortcutMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/processor/TransactionMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/test_util.kt
M room/compiler/src/test/kotlin/androidx/room/writer/DaoWriterTest.kt
M room/integration-tests/testapp/build.gradle
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/MailDao.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/UserDao.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/UserPetDao.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MainThreadCheckTest.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/RxJava2Test.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/RxJava2WithInstantTaskExecutorTest.java
A room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/RxJava3Test.java
A room/rxjava3/api/2.3.0-alpha02.txt
A room/rxjava3/api/current.txt
A room/rxjava3/api/public_plus_experimental_2.3.0-alpha02.txt
A room/rxjava3/api/public_plus_experimental_current.txt
A room/rxjava3/api/res-2.3.0-alpha02.txt
A room/rxjava3/api/res-current.txt
A room/rxjava3/api/restricted_2.3.0-alpha02.txt
A room/rxjava3/api/restricted_current.txt
A room/rxjava3/build.gradle
A room/rxjava3/src/main/AndroidManifest.xml
A room/rxjava3/src/main/java/androidx/room/rxjava3/EmptyResultSetException.java
A room/rxjava3/src/main/java/androidx/room/rxjava3/RxRoom.java
A room/rxjava3/src/test/java/androidx/room/rxjava3/RxRoomTest.java
M settings.gradle

https://android-review.googlesource.com/1323280

da...@google.com <da...@google.com> Jun 24, 2020 05:00PM

Marked as fixed.

Issue 152427884