Downgrade “Creating configuration” to debug-level? [152500503]

Fixed

Internal Cleanup

Status Update

No update yet.

Description

je...@google.com

created issue #1

Mar 26, 2020 03:58PM

When I run `./gradlew projects —info | tee /tmp/log` in frameworks/support, I observe ( after we clean up the early configuration resolution warnings , aosp/1264499 ) :

21053 lines of output:
$ wc -l /tmp/log
21053 /tmp/log

Of which 17372 seem to be about creating configurations:
$ grep "Creating configuration" /tmp/log | wc -l
17372

AndroidX would like to enable info-level logging in certain circumstances, most notably when rerunning the build and validating that all tasks are up-to-date (

b/140265313

https://android.googlesource.com/platform/frameworks/support/+/9e232c13f6a3d88a8770f452bfa3a829d803e18f/gradlew#245 )

Can we move this log message to debug level?

Comments

je...@google.com <je...@google.com> Mar 26, 2020 04:29PM

Accepted by je...@google.com.

jv...@google.com <jv...@google.com> Mar 26, 2020 05:52PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> #2Mar 26, 2020 05:54PM

Are there any updates here?

Message last modified on Mar 26, 2020 05:55PM

je...@google.com <je...@google.com> Mar 30, 2020 05:19PM

Reassigned to cm...@google.com.

cm...@google.com <cm...@google.com> #3Apr 2, 2020 04:10PM

Accepted by cm...@google.com.

I looked at it and I'm planning to remove the deduplicating lookup the callstack refers to. It should be no longer needed. How was the 80ms in comment#1 calculated? If it's straightforward I'll calculate it again before my change goes in.

je...@google.com <je...@google.com> #4Apr 2, 2020 04:50PM

I couldn't move the logging off thread but I was able to address an area of concern in the callstack:
com.google.protobuf.Descriptors$FileDescriptor.internalBuildGeneratedFileFrom(Descriptors.java)
com.android.build.gradle.internal.cxx.logging.CxxLogging.<clinit>(CxxLogging.java:82)
com.android.build.gradle.internal.cxx.logging.LoggingMessage.getDescriptor(LoggingMessage.java:110)
com.android.build.gradle.internal.cxx.logging.LoggingMessage.hashCode(LoggingMessage.java:489)
java.util.HashMap.hash(HashMap.java:340)
java.util.HashMap.containsKey(HashMap.java:592)
java.util.HashSet.contains(HashSet.java:204)

This logic was deduplicating messages (including chatty 'info' messages). This deduplication shouldn't be needed anymore so I removed it.

I don't know how the 80ms from

comment#1

was gathered so I can't say how much it has improved logging, but it should help quite a bit. Let me know if you can still measure a performance issue. The next step would be to reduce the 'info' that's logged.

cm...@google.com <cm...@google.com> #5Apr 2, 2020 05:55PM

Marked as fixed.

The change mentioned in

comment#4

(internal Id I4e51a10d9ee2a81ca56c8e81c7890dfb0bf239d7) should be available in Canary 8 of Flamingo.

cm...@google.com <cm...@google.com> #6Apr 2, 2020 05:55PM

No problem, they annoyed me but I missed that they were from AGP code and not Gradle!

sa...@google.com <sa...@google.com> #7Apr 24, 2020 08:05PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in the latest version of Android Studio 4.0. We encourage you to get the latest update.

If you notice any further issues or have questions please file a new bug report from Android Studio by selecting Help > Submit Feedback.

Thank you for taking the time to submit feedback -- we really appreciate it!