Provide APIs for reacting to visual / interaction state [152525426]

Fixed

Feature Request

Status Update

No update yet.

Description

lp...@google.com

created issue #1

Mar 26, 2020 07:01PM

Elements typically have different visual appearance / behavior when they are:

Pressed
Hovered
Focused

etc

We should provide a consistent API story around managing these states, and make it easy to combine foundational interactions such as draggable, to wire up these states within a component.

Comments

ap...@google.com <ap...@google.com> #2Apr 22, 2020 12:48PM

Please upload a sample project that reproduces this issue.

ap...@google.com <ap...@google.com> #3Apr 23, 2020 07:00PM

There is no need. Just check DynamicGraphNavigator code and you will understand the problem with DynamicActivityNavigator.
Besides I pointed out to a class and made a screenshot of what is missing

ap...@google.com <ap...@google.com> #4Aug 21, 2020 10:55AM

Also, making a sample project means testing in production, because dynamic feature modules are testable only after uploading to play market. We dont have any resources to do that

ap...@google.com <ap...@google.com> #5Nov 6, 2020 12:18PM

Also check a screenshot please

ki...@google.com <ki...@google.com> #6Nov 6, 2020 05:27PM

it is not fixed in 2.5.1, btw

https://android.googlesource.com/platform/frameworks/support/+/4653357b9f99873d663cb5fee267b2f64afa0472/navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigator.kt

The file still has the same error

ma...@google.com <ma...@google.com> #7Nov 6, 2020 05:40PM

The way Dynamic Navigation has to handle activities is inherently different from other destinations so not returning there could possibly be intentional.

Is this something new that was caused by upgrading to 2.5.0? Or was it pre-existing?

ap...@google.com <ap...@google.com> #8Feb 9, 2021 10:17PM

It is caused by upgrading from 2.3.0 to 2.5.0.
When we saw this issue we did a rollback to 2.3.5.
2.3.5 - the last version where this issue doesn't exist

ap...@google.com <ap...@google.com> #9Feb 11, 2021 02:34AM

and in 2.3.5 you do have a return statement there

an...@google.com <an...@google.com> #10Oct 6, 2021 06:03PM

You're right, looks like we didn't add it back when we made this change.

cl...@google.com <cl...@google.com> #11Oct 12, 2021 01:50PM

I n what version we can expect to get it back?

ap...@google.com <ap...@google.com> #12Oct 12, 2021 04:38PM

any news? :)

ap...@google.com <ap...@google.com> #13Oct 13, 2021 12:24PM

Marked as fixed.

The statement was removed during the migration to V2, when we did not expect this problem to occur.