Gradle configuration fails on project with several modules when AGP is applied using plugin management [154388196]

Fixed

Bug

Status Update

No update yet.

Description

da...@gmail.com

created issue #1

Apr 19, 2020 03:17PM

Error message: Cannot set the value of property 'aapt2DaemonBuildService' of type com.android.build.gradle.internal.services.Aapt2DaemonBuildService using a provider of type com.android.build.gradle.internal.services.Aapt2DaemonBuildService. See attachment for full stacktrace.

Sample project: https://github.com/daugeldauge/agp-plugin-management-bug

Project configures successfully if you don't apply Kotlin plugin in lib module or downgrade AGP to 3.6.3

Gradle version: 6.3; Android Plugin Version: can reproduce on 4.1.0-alpha06, 4.0.0-beta04; can't reproduce on 3.6.3; Module Compile Sdk Version: 29; Android SDK Tools version: 26.1.1; Kotlin version: 1.3.71

stacktrace.txt

19 KB

View

Download

Comments

vi...@google.com <vi...@google.com> Apr 20, 2020 04:39AM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Apr 20, 2020 05:33AM

Reassigned to im...@google.com.

ga...@google.com <ga...@google.com> #2Apr 30, 2020 10:52AM

Reassigned to ga...@google.com.

It seems the print is benign so I'll remove it; Could be worth it to find out how the message carrying information about "cb 0" (0 is not a valid color buffer handle) ever arrives to that line though

ga...@google.com <ga...@google.com> #3Apr 30, 2020 01:15PM

I don't think we should necessarily remove these messages from the emulator code since at least some of them may point to real problems. I'm going to make sure that they are not treated as errors in Studio.

ga...@google.com <ga...@google.com> #4Apr 30, 2020 02:27PM

I agree with Sergey -- while I think it's fine to remove some logging messages that aren't necessary, the root problem here is that Studio shows everything emitted as if they are errors, with one notification bubble per message. We don't do that for other tools that Studio launches, and in particular, this isn't specific to the "cb 0" message I showed here; there were earlier (different) error messages during the boot as well.

je...@google.com <je...@google.com> #5Apr 30, 2020 02:33PM

This behavior was requested specifically by the emulator team (vharron@ iirc, so at least 3-4 years ago). Let me see if I have any more details on why this was requested.

ga...@google.com <ga...@google.com> #6Apr 30, 2020 02:38PM

I couldn't find any relevant threads. IIRC, the main concern at that time was that warnings at startup (e.g. missing acceleration) really needed to be bubbled up to the users. If that is not an issue anymore, and the emulator team only wants errors to be visible, then the proposed change SGTM.

an...@google.com <an...@google.com> #7Apr 30, 2020 07:00PM

Yes, I vaguely remember that in some cases, you'd hit run, and then the emulator would fail to start (for example aborting because of some missing thing it needed), so we needed a way to surface these reasons. I don't know if there are any fatal startup errors like this. It seems like there are several things we could do here:

(1) Simplest: just reroute the errors into the log, and if emulator fails to start, that's where people can look. (I think that's what Sergey has already implemented?)

(2) If emulator could update itself to prefix truly fatal error messages in some way (such as error:) and use that for only fatal/exit(-1) reasons, then we could multiplex the output -- errors are shown in notifications as today, everything else is silently dumped to the log

(3) Hold on to the emulator output, and if there's a problem starting the emulator (say if it exits within a few seconds), then show all the emulator output.

an...@google.com <an...@google.com> #8May 1, 2020 08:11PM

(1) ag/11396356 does write all emulator's messages into Studio log at INFO level.
(2) More discipline in the emulator's messages would definitely help. Right now they don't seem to follow any simple set of rules (the "Emulator: " prefix is added by Studio):

2020-05-06 11:07:04,587 [ 38858] INFO - manager.EmulatorProcessHandler - Emulator: /usr/local/google/home/sprigogin/Android/Sdk/emulator/emulator -netdelay none -netspeed full -avd Nexus_10_API_29 -no-window -gpu auto-no-window -grpc-use-token
2020-05-06 11:07:04,976 [ 39247] INFO - manager.EmulatorProcessHandler - Emulator: pulseaudio: Failed to initialize PA contextaudio: Could not init `pa' audio driver
2020-05-06 11:07:04,985 [ 39256] INFO - manager.EmulatorProcessHandler - Emulator: E0506 11:07:04.983601525 31440 socket_utils_common_posix.cc:201] check for SO_REUSEPORT: {"created":"@1588788424.983585430","description":"SO_REUSEPORT unavailable on compiling system","file":"/mnt/tmpfs/src/android/emu-master-dev/external/grpc/src/core/lib/iomgr/socket_utils_common_posix.cc","file_line":169}
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: Your emulator is out of date, please update by launching Android Studio:
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Start Android Studio
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Select menu "Tools > Android > SDK Manager"
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Click "SDK Tools" tab
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Check "Android Emulator" checkbox
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Click "OK"
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator:
2020-05-06 11:07:06,475 [ 40746] INFO - manager.EmulatorProcessHandler - Emulator: emulator: INFO: LoggingInterceptor.cpp:70: 1588788426470945, rcvTime: 84, sndTime: 995, UNARY, rcv: 24, snd: 12156, /android.emulation.control.EmulatorController/getStatus() -> [...], OK
2020-05-06 11:07:07,355 [ 41626] INFO - manager.EmulatorProcessHandler - Emulator: emulator: INFO: LoggingInterceptor.cpp:70: 1588788426597819, rcvTime: 34, sndTime: 12945, SERVER_STREAMING, rcv: 48, snd: 1104071, /android.emulation.control.EmulatorController/streamScreenshot(format: RGBA8888 width: 665 height: 1064) -> [...], OK

ga...@google.com <ga...@google.com> May 11, 2020 03:19PM

Marked as fixed.