Feature Request P2
Status Update
Comments
ni...@google.com <ni...@google.com>
ap...@google.com <ap...@google.com> #2
Linking failed
Execution failed for task ':app:processDebugResources'.
> Android resource linking failed
/<Stripped Path>/app/src/main/res/layout/activity_main.xml:9: AAPT: error: attribute layout_behaviour (aka com.example.testlayout:layout_behaviour) not found.
error: failed linking file resources.
Execution failed for task ':app:processDebugResources'.
> Android resource linking failed
/<Stripped Path>/app/src/main/res/layout/activity_main.xml:9: AAPT: error: attribute layout_behaviour (aka com.example.testlayout:layout_behaviour) not found.
error: failed linking file resources.
ap...@google.com <ap...@google.com> #3
If it's Gradle issuse, then I tried with 5.2.1-all and same happens.
ap...@google.com <ap...@google.com> #4
it's an issue with your application, looks like you are referencing @string/appbar_scrolling_view_behavior but do not define it in your resources.
ap...@google.com <ap...@google.com> #5
No, the resource is within Android Library itself, and we implement it in xml by app:layout_behavior="@string/appbar_scrolling_view_behavior". But as of Android Studio 3.4-RC1, it seems to be fixed.:)
ap...@google.com <ap...@google.com> #6
I'm sorry but it seems to persist. I'm posting a xml layout:
<?xml version="1.0" encoding="utf-8"?>
<layout xmlns:android="http://schemas.android.com/apk/res/android "
xmlns:app="http://schemas.android.com/apk/res-auto "
xmlns:tools="http://schemas.android.com/tools ">
<androidx.coordinatorlayout.widget.CoordinatorLayout
android:layout_width="match_parent"
android:layout_height="match_parent">
<com.google.android.material.appbar.AppBarLayout
android:id="@+id/appbar"
style="@style/AppTheme.AppBarStyle"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:theme="@style/AppTheme.AppBarOverlay">
<androidx.appcompat.widget.Toolbar
android:id="@+id/toolbar"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:layout_scrollFlags="scroll|enterAlways|snap"
tools:title="@string/app_name" />
</com.google.android.material.appbar.AppBarLayout>
<androidx.recyclerview.widget.RecyclerView
android:id="@+id/message_recyclerView"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:contentDescription="@string/message_selection_view"
android:shadowColor="@color/grey_800"
app:layout_behavior="@string/appbar_scrolling_view_behavior" />
<com.google.android.material.floatingactionbutton.FloatingActionButton
android:id="@+id/fab"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="bottom|end"
android:layout_margin="@dimen/dp_16"
android:visibility="invisible"
app:backgroundTint="@color/white"
app:rippleColor="?attr/colorControlHighlight"
app:srcCompat="@drawable/ic_cloud_upload"
app:tint="@color/colorAccent" />
</androidx.coordinatorlayout.widget.CoordinatorLayout>
</layout>
As you can see within the RecyclerView that I've used the string resource and it's giving me the error.
Gradle: gradle-5.2.1-all.zip
Project level:
buildscript {
repositories {
google()
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.4.0-rc01'
}
}
Modules:
dependencies {
implementation fileTree(include: ['*.jar'], dir: 'libs')
implementation 'androidx.appcompat:appcompat:1.1.0-alpha02'
implementation 'com.google.android.material:material:1.1.0-alpha04'
implementation 'androidx.constraintlayout:constraintlayout:2.0.0-alpha3'
implementation 'androidx.recyclerview:recyclerview:1.1.0-alpha02'
...
<?xml version="1.0" encoding="utf-8"?>
<layout xmlns:android="
xmlns:app="
xmlns:tools="
<androidx.coordinatorlayout.widget.CoordinatorLayout
android:layout_width="match_parent"
android:layout_height="match_parent">
<com.google.android.material.appbar.AppBarLayout
android:id="@+id/appbar"
style="@style/AppTheme.AppBarStyle"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:theme="@style/AppTheme.AppBarOverlay">
<androidx.appcompat.widget.Toolbar
android:id="@+id/toolbar"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:layout_scrollFlags="scroll|enterAlways|snap"
tools:title="@string/app_name" />
</com.google.android.material.appbar.AppBarLayout>
<androidx.recyclerview.widget.RecyclerView
android:id="@+id/message_recyclerView"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:contentDescription="@string/message_selection_view"
android:shadowColor="@color/grey_800"
app:layout_behavior="@string/appbar_scrolling_view_behavior" />
<com.google.android.material.floatingactionbutton.FloatingActionButton
android:id="@+id/fab"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="bottom|end"
android:layout_margin="@dimen/dp_16"
android:visibility="invisible"
app:backgroundTint="@color/white"
app:rippleColor="?attr/colorControlHighlight"
app:srcCompat="@drawable/ic_cloud_upload"
app:tint="@color/colorAccent" />
</androidx.coordinatorlayout.widget.CoordinatorLayout>
</layout>
As you can see within the RecyclerView that I've used the string resource and it's giving me the error.
Gradle: gradle-5.2.1-all.zip
Project level:
buildscript {
repositories {
google()
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.4.0-rc01'
}
}
Modules:
dependencies {
implementation fileTree(include: ['*.jar'], dir: 'libs')
implementation 'androidx.appcompat:appcompat:1.1.0-alpha02'
implementation 'com.google.android.material:material:1.1.0-alpha04'
implementation 'androidx.constraintlayout:constraintlayout:2.0.0-alpha3'
implementation 'androidx.recyclerview:recyclerview:1.1.0-alpha02'
...
ap...@google.com <ap...@google.com> #7
Another example of AS 3.4 RC 1:
<androidx.core.widget.ContentLoadingProgressBar
android:id="@+id/progress_bar"
style="@style/Widget.MaterialProgressBar.ProgressBar.Horizontal.NoPadding"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:max="100"
android:progress="1"
android:progressTint="@color/colorPrimary" />
Error I'm getting: Can't resolve symbol '@style/Widget.MaterialProgressBar.ProgressBar.Horizontal.NoPadding'
Gradle: gradle-5.1.1-all
Dependencies are same as above. While with latest AS 3.3.2, I'm getting no such error and clicking it, takes me to Android's resource file of values.xml.
P.S. "looks like you are referencing @string/appbar_scrolling_view_behavior but do not define it in your resources.", I would like to add that it compiles perfectly!
<androidx.core.widget.ContentLoadingProgressBar
android:id="@+id/progress_bar"
style="@style/Widget.MaterialProgressBar.ProgressBar.Horizontal.NoPadding"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:max="100"
android:progress="1"
android:progressTint="@color/colorPrimary" />
Error I'm getting: Can't resolve symbol '@style/Widget.MaterialProgressBar.ProgressBar.Horizontal.NoPadding'
Gradle: gradle-5.1.1-all
Dependencies are same as above. While with latest AS 3.3.2, I'm getting no such error and clicking it, takes me to Android's resource file of values.xml.
P.S. "looks like you are referencing @string/appbar_scrolling_view_behavior but do not define it in your resources.", I would like to add that it compiles perfectly!
ap...@google.com <ap...@google.com> #8
Let's track this in the other bug.
ap...@google.com <ap...@google.com> #9
Project: SwiftShader
Branch: master
commit 5e16bc45a1f7540f697d8f651e023025ee83cdc2
Author: Nicolas Capens <capn@google.com>
Date: Wed May 13 13:57:24 2020
Eliminate the array size from rr::Variable
We only need to know the array size during materialization of Array<>
types, so store it only for that class and make the allocation a
virtual method.
This change removes the REACTOR_MATERIALIZE_LVALUES_ON_DEFINITION
option, since it requires knowing the full size of Variable at
construction, which would require Array<> to still pass that into the
Variable constructor. If we need an debugging feature like this again,
we could also materialize variables on first use instead of at
construction.
Bug: b/155302798
Change-Id: I65b02c1258643dcbd3ae18f3f097cb815efa0830
Reviewed-on:https://swiftshader-review.googlesource.com/c/SwiftShader/+/45148
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
M src/Reactor/Reactor.cpp
M src/Reactor/Reactor.hpp
https://swiftshader-review.googlesource.com/45148
Branch: master
commit 5e16bc45a1f7540f697d8f651e023025ee83cdc2
Author: Nicolas Capens <capn@google.com>
Date: Wed May 13 13:57:24 2020
Eliminate the array size from rr::Variable
We only need to know the array size during materialization of Array<>
types, so store it only for that class and make the allocation a
virtual method.
This change removes the REACTOR_MATERIALIZE_LVALUES_ON_DEFINITION
option, since it requires knowing the full size of Variable at
construction, which would require Array<> to still pass that into the
Variable constructor. If we need an debugging feature like this again,
we could also materialize variables on first use instead of at
construction.
Bug:
Change-Id: I65b02c1258643dcbd3ae18f3f097cb815efa0830
Reviewed-on:
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Result: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
M src/Reactor/Reactor.cpp
M src/Reactor/Reactor.hpp
Description
Subzero currently doesn't perform constant folding (beyond some peephole optimizations), because it expects offline compilation to NaCl bytecode to already have performed it. LLVM does constant folding, but it's relatively expensive to produce IR instructions just for constants, and the optimization pass is overly generic (handling arbitrary precision and such).
We should perform constant folding at the Reactor level for the most common cases. One such case is forhttps://swiftshader-review.googlesource.com/c/SwiftShader/+/44468 where some generation-time integer indexing constants are replaced by dynamic Int variables, but in many cases they still just contain constants.