Backport changes that made D8 lenient with non-sense line numbers and local variable table [156142802]

Fixed

Bug

Status Update

No update yet.

Description

js...@google.com

created issue #1

May 9, 2020 08:18AM

Note that this issue is not reproduced on master, but still present up to the latest stable version, 2.0.73. That's why this issue is about figuring out when and how things are fixed, and if possible, backporting them to necessary stable branches, e.g., 2.0 (for AS 4.0).

The issue is found while working on a new front-end (a.k.a. fir) of kotlinc. Please find attached class file generated by (still work-in-progress) fir. Please note that the class file has a resolution error, so the expected behavior is:

$ java -cp .:out.jar main
Exception in thread "main" java.lang.NoSuchMethodError: kotlin.ranges.RangesKt.contains(Lkotlin/ranges/ClosedRange;J)Z
	at InRangeWithNonmatchingArgumentsKt.box(inRangeWithNonmatchingArguments.kt)
	at main.main(main.java:3)

if the main is simply calling InRangeWithNonmatchingArgumentsKt#box.

Interestingly, depending on versions, errors are different, but I guess it's just due to the different place of "first" isConsistentSSA check.

$ git checkout 2.0.73
$ ./tools/d8.py ~/tmp/InRangeWithNonmatchingArgumentsKt.class --output ~/tmp
...
Caused by: java.lang.AssertionError
	at com.android.tools.r8.ir.code.IRCode.consistentDefUseChains(IRCode.java:650)
	at com.android.tools.r8.ir.code.IRCode.isConsistentSSA(IRCode.java:549)
	at com.android.tools.r8.ir.desugar.LambdaRewriter.desugarLambdas(LambdaRewriter.java:278)
	at com.android.tools.r8.ir.conversion.IRConverter.optimize(IRConverter.java:1139)
	at com.android.tools.r8.ir.conversion.IRConverter.rewriteCodeInternal(IRConverter.java:1100)
	at com.android.tools.r8.ir.conversion.IRConverter.lambda$rewriteCode$12(IRConverter.java:1072)
	at com.android.tools.r8.utils.ExceptionUtils.withOriginAttachmentHandler(ExceptionUtils.java:141)
	at com.android.tools.r8.ir.conversion.IRConverter.rewriteCode(IRConverter.java:1068)
	at com.android.tools.r8.ir.conversion.IRConverter.convertMethod(IRConverter.java:608)
	at com.android.tools.r8.ir.conversion.IRConverter.lambda$convertMethods$3(IRConverter.java:567)
	at com.android.tools.r8.graph.DexClass.forEachMethod(DexClass.java:346)
	at com.android.tools.r8.ir.conversion.IRConverter.convertMethods(IRConverter.java:563)
	at com.android.tools.r8.utils.ThreadUtils.lambda$processItems$0(ThreadUtils.java:25)
	at java.base/java.util.concurrent.ForkJoinTask$AdaptedCallable.exec(ForkJoinTask.java:1431)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:283)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1603)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)

$ git checkout 1.6.89
$ ./tools/d8.py ~/tmp/InRangeWithNonmatchingArgumentsKt.class --output ~/tmp
...
Caused by: java.lang.AssertionError
	at com.android.tools.r8.ir.code.IRCode.consistentDefUseChains(IRCode.java:602)
	at com.android.tools.r8.ir.code.IRCode.isConsistentSSA(IRCode.java:501)
	at com.android.tools.r8.ir.optimize.CodeRewriter.rewriteKnownArrayLengthCalls(CodeRewriter.java:3753)
	at com.android.tools.r8.ir.conversion.IRConverter.rewriteCodeInternal(IRConverter.java:1226)
	at com.android.tools.r8.ir.conversion.IRConverter.rewriteCode(IRConverter.java:1044)
	at com.android.tools.r8.ir.conversion.IRConverter.convertMethod(IRConverter.java:605)
	at com.android.tools.r8.ir.conversion.IRConverter.lambda$convertMethods$4(IRConverter.java:564)
	at com.android.tools.r8.graph.DexClass.forEachMethod(DexClass.java:294)
	at com.android.tools.r8.ir.conversion.IRConverter.convertMethods(IRConverter.java:560)
	at com.android.tools.r8.ir.conversion.IRConverter.lambda$convertClasses$3(IRConverter.java:545)
	at java.base/java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1393)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:283)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1603)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)

And, this is the version used by kotlin project (I'll update that once the original issue is fixed; I don't want to update D8/R8 to hide the other issue):

$ git checkout 1.5.70
$ ./tools/d8.py ~/tmp/InRangeWithNonmatchingArgumentsKt.class --output ~/tmp
...
Caused by: com.android.tools.r8.utils.AbortException: Error: java.lang.AssertionError
	at com.android.tools.r8.ir.code.IRCode.consistentDefUseChains(IRCode.java:551)
	at com.android.tools.r8.ir.code.IRCode.isConsistentSSA(IRCode.java:470)
	at com.android.tools.r8.ir.optimize.CodeRewriter.commonSubexpressionElimination(CodeRewriter.java:2913)
	at com.android.tools.r8.ir.conversion.IRConverter.rewriteCode(IRConverter.java:987)
	at com.android.tools.r8.ir.conversion.IRConverter.convertMethodToDex(IRConverter.java:486)
	at com.android.tools.r8.ir.conversion.IRConverter.lambda$convertMethodsToDex$3(IRConverter.java:474)
	at com.android.tools.r8.graph.DexClass.forEachMethod(DexClass.java:291)
	at com.android.tools.r8.ir.conversion.IRConverter.convertMethodsToDex(IRConverter.java:470)
	at com.android.tools.r8.ir.conversion.IRConverter.lambda$convertClassesToDex$2(IRConverter.java:455)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
	Suppressed: java.util.concurrent.ExecutionException: java.lang.AssertionError
		at java.util.concurrent.FutureTask.report(FutureTask.java:122)
		at java.util.concurrent.FutureTask.get(FutureTask.java:192)
		at com.android.tools.r8.utils.ThreadUtils.awaitFutures(ThreadUtils.java:21)
		at com.android.tools.r8.ir.conversion.IRConverter.convertClassesToDex(IRConverter.java:457)
		at com.android.tools.r8.ir.conversion.IRConverter.convertToDex(IRConverter.java:364)
		at com.android.tools.r8.D8.optimize(D8.java:230)
		at com.android.tools.r8.D8.run(D8.java:171)
		at com.android.tools.r8.D8.lambda$run$1(D8.java:98)
		at com.android.tools.r8.utils.ExceptionUtils.withCompilationHandler(ExceptionUtils.java:61)
		at com.android.tools.r8.utils.ExceptionUtils.withD8CompilationHandler(ExceptionUtils.java:44)
		at com.android.tools.r8.D8.run(D8.java:95)

InRangeWithNonmatchingArgumentsKt.class

2.3 KB

Download

Comments

sg...@google.com <sg...@google.com> May 11, 2020 07:33AM

Reassigned to cl...@google.com.

cl...@google.com <cl...@google.com> #2May 11, 2020 12:33PM

I'd like to fix the formatting but I can't edit my issue.

cl...@google.com <cl...@google.com> #3May 14, 2020 08:18AM

Our team is also running into this because we use kotlin reflection to set up mock data for previews.

Can you suggest any workaround that we can apply locally to make layout lib include kotlin reflect until it is officially fixed? We are obviously including it as a build dependency but the layout lib preview doesn't pick it up for some reason.

Message last modified on May 15, 2020 07:23AM

cl...@google.com <cl...@google.com> #4May 14, 2020 02:25PM

I do not see this issue in Electric Eel Beta 4, but I do see it in Flamingo Canary 6.

Message last modified on May 15, 2020 07:24AM

cl...@google.com <cl...@google.com> #5May 15, 2020 07:23AM

I do not see this issue in Electric Eel Beta 4, but I do see it in Flamingo Canary 6.

Is it with the very same project? I'm trying to rule out whether this is related to specific library/compiler versions.

Thanks!

ap...@google.com <ap...@google.com> #6May 15, 2020 11:21AM

Yes, that was with the same project. I can double check with the latest versions of each IDE and get back to you though.

cl...@google.com <cl...@google.com> #7May 18, 2020 06:34AM

Marked as fixed.

Correction: I was either mistaken before, or behavior has changed, but I am now getting the KotlinReflectionNotSupportedError issue for IDE compose previews in both EE Beta 5 and Flamingo Canary 8.

Kotlin 1.6.21 AGP 7.3

an...@google.com <an...@google.com> #8May 20, 2020 02:58PM

Hi, I'm also running into this issue in the preview with Kotlin 1.7.10 on Android Studio Dolphine (2021.3.1). Have you found a workaround in the meantime?

to...@gmail.com <to...@gmail.com> #9May 22, 2020 08:57AM

We're having the same issue on Android Studio Dolphin (2021.3.1) with Kotlin 1.6.10. The issue occurs when we use class references with kotlin reflect. The behavior can only be seen in Compose Preview's runtime. Everything works perfectly fine in android runtime, though.

sg...@google.com <sg...@google.com> #10May 27, 2020 08:50AM

Diego, this looks to be the same problem as issue 183889504, which was marked as Fixed. Are you aware of a fix? If that issue was incorrectly marked as fixed, feel free to bounce this one back to me. Thanks!