For loop with Horizontal or Vertical Scroller Crashes [156853976]

Fixed

Bug

Status Update

No update yet.

Description

pr...@gmail.com

created issue #1

May 18, 2020 05:40PM

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Android Studio Build: 4.1 Canary 9

Version of Gradle Plugin: 4.1.0-alpha09

Version of Gradle: 6.4

Version of Kotlin: 1.3.70

OS: Arch Linux

Version of Compose: dev-11

Steps to Reproduce:

Use the following code in setContent and run app

   MaterialTheme {
       for (x in 0..2) {
           HorizontalScroller {

           }
       }
   }

Result: Crash with stacktrack:

2020-05-18 18:29:27.344 7786-7786/com.vanpra.composeviewpager E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.vanpra.composeviewpager, PID: 7786
    java.lang.IllegalArgumentException: Key -1675089381 was already registered. Please call unregister before registering again
        at androidx.ui.savedinstancestate.UiSavedStateRegistryImpl.registerProvider(UiSavedStateRegistry.kt:97)
        at androidx.ui.savedinstancestate.ValueProvider.updateAndReturnValue(RememberSavedInstanceState.kt:101)
        at androidx.ui.savedinstancestate.RememberSavedInstanceStateKt.rememberSavedInstanceState(RememberSavedInstanceState.kt:66)
        at androidx.ui.savedinstancestate.RememberSavedInstanceStateKt.rememberSavedInstanceState$default(RememberSavedInstanceState.kt:53)
        at androidx.ui.foundation.ScrollerKt.ScrollerPosition(Scroller.kt:62)
        at androidx.ui.foundation.ScrollerKt.ScrollerPosition$default(Scroller.kt:57)
        at androidx.ui.foundation.ScrollerKt.HorizontalScroller$default(Scroller.kt:237)
        at com.vanpra.composeviewpager.MainActivity$onCreate$1$1.invoke(MainActivity.kt:25)
        at com.vanpra.composeviewpager.MainActivity$onCreate$1$1.invoke(Unknown Source:2)
        at androidx.compose.internal.RestartableFunction.invoke(RestartableFunction.kt:131)
        at androidx.compose.internal.RestartableFunction.invoke(Unknown Source:2)
        at androidx.compose.AmbientKt.Providers(Ambient.kt:175)
        at androidx.ui.foundation.TextKt.ProvideTextStyle(Text.kt:257)
        at androidx.ui.material.MaterialThemeKt$MaterialTheme$1$1.invoke(MaterialTheme.kt:98)
        at androidx.ui.material.MaterialThemeKt$MaterialTheme$1$1.invoke(Unknown Source:2)
        at androidx.compose.internal.RestartableFunction.invoke(RestartableFunction.kt:131)
        at androidx.compose.internal.RestartableFunction.invoke(Unknown Source:2)
        at androidx.compose.AmbientKt.Providers(Ambient.kt:175)
        at androidx.ui.material.MaterialThemeKt$MaterialTheme$1.invoke(MaterialTheme.kt:98)
        at androidx.ui.material.MaterialThemeKt$MaterialTheme$1.invoke(Unknown Source:2)
        at androidx.compose.internal.RestartableFunction.invoke(RestartableFunction.kt:131)
        at androidx.compose.internal.RestartableFunction.invoke(Unknown Source:2)
        at androidx.compose.AmbientKt.Providers(Ambient.kt:175)
        at androidx.ui.material.ColorKt.ProvideColorPalette(Color.kt:331)
        at androidx.ui.material.MaterialThemeKt.MaterialTheme(MaterialTheme.kt:98)
        at androidx.ui.material.MaterialThemeKt.MaterialTheme$default(MaterialTheme.kt:49)
        at com.vanpra.composeviewpager.MainActivity$onCreate$1.invoke(MainActivity.kt:25)
        at com.vanpra.composeviewpager.MainActivity$onCreate$1.invoke(Unknown Source:2)
        at androidx.compose.internal.RestartableFunction.invoke(RestartableFunction.kt:131)
        at androidx.compose.internal.RestartableFunction.invoke(Unknown Source:2)
        at androidx.ui.core.selection.SelectionContainerKt$SelectionContainer$5$1.invoke(SelectionContainer.kt:238)
        at androidx.ui.core.selection.SelectionContainerKt$SelectionContainer$5$1.invoke(Unknown Source:2)
        at androidx.compose.internal.RestartableFunction.invoke(RestartableFunction.kt:131)
        at androidx.compose.internal.RestartableFunction.invoke(Unknown Source:2)
        at androidx.ui.core.LayoutKt.Layout(Layout.kt:675)
        at androidx.ui.core.LayoutKt.Layout(Layout.kt:630)
        at androidx.ui.core.selection.SelectionContainerKt.Wrap(SelectionContainer.kt:319)
        at androidx.ui.core.selection.SelectionContainerKt.access$Wrap(Unknown Source:0)
        at androidx.ui.core.selection.SelectionContainerKt$SelectionContainer$5.invoke(SelectionContainer.kt:238)
        at androidx.ui.core.selection.SelectionContainerKt$SelectionContainer$5.invoke(Unknown Source:2)
        at androidx.compose.internal.RestartableFunction.invoke(RestartableFunction.kt:131)
        at androidx.compose.internal.RestartableFunction.invoke(Unknown Source:2)
        at androidx.compose.AmbientKt.Providers(Ambient.kt:175)
        at androidx.ui.core.selection.SelectionContainerKt.SelectionContainer(SelectionContainer.kt:303)
        at androidx.ui.core.selection.SelectionContainerKt.SelectionContainer(SelectionContainer.kt:262)
        at androidx.ui.core.WrapperKt.WrapWithSelectionContainer(Wrapper.kt:497)
2020-05-18 18:29:27.345 7786-7786/com.vanpra.composeviewpager E/AndroidRuntime:     at androidx.ui.core.WrapperKt.access$WrapWithSelectionContainer(Unknown Source:0)
        at androidx.ui.core.WrappedComposition$setContent$1$1.invoke(Wrapper.kt:497)
        at androidx.ui.core.WrappedComposition$setContent$1$1.invoke(Unknown Source:2)
        at androidx.compose.internal.RestartableFunction.invoke(RestartableFunction.kt:131)
        at androidx.compose.internal.RestartableFunction.invoke(Unknown Source:2)
        at androidx.compose.AmbientKt.Providers(Ambient.kt:175)
        at androidx.ui.core.WrapperKt.WrapWithAmbients(Wrapper.kt:546)
        at androidx.ui.core.WrapperKt.access$WrapWithAmbients(Unknown Source:0)
        at androidx.ui.core.WrappedComposition$setContent$1.invoke(Wrapper.kt:497)
        at androidx.ui.core.WrappedComposition$setContent$1.invoke(Unknown Source:2)
        at androidx.compose.internal.RestartableFunction.invoke(RestartableFunction.kt:131)
        at androidx.compose.internal.RestartableFunction.invoke(Unknown Source:2)
        at androidx.compose.ComposerKt.invokeComposable(Composer.kt:2247)
        at androidx.compose.Recomposer.recompose$compose_runtime_release(Recomposer.kt:67)
        at androidx.compose.CompositionImpl.setContent(Composition.kt:120)
        at androidx.ui.core.WrappedComposition.setContent(Wrapper.kt:267)
        at androidx.ui.core.WrappedComposition$setContent$2.invoke(Wrapper.kt:278)
        at androidx.ui.core.WrappedComposition$setContent$2.invoke(Unknown Source:2)
        at androidx.ui.core.SavedStateDelegate.stopWaitingForStateRestoration(SavedStateDelegate.kt:84)
        at androidx.ui.core.AndroidComposeView.onMeasure(AndroidOwner.kt:484)
        at android.view.View.measure(View.java:25362)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6859)
        at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
        at androidx.appcompat.widget.ContentFrameLayout.onMeasure(ContentFrameLayout.java:143)
        at android.view.View.measure(View.java:25362)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6859)
        at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1552)
        at android.widget.LinearLayout.measureVertical(LinearLayout.java:842)
        at android.widget.LinearLayout.onMeasure(LinearLayout.java:721)
        at android.view.View.measure(View.java:25362)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6859)
        at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
        at android.view.View.measure(View.java:25362)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6859)
        at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1552)
        at android.widget.LinearLayout.measureVertical(LinearLayout.java:842)
        at android.widget.LinearLayout.onMeasure(LinearLayout.java:721)
        at android.view.View.measure(View.java:25362)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6859)
        at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
        at com.android.internal.policy.DecorView.onMeasure(DecorView.java:739)
        at android.view.View.measure(View.java:25362)
        at android.view.ViewRootImpl.performMeasure(ViewRootImpl.java:3329)
        at android.view.ViewRootImpl.measureHierarchy(ViewRootImpl.java:2175)
        at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2432)
        at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1906)
        at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8089)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:972)
        at android.view.Choreographer.doCallbacks(Choreographer.java:796)
        at android.view.Choreographer.doFrame(Choreographer.java:731)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:957)
        at android.os.Handler.handleCallback(Handler.java:907)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7478)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:549)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:941)a

I believe that this might be due to the fact that the HorizontalScroller is being treated the same for each iteration of the loop meaning that the HorizontalScroller is initalised with a ScrollerPosition with rememberSavedInstanceState with the same id causing a conflict and hence crashing

Comments

cl...@google.com <cl...@google.com> May 18, 2020 05:41PM

Assigned to le...@google.com.

le...@google.com <le...@google.com> #2Jun 3, 2020 09:42PM

Reassigned to ch...@google.com.

May I ask why P3? This is blocking for me to go to prod, I'd really like some inputs about what is going on so I can either fix or build a repro to have this fixed.

ch...@google.com <ch...@google.com> #3Jun 4, 2020 03:41PM

Unfortunately I am unable to reproduce it as well. Maybe there is a chance you can share your code with me? You can send it to my email as you did previously already.
For the ideas on what to take a look, how do you use LazyListState.layoutInfo in your app? Will it continue growing if you comment out such usages?

ap...@google.com <ap...@google.com> #4Aug 4, 2020 12:02PM

Marked as fixed.

It happens even on screens that does not use the layoutInfo it just require many up / down flings.

LazyColumn(state = rememberLazyListState())

The only thing all screen have in common in that they have multiple item {} item{} block :(

Just in case the app is in open beta at https://play.google.com/store/apps/details?id=app.symfonik.music.player but don't think you can see much except repro.

My main question before trying to do complex repro, is how much will it be relevant with all the recent changes in alpha 8 about Lazy stuff? And side question when https://issuetracker.google.com/issues/229752147 is fixed (it touches all my screens maybe another indicator?) will there be some snapshot build with the fix so I can directly try to repro on that?

an...@google.com <an...@google.com> Aug 4, 2020 02:42PM

Reassigned to an...@google.com.

Issue 156853976