IssueTracker

Ok so the test was quick this is a regression from 2.0.73.

In 2.0.73 the load2 function is properly kept and used:

$$ServiceLoaderMethods -> a:
    java.util.Iterator $load1() -> a
    java.util.Iterator $load2() -> b

.class public abstract synthetic La;
.super Ljava/lang/Object;
.source "ServiceLoader"


# direct methods
.method public static a()Ljava/util/Iterator;
    .registers 3

    const/4 v0, 0x1

    :try_start_1
    new-array v0, v0, [Lkotlinx/coroutines/CoroutineExceptionHandler;

    const/4 v1, 0x0

    new-instance v2, Lkotlinx/coroutines/android/AndroidExceptionPreHandler;

    invoke-direct {v2}, Lkotlinx/coroutines/android/AndroidExceptionPreHandler;-><init>()V

    aput-object v2, v0, v1

    invoke-static {v0}, Ljava/util/Arrays;->asList([Ljava/lang/Object;)Ljava/util/List;

    move-result-object v0

    invoke-interface {v0}, Ljava/util/List;->iterator()Ljava/util/Iterator;

    move-result-object v0
    :try_end_13
    .catchall {:try_start_1 .. :try_end_13} :catchall_14

    return-object v0

    :catchall_14
    move-exception v0

    new-instance v1, Ljava/util/ServiceConfigurationError;

    invoke-virtual {v0}, Ljava/lang/Throwable;->getMessage()Ljava/lang/String;

    move-result-object v2

    invoke-direct {v1, v2, v0}, Ljava/util/ServiceConfigurationError;-><init>(Ljava/lang/String;Ljava/lang/Throwable;)V

    throw v1
.end method

.method public static b()Ljava/util/Iterator;
    .registers 3

    const/4 v0, 0x1

    :try_start_1
    new-array v0, v0, [Lkotlinx/coroutines/android/AndroidDispatcherFactory;

    const/4 v1, 0x0

    new-instance v2, Lkotlinx/coroutines/android/AndroidDispatcherFactory;

    invoke-direct {v2}, Lkotlinx/coroutines/android/AndroidDispatcherFactory;-><init>()V

    aput-object v2, v0, v1

    invoke-static {v0}, Ljava/util/Arrays;->asList([Ljava/lang/Object;)Ljava/util/List;

    move-result-object v0

    invoke-interface {v0}, Ljava/util/List;->iterator()Ljava/util/Iterator;

    move-result-object v0
    :try_end_13
    .catchall {:try_start_1 .. :try_end_13} :catchall_14

    return-object v0

    :catchall_14
    move-exception v0

    new-instance v1, Ljava/util/ServiceConfigurationError;

    invoke-virtual {v0}, Ljava/lang/Throwable;->getMessage()Ljava/lang/String;

    move-result-object v2

    invoke-direct {v1, v2, v0}, Ljava/util/ServiceConfigurationError;-><init>(Ljava/lang/String;Ljava/lang/Throwable;)V

    throw v1
.end method

Thank you for reporting the issue. Without being certain, this may to be because the code did not synchronize on adding the methods. Can I ask you to try out the d6056e52d2fb56d9379d53b3995ea1e0ca865b90 build from here https://r8-review.googlesource.com/c/r8/+/51686/2 by adding the following to your top-level build.gradle file:

buildscript {

    repositories {
        maven {
            url "https://storage.googleapis.com/r8-releases/raw/master"
        }
    }

    dependencies {
        classpath 'com.android.tools:r8:d6056e52d2fb56d9379d53b3995ea1e0ca865b90'  // Must be before the Gradle Plugin for Android.
        classpath 'com.android.tools.build:gradle:X.Y.Z'     // Your current AGP version.
     }
}

The change from 2.0.73 to 2.0.74 should not have any impact on the serviceloader rewriting. As such, because this seem to be a concurrency issue, if I could ask you to do a few builds from, and clean a few times, just to have a bit more test surface.

I'll try tomorrow but I made dozens if not hundreds of 2.0.73 build without issues, and all 3 attempts on 2.0.74 did trigger this and the revert instantly fixed it too.

Ok so after 4 builds no reproduction of the issue with that one.

And after full gradle clean / reboot everything no more reproduced on 2.0.74 either.

Previously had faced https://issuetracker.google.com/issues/144443055 , could this race be the same as that one before and a reboot change the condition that triggered the race?

Thanks, I see that 2.1 is now branched, does it contains this so I can play with it?

The fix is a bit different but should still work the same, so yes, go right ahead.