Maintain size and theme selection of design preview rendering [158344314]

Fixed

Bug

Status Update

No update yet.

Description

rc...@gmail.com

created issue #1

Jun 6, 2020 11:27AM

Current behavior of the Design screen of a layout file is that size and theme selection revert to default selections after the editor is closed. This requires a lot of repetitive theme selection and resizing of the design screen. (Especially those partial screen layout files such as list items or includes.)

Persisting the selection of theme and size between edit sessions will make a smoother UI editing experience.

Build: AI-193.6911.18.40.6514223, 202005201507,

AI-193.6911.18.40.6514223, JRE 1.8.0_242-release-1644-b3-6222593x64 JetBrains s.r.o, OS Linux(amd64) v5.4.0-33-generic, screens 1920x1200

AS: 4.0; Kotlin plugin: 1.4-M2-release-Studio4.0-1; Android Gradle Plugin: 4.0.0; Gradle: 6.1.1; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)

IMPORTANT: Please read

https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Comments

vi...@google.com <vi...@google.com> Jun 8, 2020 07:18AM

Assigned to an...@google.com.

di...@google.com <di...@google.com> #2Aug 19, 2020 05:41PM

Reassigned to ch...@google.com.

Charlie we should save the theme and possibly other things like orientation, would you mind having a look?

ch...@google.com <ch...@google.com> #3Sep 3, 2020 01:22PM

Keeping same preview size and orientation makes sense

But I think Theme is a little bit different. For now the auto-applied theme is the one which used at runtime.
While user changes the theme, the preview becomes different rather than the runtime one.
It may be confused if user doesn't notice the applied Theme is not the runtime one after reopening the file.

We need some UI/UX investigation for the Theme case.

rc...@gmail.com <rc...@gmail.com> #4Sep 5, 2020 08:26AM

Great to read about the size and orientation!

Theming indeed sounds like a different case. It is interesting to me that I never noticed any auto-applied theme to be the actual runtime one. My experience is that it is always required to find and select the runtime theme before using the preview. In my described scenario an auto-applied theme matching runtime is the same theme I keep re-selecting.

My projects tend have a feature-modules with layout and a theme/colors defined in another modules. Maybe that is why the auto-applied theme doesn't help me. It make me wonder that if I restructure the theme resources in the modules if that allows the auto-applied theme in preview to match the one applied in the runtime app.

rc...@gmail.com <rc...@gmail.com> #5Sep 5, 2020 02:32PM

If I duplicate the theme attribute found in the merged application manifest into the feature module manifest then the auto-applied theme makes sense!

ch...@google.com <ch...@google.com> #6Nov 5, 2020 03:53PM

Marked as fixed.

Hi, keeping same orientation and size (the zoom level) are supported, you should able to find it in the following releases.
>> If I duplicate the theme attribute found in the merged application manifest into the feature module manifest then the auto-applied theme makes sense!

It looks like thee auto-applied theme is good to you :)
I would like to close this bug now.

If you find a case which the auto-applied theme is wrong, please re-open or create another bug and assign to me.
I would be good to have a reproducible project for the issue too :)

Thanks for the help and feedback!

Issue 158344314