Studio clipboard does not pick up clipboard selection from the emulator [158874142]

Fixed

Bug

Status Update

No update yet.

Description

tn...@google.com

created issue #1

Jun 12, 2020 10:43PM

See https://www.reddit.com/r/androiddev/comments/h0gcki/android_studio_41_beta_1_available/ftopm12?utm_source=share&utm_medium=web2x : """ I'm having an issue with system clipboard on macOS though. In an external emulator it works fine with GBoard, but with embedded emulator it doesn't pick up anything copied outside of the emulator. """

Comments

sp...@google.com <sp...@google.com> #2Jun 12, 2020 10:46PM

Assigned to ja...@google.com.

Are there any updates here?

ja...@google.com <ja...@google.com> #3Jun 15, 2020 04:39PM

I looked at it and I'm planning to remove the deduplicating lookup the callstack refers to. It should be no longer needed. How was the 80ms in comment#1 calculated? If it's straightforward I'll calculate it again before my change goes in.

ja...@google.com <ja...@google.com> Jun 15, 2020 10:40PM

Accepted by ja...@google.com.

ja...@google.com <ja...@google.com> #4Jun 16, 2020 07:08PM

Assigned to sp...@google.com.

I couldn't move the logging off thread but I was able to address an area of concern in the callstack:
com.google.protobuf.Descriptors$FileDescriptor.internalBuildGeneratedFileFrom(Descriptors.java)
com.android.build.gradle.internal.cxx.logging.CxxLogging.<clinit>(CxxLogging.java:82)
com.android.build.gradle.internal.cxx.logging.LoggingMessage.getDescriptor(LoggingMessage.java:110)
com.android.build.gradle.internal.cxx.logging.LoggingMessage.hashCode(LoggingMessage.java:489)
java.util.HashMap.hash(HashMap.java:340)
java.util.HashMap.containsKey(HashMap.java:592)
java.util.HashSet.contains(HashSet.java:204)

This logic was deduplicating messages (including chatty 'info' messages). This deduplication shouldn't be needed anymore so I removed it.

I don't know how the 80ms from

comment#1

was gathered so I can't say how much it has improved logging, but it should help quite a bit. Let me know if you can still measure a performance issue. The next step would be to reduce the 'info' that's logged.

ja...@google.com <ja...@google.com> #5Jun 16, 2020 07:09PM

The change mentioned in

comment#4

(internal Id I4e51a10d9ee2a81ca56c8e81c7890dfb0bf239d7) should be available in Canary 8 of Flamingo.

sp...@google.com <sp...@google.com> Jun 18, 2020 12:09AM

Accepted by sp...@google.com.

an...@google.com <an...@google.com> #6Jun 18, 2020 05:36PM

The following changes were cherrypicked through Coastguard
Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6328387217195008/#/history/all)\ Changes: ag/11902924

sp...@google.com <sp...@google.com> Jun 18, 2020 09:46PM

Marked as fixed.

mo...@gmail.com <mo...@gmail.com> #7Jul 10, 2020 09:34PM

https://developer.android.com/reference/androidx/test/runner/MonitoringInstrumentation.ActivityFinisher#run