Rename `Button` object to `ButtonConstants` [159687878]

Fixed

Internal Cleanup

Status Update

No update yet.

Description

js...@google.com

created issue #1

Jun 23, 2020 10:19AM

TLDR: The object Button should be renamed object ButtonConstants. Similarly we should probably rename Scaffold, TabRow, FilledTextField, OutlinedTextField (and are there any others?) to follow the same pattern.

As per Compose API Council on April 6, 2020, we decided the public constants for any composable Foo should go on an object called FooConstants instead of an object named Foo. The primary motivation is that there is a naming overload/collision such that when you search for a widget by name in AndroidStudio, you would naturally open the wrong object and then get confused by how it worked, although there were also other similar considerations that pushed us in this direction.

Comments

an...@google.com <an...@google.com> #2Jun 23, 2020 10:25AM

We recently landed stability improvements and bugfixes in aosp/2258262 and will stabilize ModalBottomSheetLayout following a few release cycles. We are still evaluating the future API of BottomSheetScaffold and are expecting it to stay experimental for a bit more while we migrate it to Swipeable V2.

Message last modified on Jun 23, 2020 10:26AM

js...@google.com <js...@google.com> #3Jun 23, 2020 10:40AM

@jossiwolf is this on track for 1.6 or moved out to 1.7?

an...@google.com <an...@google.com> #4Jun 23, 2020 11:12AM

Currently slated for 1.7

js...@google.com <js...@google.com> #5Jun 23, 2020 11:27AM

Bumping to P1 as it is been a long while since we need to land this.

js...@google.com <js...@google.com> #6Jun 23, 2020 11:46AM

Do we expect this to land by EOW? It's in the SLO chaselist now and very on fire.

Message last modified on Jun 23, 2020 11:49AM

lp...@google.com <lp...@google.com> #7Jun 23, 2020 12:44PM

Hi jossiwolf, is this part of alpha02?

js...@google.com <js...@google.com> #8Jun 23, 2020 12:49PM

Project: platform/frameworks/support
Branch: androidx-main

commit e299b64fa3574b44e745173f406bc3b49e1d47f7
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon Nov 27 19:34:32 2023

[M2] Stabilize ModalBottomSheetLayout

Relnote: Material (2) modal bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 266780235, 261409034
Test: Added modalBottomSheet_show_animatesToHalfExpandedFirstAndToExpandedAfter
Change-Id: Ic53f4fe7c7183569cb7322c8f56f571be5316be0

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetStateTest.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt

https://android-review.googlesource.com/2852687

Message last modified on Jun 23, 2020 12:53PM

an...@google.com <an...@google.com> #9Jun 26, 2020 11:58AM

Project: platform/frameworks/support
Branch: androidx-main

commit 8cae2e36009d6c9c6905c4385e2db39100eff3ef
Author: Jossi Wolf <jossiwolf@google.com>
Date: Wed Nov 29 14:21:26 2023

[M2] Stabilize BottomSheetScaffold

Relnote: Material (2) standard bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 261409034
Test: Existing tests
Change-Id: I3c1a892338d183db35ecf3c023255682b4e785bd

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt

https://android-review.googlesource.com/2852688

ap...@google.com <ap...@google.com> #10Jun 26, 2020 01:31PM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.7.0-alpha03
androidx.compose.material:material-android:1.7.0-alpha03
androidx.compose.material:material-desktop:1.7.0-alpha03

js...@google.com <js...@google.com> #11Jun 29, 2020 09:24AM

What about FilledTextField, and OutlinedTextField?

js...@google.com <js...@google.com> #12Jun 29, 2020 10:10AM

What about FilledTextField and OutlinedTextField?

an...@google.com <an...@google.com> #13Jun 29, 2020 10:21AM

these two are private, so I think we can keep them for now