Fixed
Status Update
Comments
an...@google.com <an...@google.com> #2
We recently landed stability improvements and bugfixes in aosp/2258262 and will stabilize ModalBottomSheetLayout following a few release cycles. We are still evaluating the future API of BottomSheetScaffold and are expecting it to stay experimental for a bit more while we migrate it to Swipeable V2.
js...@google.com <js...@google.com> #3
@jossiwolf is this on track for 1.6 or moved out to 1.7?
an...@google.com <an...@google.com> #4
Currently slated for 1.7
js...@google.com <js...@google.com> #5
Bumping to P1 as it is been a long while since we need to land this.
js...@google.com <js...@google.com> #6
Do we expect this to land by EOW? It's in the SLO chaselist now and very on fire.
lp...@google.com <lp...@google.com> #7
Hi jossiwolf, is this part of alpha02?
js...@google.com <js...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit e299b64fa3574b44e745173f406bc3b49e1d47f7
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon Nov 27 19:34:32 2023
[M2] Stabilize ModalBottomSheetLayout
Relnote: Material (2) modal bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 266780235, 261409034
Test: Added modalBottomSheet_show_animatesToHalfExpandedFirstAndToExpandedAfter
Change-Id: Ic53f4fe7c7183569cb7322c8f56f571be5316be0
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetStateTest.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
https://android-review.googlesource.com/2852687
Branch: androidx-main
commit e299b64fa3574b44e745173f406bc3b49e1d47f7
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon Nov 27 19:34:32 2023
[M2] Stabilize ModalBottomSheetLayout
Relnote: Material (2) modal bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 266780235, 261409034
Test: Added modalBottomSheet_show_animatesToHalfExpandedFirstAndToExpandedAfter
Change-Id: Ic53f4fe7c7183569cb7322c8f56f571be5316be0
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetStateTest.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
an...@google.com <an...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-main
commit 8cae2e36009d6c9c6905c4385e2db39100eff3ef
Author: Jossi Wolf <jossiwolf@google.com>
Date: Wed Nov 29 14:21:26 2023
[M2] Stabilize BottomSheetScaffold
Relnote: Material (2) standard bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 261409034
Test: Existing tests
Change-Id: I3c1a892338d183db35ecf3c023255682b4e785bd
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
https://android-review.googlesource.com/2852688
Branch: androidx-main
commit 8cae2e36009d6c9c6905c4385e2db39100eff3ef
Author: Jossi Wolf <jossiwolf@google.com>
Date: Wed Nov 29 14:21:26 2023
[M2] Stabilize BottomSheetScaffold
Relnote: Material (2) standard bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 261409034
Test: Existing tests
Change-Id: I3c1a892338d183db35ecf3c023255682b4e785bd
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
ap...@google.com <ap...@google.com> #10
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.7.0-alpha03
androidx.compose.material:material-android:1.7.0-alpha03
androidx.compose.material:material-desktop:1.7.0-alpha03
js...@google.com <js...@google.com> #11
What about FilledTextField
, and OutlinedTextField
?
js...@google.com <js...@google.com> #12
What about FilledTextField
and OutlinedTextField
?
an...@google.com <an...@google.com> #13
these two are private, so I think we can keep them for now
Description
TLDR: The
object Button
should be renamedobject ButtonConstants
. Similarly we should probably renameScaffold
,TabRow
,FilledTextField
,OutlinedTextField
(and are there any others?) to follow the same pattern.As per Compose API Council on April 6, 2020, we decided the public constants for any composable
Foo
should go on an object calledFooConstants
instead of an object namedFoo
. The primary motivation is that there is a naming overload/collision such that when you search for a widget by name in AndroidStudio, you would naturally open the wrong object and then get confused by how it worked, although there were also other similar considerations that pushed us in this direction.