Fixed
Status Update
Comments
al...@google.com <al...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 53d7e9505dce7026e7c92059d42e5de784739106
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 16:26:25 2021
Avoid nullable boolean in constraint trackers
Now instead of returning null, trackers work pessimistically,
e.g. BatteryChargingTracker says that battery isn't charging.
It is done in preparation for Kotlin migration, where
this code smell is more apparent.
bug: 209145335
Test: *TrackerTest were updated
Change-Id: Ie1dcbe8961d925784d5633a297307993f3b8a43b
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/ConstraintTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.java
https://android-review.googlesource.com/1911432
Branch: androidx-main
commit 53d7e9505dce7026e7c92059d42e5de784739106
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 16:26:25 2021
Avoid nullable boolean in constraint trackers
Now instead of returning null, trackers work pessimistically,
e.g. BatteryChargingTracker says that battery isn't charging.
It is done in preparation for Kotlin migration, where
this code smell is more apparent.
bug: 209145335
Test: *TrackerTest were updated
Change-Id: Ie1dcbe8961d925784d5633a297307993f3b8a43b
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/ConstraintTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.java
to...@gmail.com <to...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 37b6a3fbb83456e319412c81f5039ffede5571c1
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:33:19 2021
Bump room 2.4.0-rc01
bug: 209145335
Test: refactoring
Change-Id: I29efb1b5a2e49ceddae999ed244803889723b080
M work/work-runtime/build.gradle
M work/work-runtime-ktx/build.gradle
M work/work-inspection/build.gradle
M work/work-gcm/build.gradle
M work/work-multiprocess/build.gradle
M work/work-benchmark/build.gradle
M work/work-testing/build.gradle
M work/integration-tests/testapp/build.gradle
https://android-review.googlesource.com/1910055
Branch: androidx-main
commit 37b6a3fbb83456e319412c81f5039ffede5571c1
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:33:19 2021
Bump room 2.4.0-rc01
bug: 209145335
Test: refactoring
Change-Id: I29efb1b5a2e49ceddae999ed244803889723b080
M work/work-runtime/build.gradle
M work/work-runtime-ktx/build.gradle
M work/work-inspection/build.gradle
M work/work-gcm/build.gradle
M work/work-multiprocess/build.gradle
M work/work-benchmark/build.gradle
M work/work-testing/build.gradle
M work/integration-tests/testapp/build.gradle
si...@google.com <si...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit e8d484789c3d8dc134b9ecf1d4e282f51223920c
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 22:22:39 2021
Migrate top-level androidx.work.impl.constraints to Kotlin
bug: 209145335
Test: refactoring, test passes
Change-Id: I0dc5e63898a3b2b2668059bf163a7573de8a932a
M work/work-runtime/src/main/java/androidx/work/impl/constraints/NetworkState.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsCallback.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/ConstraintsCommandHandler.java
https://android-review.googlesource.com/1910059
Branch: androidx-main
commit e8d484789c3d8dc134b9ecf1d4e282f51223920c
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 22:22:39 2021
Migrate top-level androidx.work.impl.constraints to Kotlin
bug: 209145335
Test: refactoring, test passes
Change-Id: I0dc5e63898a3b2b2668059bf163a7573de8a932a
M work/work-runtime/src/main/java/androidx/work/impl/constraints/NetworkState.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsCallback.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/ConstraintsCommandHandler.java
se...@google.com <se...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 2c5b5f38cc45864ee52c3475360d5a931fd5e2bb
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 18:56:38 2021
Rename top-level *.java to *.kt in androidx.work.impl.constraints
bug: 209145335
Test: NA
Change-Id: I8c9f0f410eadd940fd859512c2879b46c2bb20b0
M work/work-runtime/src/main/java/androidx/work/impl/constraints/NetworkState.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsCallback.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
https://android-review.googlesource.com/1910058
Branch: androidx-main
commit 2c5b5f38cc45864ee52c3475360d5a931fd5e2bb
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 18:56:38 2021
Rename top-level *.java to *.kt in androidx.work.impl.constraints
bug: 209145335
Test: NA
Change-Id: I8c9f0f410eadd940fd859512c2879b46c2bb20b0
M work/work-runtime/src/main/java/androidx/work/impl/constraints/NetworkState.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsCallback.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
to...@gmail.com <to...@gmail.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 143f2871b37b9f7fefff10ea7b64637b2c3b7f71
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sun Dec 05 15:39:07 2021
WorkManager: Migrate entities Kotlin
bug: 209145335
Test: refactoring
Change-Id: I3e112e2093d9b90712176e72087a3b4cebc374f9
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/Dependency.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/IdGenerator.java
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkName.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfo.kt
M work/work-runtime/src/main/java/androidx/work/WorkRequest.java
M work/work-runtime/src/main/java/androidx/work/impl/model/Preference.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkProgress.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkTest.java
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTag.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/utils/IdGeneratorTest.java
https://android-review.googlesource.com/1910061
Branch: androidx-main
commit 143f2871b37b9f7fefff10ea7b64637b2c3b7f71
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sun Dec 05 15:39:07 2021
WorkManager: Migrate entities Kotlin
bug: 209145335
Test: refactoring
Change-Id: I3e112e2093d9b90712176e72087a3b4cebc374f9
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/Dependency.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/IdGenerator.java
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkName.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfo.kt
M work/work-runtime/src/main/java/androidx/work/WorkRequest.java
M work/work-runtime/src/main/java/androidx/work/impl/model/Preference.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkProgress.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkTest.java
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTag.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/utils/IdGeneratorTest.java
se...@google.com <se...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit 23603ab83714ba75809e0bbeca2726f3ed006ad0
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sun Dec 05 11:36:25 2021
WorkManager: Rename entities files from *.java to *.kt
bug: 209145335
Test: NA
Change-Id: Id7e559271895c34f21f3fb47dc1e38ce01bc30e3
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/Dependency.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkName.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfo.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/Preference.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkProgress.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTag.kt
https://android-review.googlesource.com/1910060
Branch: androidx-main
commit 23603ab83714ba75809e0bbeca2726f3ed006ad0
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sun Dec 05 11:36:25 2021
WorkManager: Rename entities files from *.java to *.kt
bug: 209145335
Test: NA
Change-Id: Id7e559271895c34f21f3fb47dc1e38ce01bc30e3
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/Dependency.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkName.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfo.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/Preference.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkProgress.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTag.kt
to...@gmail.com <to...@gmail.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit 63984d1ca5096d9c67f3793f0d0dcb563e66c60a
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 18:30:04 2021
WorkManager: Migrate *Dao interfaces to Kotlin
bug: 209145335
Test: refactoring
Change-Id: Ibb1a25920e6f520d037b2605439b75ddbe57fe3f
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkNameDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/DependencyDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/PreferenceDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfoDao.kt
M work/work-inspection/src/main/java/androidx/work/inspection/WorkManagerInspector.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/RawWorkInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkProgressDao.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteCoroutineWorkerTest.kt
https://android-review.googlesource.com/1910057
Branch: androidx-main
commit 63984d1ca5096d9c67f3793f0d0dcb563e66c60a
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 18:30:04 2021
WorkManager: Migrate *Dao interfaces to Kotlin
bug: 209145335
Test: refactoring
Change-Id: Ibb1a25920e6f520d037b2605439b75ddbe57fe3f
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkNameDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/DependencyDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/PreferenceDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfoDao.kt
M work/work-inspection/src/main/java/androidx/work/inspection/WorkManagerInspector.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/RawWorkInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkProgressDao.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteCoroutineWorkerTest.kt
se...@google.com <se...@google.com>
se...@google.com <se...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-main
commit 744c74c4609d854c3286264bda8a9645815073f7
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:07:28 2021
Rename *Dao.java to *Dao.kt
bug: 209145335
Test: NA
Change-Id: I9a712fa0c0ffbe2a09b5faed9f39737f47106d1d
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkNameDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/DependencyDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/PreferenceDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/RawWorkInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkProgressDao.kt
https://android-review.googlesource.com/1910056
Branch: androidx-main
commit 744c74c4609d854c3286264bda8a9645815073f7
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:07:28 2021
Rename *Dao.java to *Dao.kt
bug: 209145335
Test: NA
Change-Id: I9a712fa0c0ffbe2a09b5faed9f39737f47106d1d
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkNameDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/DependencyDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/PreferenceDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/RawWorkInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkProgressDao.kt
se...@google.com <se...@google.com> #10
Project: platform/frameworks/support
Branch: androidx-main
commit eb75eadc68ba555ca18e1ccdf6c576dcbcdc1cfa
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 18:27:24 2021
Scope Trackers to WorkManagerImpl
It removes singleton, so we don't need
getInstance() / setInstance for testing purposes.
bug: 209145335
Test: refactoring
Change-Id: Ic9410f9679ff20d9c89bf4e01204f6c9d4de29cb
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkConnectedController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/Trackers.java
M work/work-testing/src/main/java/androidx/work/testing/TestWorkManagerImpl.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkMeteredController.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/ConstraintsCommandHandler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkNotRoamingController.java
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryChargingController.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/StorageNotLowController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplLargeExecutorTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryNotLowController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkUnmeteredController.java
https://android-review.googlesource.com/1911870
Branch: androidx-main
commit eb75eadc68ba555ca18e1ccdf6c576dcbcdc1cfa
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 18:27:24 2021
Scope Trackers to WorkManagerImpl
It removes singleton, so we don't need
getInstance() / setInstance for testing purposes.
bug: 209145335
Test: refactoring
Change-Id: Ic9410f9679ff20d9c89bf4e01204f6c9d4de29cb
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkConnectedController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/Trackers.java
M work/work-testing/src/main/java/androidx/work/testing/TestWorkManagerImpl.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkMeteredController.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/ConstraintsCommandHandler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkNotRoamingController.java
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryChargingController.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/StorageNotLowController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplLargeExecutorTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryNotLowController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkUnmeteredController.java
ap...@google.com <ap...@google.com> #11
Project: platform/frameworks/support
Branch: androidx-main
commit 4799ddb8ec61f4b67c0f6915417d74ed5fb86d6e
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed Dec 08 16:32:58 2021
Migrate constrain controllers to kotlin
Had to rewrite WorkConstraintsTrackerTest, because
it didn't work well with kotlin: mocking final methods,
passing nulls where non-null types are required etc.
bug: 209145335
Test: refactoring
Change-Id: I4099251a521294b51e332620124167b0ef5f1e31
A work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ContraintControllers.kt
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkConnectedController.java
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkMeteredController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/controllers/ConstraintControllerTest.java
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkNotRoamingController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/ConstraintTracker.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryChargingController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.kt
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/StorageNotLowController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryNotLowController.java
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkUnmeteredController.java
https://android-review.googlesource.com/1914848
Branch: androidx-main
commit 4799ddb8ec61f4b67c0f6915417d74ed5fb86d6e
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed Dec 08 16:32:58 2021
Migrate constrain controllers to kotlin
Had to rewrite WorkConstraintsTrackerTest, because
it didn't work well with kotlin: mocking final methods,
passing nulls where non-null types are required etc.
bug: 209145335
Test: refactoring
Change-Id: I4099251a521294b51e332620124167b0ef5f1e31
A work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ContraintControllers.kt
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkConnectedController.java
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkMeteredController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/controllers/ConstraintControllerTest.java
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkNotRoamingController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/ConstraintTracker.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryChargingController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.kt
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/StorageNotLowController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryNotLowController.java
D work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkUnmeteredController.java
to...@gmail.com <to...@gmail.com> #12
Project: platform/frameworks/support
Branch: androidx-main
commit 73b240acd36c20d0d4fc7ed884608c422d5a186a
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Dec 07 12:18:53 2021
Rename ConstraintController.java to ConstraintController.kt
bug: 209145335
Test: NA
Change-Id: Iaa777fb5788040a7005b1eaa898192c76ba56038
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.kt
https://android-review.googlesource.com/1914847
Branch: androidx-main
commit 73b240acd36c20d0d4fc7ed884608c422d5a186a
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Dec 07 12:18:53 2021
Rename ConstraintController.java to ConstraintController.kt
bug: 209145335
Test: NA
Change-Id: Iaa777fb5788040a7005b1eaa898192c76ba56038
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.kt
se...@google.com <se...@google.com> #13
Project: platform/frameworks/support
Branch: androidx-main
commit 856d077b335d38bec5edf93d1c54aa8fa6d9456d
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Dec 07 02:26:53 2021
Migrate WorkDatabase and related classes to Kotlin
bug: 209145335
Test: refactoring
Change-Id: Ibf78b03ee78e01f2c5921a6a3844cb62d05b41f1
M work/work-runtime/build.gradle
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerInitializationTest.kt
A work/work-runtime/src/main/java/androidx/work/impl/package-info.java
M work/work-runtime/src/main/java/androidx/work/impl/utils/IdGenerator.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTypeConverters.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkDatabasePathHelperTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabasePathHelper.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/PreferenceUtils.java
M work/work-runtime/src/androidTest/java/androidx/work/WorkDatabaseMigrationTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabaseMigrations.kt
https://android-review.googlesource.com/1911876
Branch: androidx-main
commit 856d077b335d38bec5edf93d1c54aa8fa6d9456d
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Dec 07 02:26:53 2021
Migrate WorkDatabase and related classes to Kotlin
bug: 209145335
Test: refactoring
Change-Id: Ibf78b03ee78e01f2c5921a6a3844cb62d05b41f1
M work/work-runtime/build.gradle
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerInitializationTest.kt
A work/work-runtime/src/main/java/androidx/work/impl/package-info.java
M work/work-runtime/src/main/java/androidx/work/impl/utils/IdGenerator.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTypeConverters.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkDatabasePathHelperTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabasePathHelper.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/PreferenceUtils.java
M work/work-runtime/src/androidTest/java/androidx/work/WorkDatabaseMigrationTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabaseMigrations.kt
se...@google.com <se...@google.com> #14
Project: platform/frameworks/support
Branch: androidx-main
commit 0abc512e24adb1b637f9b9d2215b588b6bbd8bd3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 22:37:34 2021
Rename WorkDatabase and related classes from *.java to *.kt
bug: 209145335
Test: NA
Change-Id: I903fb03852bfe1815ec06f2ad2062c2827a354f1
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabaseMigrations.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTypeConverters.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabasePathHelper.kt
https://android-review.googlesource.com/1911875
Branch: androidx-main
commit 0abc512e24adb1b637f9b9d2215b588b6bbd8bd3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 22:37:34 2021
Rename WorkDatabase and related classes from *.java to *.kt
bug: 209145335
Test: NA
Change-Id: I903fb03852bfe1815ec06f2ad2062c2827a354f1
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabaseMigrations.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTypeConverters.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabasePathHelper.kt
to...@gmail.com <to...@gmail.com> #15
Project: platform/frameworks/support
Branch: androidx-main
commit 47cb7829960ffc9e81d725bf543a01bd9cb4d4f3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Dec 09 01:25:41 2021
Remove unused TaskExecutor.postToMainThread method
bug: 209145335
Test: refactoring. test passes
Change-Id: I8fd0c81b160fabd11800fdfcb0151d947ec02329
M work/work-testing/src/main/java/androidx/work/testing/TestWorkManagerImpl.java
M work/work-rxjava2/src/test/java/androidx/work/RxWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/utils/taskexecutor/InstantWorkTaskExecutor.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxWorkerTest.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/ParcelableWorkContinuationImplTest.kt
M work/work-runtime-ktx/src/androidTest/java/androidx/work/CoroutineWorkerTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/taskexecutor/WorkManagerTaskExecutor.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-gcm/src/androidTest/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcherTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/WorkerWrapperForegroundTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/taskexecutor/TaskExecutor.java
M work/work-testing/src/main/java/androidx/work/testing/InstantWorkTaskExecutor.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTests.kt
M work/work-benchmark/src/androidTest/java/androidx/work/benchmark/InitializeBenchmark.kt
https://android-review.googlesource.com/1914854
Branch: androidx-main
commit 47cb7829960ffc9e81d725bf543a01bd9cb4d4f3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Dec 09 01:25:41 2021
Remove unused TaskExecutor.postToMainThread method
bug: 209145335
Test: refactoring. test passes
Change-Id: I8fd0c81b160fabd11800fdfcb0151d947ec02329
M work/work-testing/src/main/java/androidx/work/testing/TestWorkManagerImpl.java
M work/work-rxjava2/src/test/java/androidx/work/RxWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/utils/taskexecutor/InstantWorkTaskExecutor.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxWorkerTest.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/ParcelableWorkContinuationImplTest.kt
M work/work-runtime-ktx/src/androidTest/java/androidx/work/CoroutineWorkerTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/taskexecutor/WorkManagerTaskExecutor.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-gcm/src/androidTest/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcherTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/WorkerWrapperForegroundTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/taskexecutor/TaskExecutor.java
M work/work-testing/src/main/java/androidx/work/testing/InstantWorkTaskExecutor.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTests.kt
M work/work-benchmark/src/androidTest/java/androidx/work/benchmark/InitializeBenchmark.kt
se...@google.com <se...@google.com> #16
Project: platform/frameworks/support
Branch: androidx-main
commit 6cc495a6e4c4cf55bfdde2bca636b3f70122a00b
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed Dec 08 21:02:10 2021
Migrate Trackers to Kotlin
bug: 209145335
Test: refactoring. test passes
Change-Id: I991fbdf52ebb26fdaeb9f4077da1456fa9442a6d
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ContraintControllers.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/ConstraintTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/NetworkStateTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BroadcastReceiverConstraintTracker.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/controllers/ConstraintControllerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/NetworkStateTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/Trackers.kt
https://android-review.googlesource.com/1914853
Branch: androidx-main
commit 6cc495a6e4c4cf55bfdde2bca636b3f70122a00b
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed Dec 08 21:02:10 2021
Migrate Trackers to Kotlin
bug: 209145335
Test: refactoring. test passes
Change-Id: I991fbdf52ebb26fdaeb9f4077da1456fa9442a6d
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ContraintControllers.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/ConstraintTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/NetworkStateTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BroadcastReceiverConstraintTracker.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/controllers/ConstraintControllerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/NetworkStateTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/Trackers.kt
Description
Component used: Appcompat 1.4.0 / Constraint layout 2.1.1 Version used: Devices/Android versions reproduced on: All
Since this is a long post I'll start by the end: Doing a bisect, the issue was introduced in 1.4.0 alpha 3 and is not present in 1.4.0 alpha 2.
I'm trying to build a repro but don't really understand what is going on, randomly on first start I have crashes from Textview whose data is set via setText(buffer.data, 0, buffer.sizeCopied). If I catch the error and just log it, then navigating or returning to the same state won't crash again. But killing the app and restart it can trigger it. So only happens on first run.
The buffer is stable and not edited anywhere it was working since ages and works nicely when reverting to app compat 1.3.1.
Strangely the crash have no reference to appcompat stuff, but it's the update to 1.4.0 that cause this.
Since I have no idea of a possible cause and this happens randomly in a very deep part of the app, I'd like some pointers about changes in appcompat 1.4.0 to narrow the possible cause and be able to create a repro. Sounds like there where changes to delay loading of things or maybe side effect of the emoji stuff that double init the textviews after the emoji library is loaded or not found? Or maybe some kind of data cache now and the crash occurs when the same final string is displayed multiple times?
Anyway any pointer to be able to help me provide more info and / or build a repro would be nice.
Crash log: