App compat 1.4.0 randomly crash with TextView and char buffers [206859724]

Fixed

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

Nov 18, 2021 05:54PM

Component used: Appcompat 1.4.0 / Constraint layout 2.1.1 Version used: Devices/Android versions reproduced on: All

Since this is a long post I'll start by the end: Doing a bisect, the issue was introduced in 1.4.0 alpha 3 and is not present in 1.4.0 alpha 2.

I'm trying to build a repro but don't really understand what is going on, randomly on first start I have crashes from Textview whose data is set via setText(buffer.data, 0, buffer.sizeCopied). If I catch the error and just log it, then navigating or returning to the same state won't crash again. But killing the app and restart it can trigger it. So only happens on first run.

The buffer is stable and not edited anywhere it was working since ages and works nicely when reverting to app compat 1.3.1.

Strangely the crash have no reference to appcompat stuff, but it's the update to 1.4.0 that cause this.

Since I have no idea of a possible cause and this happens randomly in a very deep part of the app, I'd like some pointers about changes in appcompat 1.4.0 to narrow the possible cause and be able to create a repro. Sounds like there where changes to delay loading of things or maybe side effect of the emoji stuff that double init the textviews after the emoji library is loaded or not found? Or maybe some kind of data cache now and the crash occurs when the same final string is displayed multiple times?

Anyway any pointer to be able to help me provide more info and / or build a repro would be nice.

Crash log:

java.lang.NullPointerException: Attempt to get length of null array
        at android.graphics.BaseRecordingCanvas.drawText(BaseRecordingCanvas.java:448)
        at android.widget.TextView$CharWrapper.drawText(TextView.java:13594)
        at android.graphics.BaseRecordingCanvas.drawText(BaseRecordingCanvas.java:467)
        at android.text.Layout.drawText(Layout.java:569)
        at android.text.Layout.draw(Layout.java:325)
        at android.text.BoringLayout.draw(BoringLayout.java:460)
        at android.widget.TextView.onDraw(TextView.java:8120)
        at android.view.View.draw(View.java:22644)
        at android.view.View.updateDisplayListIfDirty(View.java:21519)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at androidx.constraintlayout.widget.ConstraintLayout.dispatchDraw(ConstraintLayout.java:1994)
        at android.view.View.draw(View.java:22647)
        at xxx.xxxx.android.utils.view.ForegroundConstraintLayout.draw(ForegroundConstraintLayout.kt:94)
        at android.view.View.updateDisplayListIfDirty(View.java:21519)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
        at android.view.View.updateDisplayListIfDirty(View.java:21475)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
        at android.view.View.updateDisplayListIfDirty(View.java:21475)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
        at android.view.View.updateDisplayListIfDirty(View.java:21475)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
        at android.view.View.updateDisplayListIfDirty(View.java:21475)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
        at android.view.View.updateDisplayListIfDirty(View.java:21475)
        at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
        at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
        at android.view.View.updateDisplayListIfDirty(View.java:21475)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.draw(View.java:22647)
        at androidx.viewpager.widget.ViewPager.draw(ViewPager.java:2426)
        at android.view.View.updateDisplayListIfDirty(View.java:21519)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at androidx.coordinatorlayout.widget.CoordinatorLayout.drawChild(CoordinatorLayout.java:1277)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at androidx.fragment.app.FragmentContainerView.drawChild(FragmentContainerView.kt:235)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at androidx.fragment.app.FragmentContainerView.dispatchDraw(FragmentContainerView.kt:225)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at androidx.coordinatorlayout.widget.CoordinatorLayout.drawChild(CoordinatorLayout.java:1277)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
2021-11-18 18:24:48.958 5016-5066/xxx.xxxx.debug E/AAAA:     at androidx.drawerlayout.widget.DrawerLayout.drawChild(DrawerLayout.java:1478)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.updateDisplayListIfDirty(View.java:21510)
        at android.view.View.draw(View.java:22375)
        at android.view.ViewGroup.drawChild(ViewGroup.java:4528)
        at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4289)
        at android.view.View.draw(View.java:22647)
        at com.android.internal.policy.DecorView.draw(DecorView.java:820)
        at android.view.View.updateDisplayListIfDirty(View.java:21519)
        at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:534)
        at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:540)
        at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:616)
        at android.view.ViewRootImpl.draw(ViewRootImpl.java:4418)
        at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:4146)
        at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3306)
        at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2126)
        at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8649)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1037)
        at android.view.Choreographer.doCallbacks(Choreographer.java:845)
        at android.view.Choreographer.doFrame(Choreographer.java:780)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7838)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Comments

al...@google.com <al...@google.com> #2Nov 18, 2021 06:20PM

Reassigned to si...@google.com.

https://android-review.googlesource.com/c/platform/frameworks/support/+/1092870

to...@gmail.com <to...@gmail.com> #3Jan 17, 2022 02:24PM

Thank you for the quick fix.
Is there an ETA for the next release?

si...@google.com <si...@google.com> #4Jan 18, 2022 06:04PM

Reassigned to se...@google.com.

2.2.0-rc01 should be out this week.

se...@google.com <se...@google.com> #5Jan 18, 2022 06:50PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a1957df3709a06f4e6482fb0e4d39ded4f230a70
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Jul 29 09:48:05 2019

Workaround NPE in PersistableBundle.getExtras().

Test: Existing unit tests pass. Ran integration test app.
Fixes:

b/138441699

Change-Id: I0b48e0009a7d83c343a3d26112b94c057470c281

M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java

https://android-review.googlesource.com/1092870

https://goto.google.com/android-sha1/a1957df3709a06f4e6482fb0e4d39ded4f230a70

to...@gmail.com <to...@gmail.com> #6Jan 18, 2022 06:59PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6206758647365632/#/cherrypickHistory/all)
Created: 2019-07-29 19:41:55.445144+00:00
Changes: aosp/1092870

se...@google.com <se...@google.com> #7Jan 18, 2022 07:01PM

Thanks! That's helpful to know it's reproing on both 11 and 12 - no need to test on others. We'll have to explore a bit.

to...@gmail.com <to...@gmail.com> #8Feb 23, 2022 06:24PM

Any feedback on this? Appcompat 1.6 is around the corner with Android T. Migrating away from CharArrayBuffer is a ton of work to try to keep the huge performance gain it provide for my use case.

se...@google.com <se...@google.com> Mar 3, 2022 06:22PM

Accepted by se...@google.com.

se...@google.com <se...@google.com> #9Mar 3, 2022 10:47PM

Going out in next release.

se...@google.com <se...@google.com> #10Mar 3, 2022 10:58PM

There's no code workaround that enables emoji and allows that setText overload to be used in the current version.

Other options:

emojiCompatEnabled=false in your theme will skip emoji processing (please enable it again once fix goes out)
Don't use setText(char[]) (sounds like this is not really an option for you)
Hold back appcompat upgrade until the fix goes out.

The fix will go out in emoji2:emoji2-views-helpers 1.2-alpha02 so you may be able to bump that dependency early to test it.

ap...@google.com <ap...@google.com> #11Mar 4, 2022 01:42AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 297989f164a9913a4c4c90e3fdd571203dca0830
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Mar 03 13:21:07 2022

Safely process no emoji from TextView$CharWrapper

This avoids calling TextView.setText when the text has not been updated
by emoji2. This has the impact of avoiding an extra text layout on emoji
font loading.

Fixes:

b/206859724

Test: ./gradlew :e2:e2-v-h:cAT
Relnote: "Fix crash when emoji2 loads font and TextView.setText(char[])
was used."

Change-Id: Id511e36ce9a9077309855082de88f00c26024c9d

M emoji2/emoji2-views-helper/src/main/java/androidx/emoji2/viewsintegration/EmojiInputFilter.java
M emoji2/emoji2-views-helper/src/androidTest/java/androidx/emoji2/viewsintegration/EmojiInputFilterTest.java

https://android-review.googlesource.com/2007316

to...@gmail.com <to...@gmail.com> #12Mar 4, 2022 07:37AM

Thanks for the fix I can wait as nothing mandatory in appcompat 1.4 for my use case.

Is there some compatibility matrix between appcompat and emoji ? (Mostly will emoji 1.2 work with app compat 1.4 in case there's blocking stuff to support T and appcompat 1.6?)

se...@google.com <se...@google.com> #13Mar 7, 2022 05:50PM

Great to hear!

I don't have a compat spreadsheet, but 1.2 is going to be 1.1 with bugfixes like this so no concerns here.

se...@google.com <se...@google.com> #14Mar 7, 2022 05:53PM

Future readers:

Currently not planning on doing a appcompat 1.4.2 bugfix release containing this patch, but we can roll one if it's becomes necessary for some reason.

Please re-open ticket if this is blocking you.

to...@gmail.com <to...@gmail.com> #15Jun 3, 2022 04:47PM

Sorry to post again here but the root issue now also impact Pixel phones when changing the text after having used a char array. (So will crash with Emoji too when it actually do change the text as the fix only fix when the content does not change)

Since there was no reaction there for a long time https://issuetracker.google.com/issues/227218386 and I have now found the root and details, maybe you can ensure this reach the proper peoples for fix.

se...@google.com <se...@google.com> #16Jun 6, 2022 09:12PM

Thanks for the ping :looking: