Debug build causes duplicate definitions for desugared library classes [159871229]

Fixed

Bug

Status Update

No update yet.

Description

ze...@google.com

created issue #1

Jun 25, 2020 09:04AM

The current debug build makes two L8 compilations: one for the desugared library and one for custom conversions. Any such L8 compilation may result in overlapping class definitions. Duplicate classes can cause issues on some devices as it is undefined behavior on the VM.

There are two immediate solutions to this:

1. Do only one L8 compilation passing both the desugared library and the custom conversions as inputs.

2. Do a D8 merge of the L8 compilations such that no duplicates are assured.

Comments

ga...@google.com <ga...@google.com> #2Jun 25, 2020 04:26PM

We will move to always using a single L8 invocation to process core library desugaring libraries. This task is cacheable and it should not impact the build speed negatively.

ga...@google.com <ga...@google.com> #3Jun 29, 2020 08:46AM

Marked as fixed.

The fix will be shipped in 4.1.0-beta04, and in 4.2.0-alpha05.

change ag/Ia1b241b2fee25ae43cda816f8b041a2e24acdadc

zs...@salesforce.com <zs...@salesforce.com> #4Jul 22, 2020 12:41AM

I've tried this with both 4.1.0-beta04 and 4.2.0-alpha05 and it is still occurring :/. Slightly different error now though

java.lang.NoSuchMethodError: No direct method <init>(Ljava/util/Map;)V in class Lj$/util/m; or its super classes (declaration of 'j$.util.m' appears in /data/app/com.Slack.test-N8ok9kngoWUpMTt_roYrFA==/base.apk!classes2.dex)
	at j$.util.DesugarCollections.synchronizedMap(Unknown Source:2)
	at slack.telemetry.helper.FrameMetricsPlugin.<init>(FrameMetricsPlugin.kt:3)
	at slack.telemetry.helper.FrameMetricsPlugin_Factory.get(FrameMetricsPlugin_Factory.java:2)
	at dagger.internal.DoubleCheck.get(DoubleCheck.java:5)
	at slack.telemetry.helper.TracePluginsFactoryImpl_Factory.get(TracePluginsFactoryImpl_Factory.java:1)
	at dagger.internal.DoubleCheck.get(DoubleCheck.java:5)
	at slack.telemetry.TraceProviderImpl_Factory.get(TraceProviderImpl_Factory.java:1)
	at dagger.internal.DoubleCheck.get(DoubleCheck.java:5)
	at slack.telemetry.TracerImpl_Factory.get(TracerImpl_Factory.java:1)
	at dagger.internal.DoubleCheck.get(DoubleCheck.java:5)

ga...@google.com <ga...@google.com> #5Jul 22, 2020 11:47AM

Zac, are there still 2 dex files in the APK containing `j$` classes? WIth 4.1.0-beta04 there should be only one.

zs...@salesforce.com <zs...@salesforce.com> #6Jul 23, 2020 02:49AM

Hmm, no I just see one. I think I've figured it out - in this case, this is occurring in a minified androidTest APK. j$/util/m does exist in the tested app apk, but both it (the class, in this case SynchronizedMap) and the DesugarCollections class are not in the test APK. This is failing from the test APK judging by the stacktrace (com.Slack.test is the test APK package name), I'm not really sure why it's not using the class from the main app APK. I tried to force it with adding -keep class $j.** in our test proguard rules, but it doesn't seem to be incorporated into L8's subsequent minification of the androidTest app.

Should I file a separate issue?

ga...@google.com <ga...@google.com> #7Jul 23, 2020 08:40AM

Ah, this is

https://issuetracker.google.com/158018485 which talks about that use-case.

In

https://issuetracker.google.com/158545411 (which is fixed) we stopped shipping core library desugaring dependencies in both test and tested but only if shrinking is disabled.

Issue 159871229