BuildConfig not correctly honoring contract around quotations in String[] [160155450]

Fixed

Bug

Status Update

No update yet.

Description

st...@seatgeek.com

created issue #1

Jun 29, 2020 10:09PM

Studio Build:
Version of Gradle Plugin: 4.1.0-beta02
Version of Gradle: 6.5
Version of Java: 8
OS: OSX

Steps to Reproduce:
1. Add a buildConfigField that is of type String[] with empty array

buildConfigField "String[]", "ADDITIONAL_OAUTH_SCOPES", "new String[]{}"

2. ./gradlew :app:assemble
2. Notice compilation failure:

/Users/stephen/workspace/BuildConfigBug/app/build/generated/source/buildConfig/debug/com/seatgeek/android/buildconfig/BuildConfig.java:13: error: incompatible types: String cannot be converted to String[]
public static final String[] ADDITIONAL_OAUTH_SCOPES = "new String[]{}";
^

The contract for build config fields explicitly states:

"The field is generated as: <type> <name> = <value>; This means each of these must have valid Java content. If the type is a String, then the value should include quotes"

It appears as if the gradle plugin is now inserting quotes in violation of this. 4.0.0 compiles and works as expected.

Comments

xa...@google.com <xa...@google.com> #2Jun 29, 2020 10:32PM

Assigned to cm...@google.com.

I'd like to fix the formatting but I can't edit my issue.

uc...@google.com <uc...@google.com> Jun 29, 2020 10:52PM

Reassigned to an...@google.com.

xa...@google.com <xa...@google.com> Jun 29, 2020 11:51PM

Reassigned to cm...@google.com.

cm...@google.com <cm...@google.com> Jul 1, 2020 10:24AM

Accepted by cm...@google.com.

cm...@google.com <cm...@google.com> #3Jul 1, 2020 02:18PM

Our team is also running into this because we use kotlin reflection to set up mock data for previews.

Can you suggest any workaround that we can apply locally to make layout lib include kotlin reflect until it is officially fixed? We are obviously including it as a build dependency but the layout lib preview doesn't pick it up for some reason.

cm...@google.com <cm...@google.com> #4Jul 1, 2020 04:34PM

I do not see this issue in Electric Eel Beta 4, but I do see it in Flamingo Canary 6.

cm...@google.com <cm...@google.com> #5Jul 2, 2020 10:59AM

Marked as fixed.

I do not see this issue in Electric Eel Beta 4, but I do see it in Flamingo Canary 6.

Is it with the very same project? I'm trying to rule out whether this is related to specific library/compiler versions.

Thanks!

st...@seatgeek.com <st...@seatgeek.com> #6Jul 8, 2020 04:08PM

Yes, that was with the same project. I can double check with the latest versions of each IDE and get back to you though.

cm...@google.com <cm...@google.com> #7Jul 13, 2020 03:18PM

Correction: I was either mistaken before, or behavior has changed, but I am now getting the KotlinReflectionNotSupportedError issue for IDE compose previews in both EE Beta 5 and Flamingo Canary 8.

Kotlin 1.6.21 AGP 7.3

ga...@gmail.com <ga...@gmail.com> #8Jul 21, 2020 07:37PM

Hi, I'm also running into this issue in the preview with Kotlin 1.7.10 on Android Studio Dolphine (2021.3.1). Have you found a workaround in the meantime?

cm...@google.com <cm...@google.com> #9Jul 23, 2020 02:44PM

We're having the same issue on Android Studio Dolphin (2021.3.1) with Kotlin 1.6.10. The issue occurs when we use class references with kotlin reflect. The behavior can only be seen in Compose Preview's runtime. Everything works perfectly fine in android runtime, though.

ga...@gmail.com <ga...@gmail.com> #10Jul 23, 2020 04:58PM

Diego, this looks to be the same problem as issue 183889504, which was marked as Fixed. Are you aware of a fix? If that issue was incorrectly marked as fixed, feel free to bounce this one back to me. Thanks!

ga...@gmail.com <ga...@gmail.com> #11Jul 28, 2020 07:50PM

This looks to be the same as https://b.corp.google.com/issues/183889504 but it is not marked as fixed. We need to look into the dependencies because it looks like reflect might not be found by the deps in the model.

cm...@google.com <cm...@google.com> #12Jul 30, 2020 05:15PM

I'm pretty sure the failure is in locating kotlin.reflect.jvm.internal.ReflectionFactoryImpl in https://github.com/JetBrains/kotlin/blob/master/libraries/stdlib/jvm/runtime/kotlin/jvm/internal/Reflection.java.

That Class.forName should redirect to the "renamed" version that we move in the classpath to the layoutlib.internal so it loads the correct JVM version in https://github.com/JetBrains/kotlin/blob/master/core/reflection.jvm/src/kotlin/reflect/jvm/internal/ReflectionFactoryImpl.java.