crash by android.support.v7.widget.StaggeredGridLayoutManager$LazySpanLookup.invalidateAfter(StaggeredGridLayoutManager.java:2878) [160193663]

Fixed

Bug

NeedsInfo

Status Update

No update yet.

Description

gy...@gmail.com

created issue #1

Jun 30, 2020 07:12AM

android version:8.1.0
recyclerView- support.v7-28.0.0
Describe:
I try to update item count in RecyclerView (use StaggeredGridLayoutManager),which step is change the dataSet and invoke Adapter.notifyItemRangeInserted(int ,int) (notifyDataSetChanged will no crash but i can't use is because the staggere layout may be dislocated).This step can be invoked many times depends on http response(a http response will insert some items ,we invoke many times http request).Sometimes the application will crash but we have no idea why it is crash. The crash stack like this(full stack to see the file)

java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 46
        at java.util.Arrays.rangeCheck(Arrays.java:123)
        at java.util.Arrays.fill(Arrays.java:2831)
        at android.support.v7.widget.StaggeredGridLayoutManager$LazySpanLookup.invalidateAfter(StaggeredGridLayoutManager.java:2878)
        at android.support.v7.widget.StaggeredGridLayoutManager.handleUpdate(StaggeredGridLayoutManager.java:1550)
        at android.support.v7.widget.StaggeredGridLayoutManager.onItemsAdded(StaggeredGridLayoutManager.java:1509)
        at android.support.v7.widget.RecyclerView$6.dispatchUpdate(RecyclerView.java:1010)
        at android.support.v7.widget.RecyclerView$6.onDispatchSecondPass(RecyclerView.java:1027)
        at android.support.v7.widget.AdapterHelper.consumeUpdatesInOnePass(AdapterHelper.java:563)
        at android.support.v7.widget.RecyclerView.processAdapterUpdatesAndSetAnimationFlags(RecyclerView.java:3585)
        at android.support.v7.widget.RecyclerView.dispatchLayoutStep1(RecyclerView.java:3829)
        at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:3639)
......
......

please tell me the solution to solve this problem and what is the LazySpanLookup,thanks very much.

deleted

Restricted

0 B

Comments

vi...@google.com <vi...@google.com> Jun 30, 2020 07:29AM

Assigned to vi...@google.com.

vi...@google.com <vi...@google.com> #2Jun 30, 2020 08:42AM

Hi, thanks for linking me to this issue! When it's expected the cursor handle feature to be included in the library?

gy...@gmail.com <gy...@gmail.com> #3Jul 1, 2020 08:53AM

Currently our focus is on correctness of the existing features and the API. I wouldn't expect this feature to be implemented in the next few months.

gy...@gmail.com <gy...@gmail.com> #4Jul 2, 2020 10:06AM

Project: platform/frameworks/support
Branch: androidx-main

commit 1c6a17a061e7b4a70047224e8f31d3eecb66b5ef
Author: Qingqing Deng <qqd@google.com>
Date: Tue Jun 01 15:45:51 2021

Cursor Handle.

Bug:173016579
Test: ./gradlew test
Test: ./gradlew compose:foundation:foundation:connectedAndroidTest
Test: Manullay tested.

RelNote: Add Cursor Handle.
Change-Id: I07a8217c8ecbcd1c84c1a8df20c6e8b07d409148

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/AndroidCursorHandle.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.kt
A compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/DesktopCursorHandle.desktop.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManagerTest.kt

https://android-review.googlesource.com/1725113

deleted

Restricted

0 B

vi...@google.com <vi...@google.com> #5Jul 8, 2020 01:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit d47f1fe5b05eb9cc19c1b44dabbb4b0f34145817
Author: Haoyu Zhang <haoyuchang@google.com>
Date: Tue Jul 13 03:10:55 2021

Refactor selection handle

- Removed unnecessary parameters from SelectionHandle composable to avoid unnecessary recompose.
- Avoid using Path to draw selection handle for better performance.
- Reused the painting logic of selection handle in cursor handle.

Bug: 173016579
Test: ./gradlew test
Test: ./gradlew compose:foundation:foundation:connectedAndroidTest
Change-Id: I0a9f197913e78fd67289182b4704d69979f5b35a

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionHandlePopupPositionTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionHandlesTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/TextSelectionColorsScreenshotTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/AndroidCursorHandle.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/AndroidSelectionHandles.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionContainer.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionHandles.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.kt
M compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/selection/DesktopSelectionHandles.desktop.kt

https://android-review.googlesource.com/1764405

vi...@google.com <vi...@google.com> #6Jul 17, 2020 07:20AM

Project: platform/frameworks/support
Branch: androidx-main

commit 3d5628e3d8ba223533646945e5e55b3c43f514e7
Author: Haoyu Zhang <haoyuchang@google.com>
Date: Thu Jul 15 16:23:04 2021

Hide cursor when input is from physical keyboard

Also simplified the logic to hide cursor when text get changed from
software keyboard.

Bug: 173016579
Test: ./gradlew test
Change-Id: Ibe242728c8aec7cccdfc29ac137dceb0f587bc14

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldKeyInput.kt

https://android-review.googlesource.com/1768979

sh...@google.com <sh...@google.com> #7Jul 21, 2020 09:01PM

Marked as fixed.

Fixed via https://android.googlesource.com/platform/frameworks/support/+/49b601979ebccb8fcc6b8d670b79ae1c5f818dbf