Set up integration test to make sure studio can open a compose file without issues [160271731]

Assigned

Process

Status Update

No update yet.

Description

au...@google.com

created issue #1

Jun 30, 2020 11:04PM

We currently do not test tip of tree androidx-master-dev compose with latest of studio, which means we get breakages (e.g. b/160271417) where studio is not even able to open compose classes correctly. To prevent this, we should set up integration testing.

Comments

di...@google.com <di...@google.com> Jul 6, 2020 01:45PM

Assigned to di...@google.com.

di...@google.com <di...@google.com> #2Jul 8, 2020 05:20PM

Are there any updates here?

au...@google.com <au...@google.com> #3Jul 8, 2020 05:36PM

I looked at it and I'm planning to remove the deduplicating lookup the callstack refers to. It should be no longer needed. How was the 80ms in comment#1 calculated? If it's straightforward I'll calculate it again before my change goes in.

di...@google.com <di...@google.com> #4Jul 9, 2020 08:39AM

I couldn't move the logging off thread but I was able to address an area of concern in the callstack:
com.google.protobuf.Descriptors$FileDescriptor.internalBuildGeneratedFileFrom(Descriptors.java)
com.android.build.gradle.internal.cxx.logging.CxxLogging.<clinit>(CxxLogging.java:82)
com.android.build.gradle.internal.cxx.logging.LoggingMessage.getDescriptor(LoggingMessage.java:110)
com.android.build.gradle.internal.cxx.logging.LoggingMessage.hashCode(LoggingMessage.java:489)
java.util.HashMap.hash(HashMap.java:340)
java.util.HashMap.containsKey(HashMap.java:592)
java.util.HashSet.contains(HashSet.java:204)

This logic was deduplicating messages (including chatty 'info' messages). This deduplication shouldn't be needed anymore so I removed it.

I don't know how the 80ms from

comment#1

was gathered so I can't say how much it has improved logging, but it should help quite a bit. Let me know if you can still measure a performance issue. The next step would be to reduce the 'info' that's logged.

au...@google.com <au...@google.com> #5Jul 9, 2020 04:26PM

The change mentioned in

comment#4

(internal Id I4e51a10d9ee2a81ca56c8e81c7890dfb0bf239d7) should be available in Canary 8 of Flamingo.

Issue 160271731