ActivityResultLauncher fails in Fragment.onCreate() [161464278]

Fixed

Bug

Status Update

No update yet.

Description

su...@twofortyfouram.com

created issue #1

Jul 16, 2020 08:08PM

Component used: Fragment
Version used: 1.3.0-alpha06

STEPS TO REPRODUCE
1. Try calling ActivityResultLauncher.launch() during Fragment.onCreate()

RESULTS
Actual: Exception is thrown because fragment is not in created state. Exception is included below.
Expected: No exception is thrown.

NOTES
I called super.onCreate() first. The issue seems to be that the ActivityResultLauncher is looking at the lifecycle to be set to CREATED.

java.lang.IllegalStateException: Operation cannot be started before fragment is in created state
at androidx.fragment.app.Fragment$8.launch(Fragment.java:3351)
at androidx.activity.result.ActivityResultLauncher.launch(ActivityResultLauncher.java:42)
at com.twofortyfouram.locale.sdk.host.edit.AbstractSupportPluginEditFragment.onCreate(AbstractSupportPluginEditFragment.java:173)
at androidx.fragment.app.Fragment.performCreate(Fragment.java:2867)
at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:444)
at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1287)
at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1444)
at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1522)
at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1575)
at androidx.fragment.app.BackStackRecord.executeOps(BackStackRecord.java:455)
at androidx.fragment.app.FragmentManager.executeOps(FragmentManager.java:2299)
at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2084)
at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2022)
at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1924)
at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:489)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6669)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)

Comments

il...@google.com <il...@google.com> #2Jul 17, 2020 12:23AM

Assigned to jb...@google.com.

I created a thread on the android-developers forum related to this bug:

http://groups.google.com/group/android-
developers/browse_thread/thread/6caa57135927e242/86d4d895e88a5ebb?
lnk=gst&q=custom+account#86d4d895e88a5ebb

ap...@google.com <ap...@google.com> #3Jul 28, 2020 05:32PM

My personal theory is that Google broke this part of the API intentionally to keep
the lock-in on sync functionality they've enjoyed since Android 1.0.....

jb...@google.com <jb...@google.com> #4Jul 28, 2020 06:04PM

Marked as fixed.

Also see the latter part of the Contacts FAQ thread:

http://groups.google.com/group/android-developers/browse_thread/thread/58c69a2ea5056a01

va...@gmail.com <va...@gmail.com> #5Oct 21, 2023 07:45PM

[Comment deleted]

jb...@google.com <jb...@google.com> #6Oct 23, 2023 03:06PM

Here's an intact link to the "Adding contacts to a custom account" thread that Carlo
refers to above:

http://groups.google.com/group/android-developers/browse_thread/thread/6caa57135927e242

pa...@wagwalking.com <pa...@wagwalking.com> #7Nov 20, 2023 05:18PM

ExternalSource.java bug

protected void inflate(Context context, XmlPullParser parser)
{
final AttributeSet attrs = Xml.asAttributeSet(parser); << It can't read any
attributes from the ContactsDataKind tag. It should located blow the second while
loop.

try
{
int type;
while((type = parser.next()) != XmlPullParser.START_TAG &&
type != XmlPullParser.END_DOCUMENT)
{
// Drain comments and whitespace
}

if(type != XmlPullParser.START_TAG)
{
throw new IllegalStateException("No start tag found");
}

if(!InflateTags.CONTACTS_SOURCE.equals(parser.getName()))
{
throw new IllegalStateException("Top level element must be " +
InflateTags.CONTACTS_SOURCE);
}

il...@google.com <il...@google.com> #8Nov 27, 2023 06:37PM

Any feedback from Google guys?
It doesn't seem to be fixed in Android 2.2 and actually is going to be a blocking issue for third party sync providers. We cannot claim to sync contacts if the user cannot edit them.

Looking at the code, the fix is very easy (at least to let sync providers to use the same contact structure used by Google accounts).

Please let us know if and when you can work on this.