IssueTracker

Did you apply kotlin-kapt?

Matthew, I think this is the exact same thing you were seeing? An update in kapt may be totally breaking data binding for Kotlin users. This seems like a P0 to me but I'm not sure what I can do, since our code hasn't changed at all.

Hung, in case you're not aware, it seems like something has changed between canary 4 and canary 5 which causes kapt not to work for data binding. Maybe it was an AGP change?

Hung/Yigit, we should really dig into how our tests didn't catch this.

OP, just to make sure, you're writing Kotlin yeah? I'm assuming it's that. Or are you seeing this in Java as well?

Repro steps for anyone who wants to see this for themselves:

1. git clone https://github.com/chrisbanes/tivi
2. In buildSrc/src/main/java/app/tivi/buildsrc/dependencies.kt, upgrade AGP:
   • const val androidGradlePlugin = "com.android.tools.build:gradle:4.2.0-alpha05
3. In root gradle.properties, update heap settings and add fake properties just to get things to compile:
   • org.gradle.jvmargs=-Xmx2048m (bumped up from 1536m)
   • Add to the end of the file (values don't really matter):

     TIVI_TRAKT_CLIENT_ID=1234
     TIVI_TRAKT_CLIENT_SECRET=5678
     TIVI_TMDB_API_KEY=abcd
     

4. Build app. You may need to add --stacktrace to your gradle options (this won't be necessary after https://issuetracker.google.com/156837289 lands)
5. Notice all the failures. These are caused because the project's @BindingAdapter annotations are being lost.

Hung, kicking to you initially in case this is a Gradle change you're aware of. Kick back to me if you have no idea what is going on here, and I'll escalate locally.

i'm looking into reproducing it. we do have tests where adapters from sub modules are used so it is scary how this got missed. also didn't change anything in data binding :/.

i'mlooking into this in between meetings so a bit slow but initial findings:

➜  tivi git:(main) ✗ find ./common-databinding/build/intermediates/data_binding_artifact/ -name "*.json"|grep -i setter
./common-databinding/build/intermediates/data_binding_artifact/debug/app.tivi.common.databinding-setter_store.json
➜  tivi git:(main) ✗ find ./common-layouts/build/intermediates/data_binding_dependency_artifacts/ -name "*.json"|grep -i setter
./common-layouts/build/intermediates/data_binding_dependency_artifacts/debug/com.airbnb.epoxy.databinding-setter_store.json
./common-layouts/build/intermediates/data_binding_dependency_artifacts/debug/dev.chrisbanes.insetter.dbx-setter_store.json
./common-layouts/build/intermediates/data_binding_dependency_artifacts/debug/androidx.databinding.library.baseAdapters-setter_store.json

seems like setter store (the output of parsing binding adapters) is generated for common-databinding but it is not copied into the layouts project.

meanwhile, dependencies from gradle outputs are copied.

Hung, did anything change there?

also reproduces with tip of tree.

I just found that this change broke the publishing of data binding's setter store and br files: https://android.googlesource.com/platform/tools/base/+/9e60cd82495fb937089714aab61d7f74f4630cd4

I'm working on a fix.

also our mutli module test is passing so nothing is broken in the infra as well.

the difference is that, that test is in java :/. i'll try adding a kotlin module there to see if it helps reproduce.

Yup, the above change only impacts modules that use Kapt.

this reproduces the issue: https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/data-binding/+/12222450

Didn't have time to debug yet.

more info:

The merge artifacts task is not seeing the artifacts provided by the dependency.

task.runtimeDependencies = creationConfig.variantDependencies.getArtifactFileCollection(
                AndroidArtifacts.ConsumedConfigType.RUNTIME_CLASSPATH,
                AndroidArtifacts.ArtifactScope.ALL,
                AndroidArtifacts.ArtifactType.DATA_BINDING_ARTIFACT
            )
            task.compileTimeDependencies = creationConfig.variantDependencies.getArtifactFileCollection(
                AndroidArtifacts.ConsumedConfigType.COMPILE_CLASSPATH,
                AndroidArtifacts.ArtifactScope.ALL,
                AndroidArtifacts.ArtifactType.DATA_BINDING_ARTIFACT
            )

the getArtifactFileCollection does not return anything from module dependencies that are in the same project.

I see some changes in that area by jedo@ but i'm not sure if any of them would trigger this.

Ivan / Hung, Jedo said you might have an idea what is broken here.

To reproduce:

checkout the CL above in tools/data-binding
cd tools/base && ./gradlew :pL :makeOfflineRepo
cd ../data-binding
./init.sh # this just makes test projects use latest gradle
cd integration-tests/KotlinTestApp
./gradlew app:connectedCheck -Pandroid.injected.invoked.from.ide=true
# invoked from ide is important, otherwise they'll assume gradle connected check runner setup

You can put a debug point on DataBindingMergeDependencyArtifactsTask and observe that the artifacts from the module do not show up.

Yup I've found the root cause (comment #11).

I've sent out a fix for review: Change-Id: I3ed5520fc33184475a42c19d19412a87cb2d386d

We have fixed this issue: https://android.googlesource.com/platform/tools/base/+/cea0b5923006a9eff4b19a4530cf496dc47da092 (the commit message explains the root cause), with a regression test to prevent this issue from reappearing.

I'm trying to cherry-pick the fix to AGP 4.2.0-alpha06, otherwise it will probably be in 4.2.0-alpha07.

Thanks a lot for the report!

The following changes were cherrypicked through Coastguard
Release Track: 5146371478454272
Changes: ag/12219788