Status Update
Comments
uc...@google.com <uc...@google.com> #2
Hi Jomo, can you take a look at this one?
mt...@gmail.com <mt...@gmail.com> #3
Currently we are filtering the flags. Maybe we should just allow -C
as well?
mt...@gmail.com <mt...@gmail.com> #4
It would be great if -C
can be allowed.
CMake is evolving. Recently support for log levels was introduced. With filtering cannot pass --log-level=VERBOSE
into CMake.
Isn't blacklisting -G
, -S
, -B
and a few others a better approach?
Plugin can emit a warning/error if user try to override one of them. Message will help developers to correct script files and prevent half-baked builds from happening.
As for scope of this issue, I'm totally fine with -C
being allowed.
mt...@gmail.com <mt...@gmail.com> #5
I would love to move forward and you're able to help me with that.
Any chance for this to be solved in near future?
lf...@google.com <lf...@google.com>
sp...@google.com <sp...@google.com> #6
Like in school. The best way to get a silence is to ask a question. :D
Description
AI-201.7846.76.42.6720134, JRE 1.8.0_242-release-1644-b01x64 JetBrains s.r.o, OS Windows 10(amd64) v10.0 , screens 1707x960, 2194x1234
AS: 4.2 Canary 7; Kotlin plugin: 1.3.61-release-Studio4.1-1; Android Gradle Plugin: 4.0.1; Gradle: 6.5.1; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)
IMPORTANT: Please read
password.setOnKeyListener { v, keyCode, event ->
// If the event is a key-down event on the "enter" button
if ((event.action == KeyEvent.ACTION_DOWN) && (keyCode == KeyEvent.KEYCODE_ENTER)) {
but it's never called when press Enter on keyboard.
Event: password.setOnKeyListener { v, keyCode, event -> is never called for ENTER key. Numbers are invoked, but not ENTER