Memory leak in GuidanceStepSupportFragment [164841457]

Fixed

Bug

Status Update

No update yet.

Description

th...@gmail.com

created issue #1

Aug 17, 2020 04:46PM

Component used:androidx.leanback:leanback
Version used: 1.1.0-alpha04
Devices/Android versions reproduced on: Android 9

There is a memory leak in GuidanceStepSupportFragment. In the onDestroyView function, mGuidanceStylist.onDestroyView() is called. When looking at the implementation for that function, you can see that views are set to null. However, the field called mGuidanceContainer is not set to null here. That causes a memory leak.

Comments

th...@gmail.com <th...@gmail.com> #2Sep 20, 2020 12:56PM

Sample project attached.

da...@google.com <da...@google.com> #3Sep 23, 2020 11:39PM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

What steps are needed to reproduce this issue? Frequency of occurrence?

Which device did you use to reproduce this issue?

Can you confirm if this issue is reproducible on a Pixel/Nexus device?

Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:

https://developer.android.com/studio/debug/bug-report#bugreportdevice

Alternate method
Navigate to “Developer options”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Note: Please upload the bug report and screenshot to google drive and share the folder to android-bugreport@google.com, then share the link here.

ap...@google.com <ap...@google.com> #4Sep 24, 2020 03:03AM

I attached a project in comment #2. Build this project and deploy to any API 35 device.

Run the app once to allow the BroadcastReceiver to register. Then rerun it over and over again.

On any API 35 device (I used an emulator and a Pixel 8 Pro), the BroadcastReceiver will get BOOT_COMPLETED action every time you launch the app.

This seems to only happen when launching the app from Android Studio. When I force stop the app and launch it from the device itself, it doesn't happen. Something about the way AS launches the device is triggering the BOOT_COMPLETED event. But only on API 35

th...@gmail.com <th...@gmail.com> #5Sep 24, 2020 10:40AM

We have shared this with our product and engineering team and will update this issue with more information as it becomes available.

da...@google.com <da...@google.com> #6Sep 24, 2020 05:06PM

I'm just now experiencing that something is not right. Regarding 2 types of intent event.

android.intent.action.BOOT_COMPLETED
android.intent.action.LOCKED_BOOT_COMPLETED

I also experience this when I launch the app from Android Studio. But I also get additional log.

BOOT_COMPLETED_BROADCAST_COMPLETION_LATENCY_REPORTED action:android.intent.action.LOCKED_BOOT_COMPLETED dispatchLatency:1 completeLatency:604 dispatchRealLatency:0 completeRealLatency:604 receiversSize:1 userId:0 userType:android.os.usertype.full.SYSTEM
BOOT_COMPLETED_BROADCAST_COMPLETION_LATENCY_REPORTED action:android.intent.action.BOOT_COMPLETED dispatchLatency:604 completeLatency:837 dispatchRealLatency:604 completeRealLatency:837 receiversSize:2 userId:0 userType:android.os.usertype.full.SYSTEM

Device: S25 Ultra android 15
Android Studio: 2024.2.2 Patch 1

th...@gmail.com <th...@gmail.com> #7Nov 3, 2020 05:51PM

Thanks for the explanation!

I am using the leanback fragments (including BrowseSupportFragment) in a single Activity. I did that primarily because a single Activity is recommended by Google. Furthermore, the Leanback sample app also uses a single Activity (https://github.com/android/tv-samples/tree/master/ClassicsKotlin). Could you please reconsider fixing this?

da...@google.com <da...@google.com> #8Nov 19, 2020 11:03PM

Marked as fixed.

see

b/171909417

for future fixes