Android IntelliJ plugin: Gradle sync failed: Property found to be invalid, this should never happen! [165017523]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Aug 18, 2020 01:03PM

This is a bug when using IntelliJ 2020.2 to develop Android projects. During Gradle Sync, the error bellow happens:

Gradle sync failed: Property found to be invalid, this should never happen!

I chase it down to having some custom logic in buildSrc that contains a apply method:

// build.gradle.kts
BuildHelper.apply(rootProject)

A sample reproducer project is attached

Studio Build: Version of IntelliJ: 2020.2 Version of the Android IntelliJ Plugin: (bundled) 10.4.0.202.6948.5 Version of Gradle Plugin: 4.0.1 Version of Gradle: 6.5 Version of Java: 1.8 OS: MacOS

Steps to Reproduce:

Open the attached project
Do a Gradle Sync

Full Stacktrace:

java.lang.AssertionError: Property found to be invalid, this should never happen!
	at com.android.tools.idea.gradle.dsl.model.ext.GradlePropertyModelImpl.<init>(GradlePropertyModelImpl.java:64)
	at com.android.tools.idea.gradle.dsl.model.ext.GradlePropertyModelImpl.lambda$dependencies$5(GradlePropertyModelImpl.java:671)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1655)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
	at com.android.tools.idea.gradle.dsl.model.ext.GradlePropertyModelImpl.dependencies(GradlePropertyModelImpl.java:672)
	at com.android.tools.idea.gradle.dsl.model.ext.GradlePropertyModelImpl.getDependencies(GradlePropertyModelImpl.java:212)
	at com.android.tools.idea.gradle.dsl.model.ext.PropertyUtil.resolveModel(PropertyUtil.java:131)
	at com.android.tools.idea.gradle.dsl.model.ext.ResolvedPropertyModelImpl.resolveModel(ResolvedPropertyModelImpl.java:245)
	at com.android.tools.idea.gradle.dsl.model.ext.ResolvedPropertyModelImpl.getValueType(ResolvedPropertyModelImpl.java:48)
	at com.android.tools.idea.gradle.dsl.model.PluginModelImpl.deduplicatePlugins(PluginModelImpl.java:85)
	at com.android.tools.idea.gradle.dsl.model.GradleBuildModelImpl.plugins(GradleBuildModelImpl.java:298)
	at com.android.tools.idea.gradle.plugin.AndroidPluginInfo.lambda$searchInBuildFiles$0(AndroidPluginInfo.java:121)
	at com.android.tools.idea.gradle.util.BuildFileProcessor.lambda$processRecursively$2(BuildFileProcessor.java:78)
	at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:835)
	at com.android.tools.idea.gradle.util.BuildFileProcessor.processRecursively(BuildFileProcessor.java:56)
	at com.android.tools.idea.gradle.plugin.AndroidPluginInfo.searchInBuildFiles(AndroidPluginInfo.java:118)
	at com.android.tools.idea.gradle.plugin.AndroidPluginInfo.findInBuildFiles(AndroidPluginInfo.java:101)
	at com.android.tools.idea.gradle.plugin.AndroidPluginInfo.find(AndroidPluginInfo.java:66)
	at com.android.tools.idea.gradle.project.sync.setup.post.upgrade.GradlePluginUpgrade.findPluginInfo(GradlePluginUpgrade.kt:317)
	at com.android.tools.idea.gradle.project.sync.setup.post.upgrade.GradlePluginUpgrade.shouldRecommendPluginUpgrade$default(GradlePluginUpgrade.kt:89)
	at com.android.tools.idea.gradle.project.sync.setup.post.upgrade.GradlePluginUpgrade.shouldRecommendPluginUpgrade(GradlePluginUpgrade.kt)
	at com.android.tools.idea.gradle.project.sync.idea.data.service.AndroidModuleModelDataService.onSuccessImport(AndroidModuleModelDataService.java:124)
	at com.intellij.openapi.externalSystem.service.project.manage.ProjectDataManagerImpl.lambda$doImportData$3(ProjectDataManagerImpl.java:298)
	at com.intellij.openapi.externalSystem.service.project.manage.ProjectDataManagerImpl$1.execute(ProjectDataManagerImpl.java:157)
	at com.intellij.openapi.externalSystem.util.DisposeAwareProjectChange.run(DisposeAwareProjectChange.java:22)
	at com.intellij.openapi.application.TransactionGuardImpl$2.run(TransactionGuardImpl.java:201)
	at com.intellij.openapi.application.impl.ApplicationImpl.runIntendedWriteActionOnCurrentThread(ApplicationImpl.java:802)
	at com.intellij.openapi.application.impl.ApplicationImpl.lambda$invokeLater$4(ApplicationImpl.java:322)
	at com.intellij.openapi.application.impl.FlushQueue.doRun(FlushQueue.java:84)
	at com.intellij.openapi.application.impl.FlushQueue.runNextEvent(FlushQueue.java:132)
	at com.intellij.openapi.application.impl.FlushQueue.flushNow(FlushQueue.java:47)
	at com.intellij.openapi.application.impl.FlushQueue$FlushNow.run(FlushQueue.java:188)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:313)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:776)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:727)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:746)
	at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:971)
	at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:841)
	at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$8(IdeEventQueue.java:452)
	at com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:744)
	at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$9(IdeEventQueue.java:451)
	at com.intellij.openapi.application.impl.ApplicationImpl.runIntendedWriteActionOnCurrentThread(ApplicationImpl.java:802)
	at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:499)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

android-ide-plugin-reproducer.zip

95 KB

Download

Screenshot 2020-08-18 at 14.57.10.png

17 KB

View

Download

Comments

ma...@gmail.com <ma...@gmail.com> #2Aug 18, 2020 01:08PM

In case the zip file is missing some files, I put the reproducer on github: https://github.com/martinbonnin/reproducer-165017523/

Also I forgot to mention but the error happens in IntelliJ "Event Log" window. The build works well.

Message last modified on Aug 18, 2020 01:10PM

xo...@google.com <xo...@google.com> Aug 19, 2020 09:01AM

Assigned to xo...@google.com.

xo...@google.com <xo...@google.com> #3Aug 21, 2020 03:11PM

Thank you very much for the report, and the reproducer. I've submitted a fix for this to our master branch.

As a workaround until that is released (it will eventually become part of Android Studio 4.2), could you try

BuildHelper.apply({ rootProject }.invoke())

as a replacement for

BuildHelper.apply(rootProject)

If that works (or doesn't!) for you without the internal error in your full context, that would be useful for me to know -- it will affect whether we should try to backport the fix.

Thanks again!

ma...@gmail.com <ma...@gmail.com> #4Aug 21, 2020 04:54PM

Thanks for the quick fix!

The workaround does work 👍. Another workaround is to rename the apply method to something else. It might not be possible in all cases but in this case this is code I have control over so it was easy to rename the method.

xo...@google.com <xo...@google.com> #5Aug 24, 2020 02:01PM

Marked as fixed.

Excellent. Since we have reasonably low-impact workarounds, I think we probably won't backport this to 4.1 -- I'll close this bug now. Thanks once again :-)

Issue 165017523