Wrong CryptoObject Type for canAuthenticate(int) Strong Authentication on API 29 [165824669]

Fixed

Bug

Status Update

No update yet.

Description

tb...@gmail.com

created issue #1

Aug 20, 2020 07:53PM

https://github.com/tylerbwong/BiometricCanAuthenticateBug

BUILD INFO

Device type: Samsung Galaxy S20 Ultra
OS version: 10
Biometric library version: 1.1.0-alpha02

STEPS TO REPRODUCE [Be as specific as possible please]

Call canAuthenticate(BIOMETRIC_STRONG)

EXPECTED RESULTS App should not crash

OBSERVED RESULTS App crashes with stack trace:

Caused by: java.lang.IllegalArgumentException: method android.hardware.biometrics.BiometricManager.canAuthenticate argument 1 has type android.hardware.biometrics.BiometricPrompt$CryptoObject, got androidx.biometric.BiometricPrompt$CryptoObject
        at java.lang.reflect.Method.invoke(Native Method)
        at androidx.biometric.BiometricManager.canAuthenticateWithStrongBiometricOnApi29(BiometricManager.java:412)
        at androidx.biometric.BiometricManager.canAuthenticateCompat(BiometricManager.java:381)
        at androidx.biometric.BiometricManager.canAuthenticate(BiometricManager.java:336)

NUMBER OF TIMES YOU WERE ABLE TO REPRODUCE (e.g. 3/10) 10/10

Comments

cu...@google.com <cu...@google.com> Sep 14, 2020 09:21PM

Reassigned to cu...@google.com.

ap...@google.com <ap...@google.com> #2Sep 15, 2020 08:51PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 86099342fd081849e9dcdccff21b5b42ca18b57b
Author: Curtis Belmonte <curtislb@google.com>
Date: Mon Sep 14 16:21:09 2020

Fix CryptoObject type in BiometricManager reflective call

Ensures that an android.hardware.biometrics.BiometricPrompt.CryptoObject
is passed to the BiometricManager#canAuthenticate(CryptoObject) non-API
method, instead of androidx.biometric.BiometricPrompt.CryptoObject. Also
adds IllegalArgumentException to the list of handled exceptions for this
reflective invocation, to avoid crashing on a device with a different
method signature (since it's not part of the public Android API).

Test: Biometric integration test app on Samsung device with API 29.
Fixes: 165824669
Change-Id: I550d06679610ed423e8a4362a738f6ae4ff49279

M biometric/biometric/src/main/java/androidx/biometric/BiometricManager.java

https://android-review.googlesource.com/1427353

Issue 165824669

Description

Issue summary

Comments

cu...@google.com <cu...@google.com> Sep 14, 2020 09:21PM

ap...@google.com <ap...@google.com> #2Sep 15, 2020 08:51PM

Add comment

Issue metadata