Fixed
Status Update
Comments
vi...@google.com <vi...@google.com>
qi...@gmail.com <qi...@gmail.com> #2
Hi,
Thank you for taking the time to improve libphonenumber!
We are looking into this and will respond as soon as possible.
lb...@gmail.com <lb...@gmail.com> #3
Hi,
Thanks much for raising this issue. This is one of our known issue, which is not documented. Having phone numbers of this long are very rare. libphonenumber cannot do anything better here.
Reasons:
- JavaScript
Number
type has limitation of 2^53 (9007199254740992) as the max literal it can hold. When provided more than that like "90018408059449376"(17 digit), JS starts rounding the value. Unfortunately this is within the range of i.e 17 digit.possible phone number length - Both the alternatives leads to backward-incompatible changes as the type of the field '''national_number''' has to be changed; thus leading to client-side compile issue . Eg: setNationalNumber(1234) / conversions to payloads like JSON.
- Marking the field as
[jstype = JS_STRING]
- Or using new JS data type
BigInt
.
We will update FAQ at GitHub stating some of these points. Maybe you can compare with Number.MAX_VALUE and avoid such cases. Or post request to a Java/CPP/PY libphonenumber clients, as these langs have much more matured data type systems.
lb...@gmail.com <lb...@gmail.com> #5
+923146233552
vi...@google.com <vi...@google.com> #6
This issue will be considered for future release.
vi...@google.com <vi...@google.com> #7
This issue will be reconsidered for future release.
lb...@gmail.com <lb...@gmail.com> #8
@7 What's the difference between your promise and the one that @6 promised?
🤔
🤔
vi...@google.com <vi...@google.com> #9
The development team has fixed the issue that you have reported and it will be available in a future build.
lb...@gmail.com <lb...@gmail.com> #10
@9 Meaning after Android R ?
lb...@gmail.com <lb...@gmail.com> #11
Seems indeed fixed on Android S
[Deleted User] <[Deleted User]> #12
What is Android S
lb...@gmail.com <lb...@gmail.com> #13
@12
Android S = Android 12 = Android API 31.
Android S = Android 12 = Android API 31.
[Deleted User] <[Deleted User]> #14
Thanks. Pls how do i know if my android 11 version is running on stable or beta?
li...@gmail.com <li...@gmail.com> #15
google fix this bug in there commit:
e9e278f67074892adf3a57bb314dfc362b486149
9da97c2d39d4e6ef968d8436698fd9f959e16b2e
hope the information is useful
e9e278f67074892adf3a57bb314dfc362b486149
9da97c2d39d4e6ef968d8436698fd9f959e16b2e
hope the information is useful
am...@gmail.com <am...@gmail.com> #16
where i can get these commits ? which repo has this changes
Description
This still occurs even on stable version of Android R:
To reproduce, have some APK file on the file system, install some third party file manager app (example is "Solid Explorer"), and try to install the APK file.
As opposed to what Google wrote, it will kill the app and it won't let the app to restore its state.
This is because it uses Intent to open the APK.
If you wish, I can create a POC to show the issue again.
See attached