maxLength in TextField [170648072]

Fixed

Feature Request

Status Update

No update yet.

Description

si...@google.com

created issue #1

Oct 12, 2020 06:17PM

platform had issues with maxLength not set.
We should put a maxLength into TextField and set a default value.

Comments

si...@google.com <si...@google.com> Jun 16, 2021 03:42PM

Status: Won't Fix (Obsolete)

al...@lyft.com <al...@lyft.com> #2Jun 17, 2021 06:20PM

Could you let me know how to run these benchmarks before CL submission? I think I should run them to improve on this. Thanks!

si...@google.com <si...@google.com> #3Jun 18, 2021 03:56PM

Assigned to an...@google.com.

It is generally quite tricky to run all of them locally and do diffs in between. Unless there are some partciular ones where you already know they might be failing :) So detecting later in CI is WAI.

However the command to run them is:

lock your cpu clocks

./gradlew lockClocks

run the benchmarks

./gradlew :compose:integration-tests:benchmark:connectedCheck

^- this will run them all which I would not recommend as it takes lot of time

./gradlew :compose:integration-tests:benchmark:connectedCheck -Pandroid.testInstrumentationRunnerArguments.class=<fully-qualified-class>

^- this will run only a specific class with benchmarks in it

And to get the result, typically just Android Studio -> logcat -> filter "Benchmark" keyword

al...@gmail.com <al...@gmail.com> #4Jun 19, 2021 09:40PM

I would also recommend trying to repro the regression before and after the change. As we are not doing when filing the bugs, hoping we got it right :)

an...@gmail.com <an...@gmail.com> #5Dec 11, 2021 02:14PM

The regression for some tests is 30x. Please consider reverting.

al...@gmail.com <al...@gmail.com> #6Apr 28, 2022 04:06PM

The revert cl is pending API approval: aosp/1408985

al...@gmail.com <al...@gmail.com> #7Feb 7, 2024 06:14PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 338af8a6b3d6a936d06e55720d66133d36df9283
Author: yingleiw <yingleiw@google.com>
Date: Tue Aug 25 14:11:55 2020

Revert "Notify accessibility when semantics node bounds change"

This reverts commit cd4dadf83390f9ecf50e22ff03f21fdafa4bd504.

Reason for revert:

b/166106882

, performance regression.

Relnote: remove callback to notify Owner when layoutnode bounds change.
Test: tested manually.

Change-Id: If654ebfbf711c9a7f6bcddb28673e4b6f786d05b

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt

https://android-review.googlesource.com/1408985

ha...@google.com <ha...@google.com> #8Feb 8, 2024 01:44PM

Do the benchmark tests have accessibility manager enabled? (if using ui automator, then accessibility manager is enabled)

I got errors sending out accessibility events for

./gradlew :compose:integration-tests:benchmark:connectedCheck -Pandroid.testInstrumentationRunnerArguments.class=androidx.ui.benchmark.test.TextInColumnBenchmark#toggleRectangleColor_measure

Also, for the following result:

2020-08-26 13:25:25.041 22776-22796/? I/Benchmark: TextInColumnBenchmark.toggleRectangleColor_measure[100][Stats for timeNs: median 10747475, min 9314063, max 12672410, mean 1.087254574E7, standardDeviation: 991142.0110795262, Stats for allocationCount: median 12761, min 12761, max 12761, mean 12761.0, standardDeviation: 0.0]count=4

What does this 100 means?

I also see this 100 in the dash board:
androidx.ui.benchmark.test.TextInColumnBenchmark_toggleRectangleColor_measure_100_

Thanks!

ap...@google.com <ap...@google.com> #9Feb 14, 2024 12:32AM

100 is a parameterization argument - see https://cs.android.com/androidx/platform/frameworks/support/+/androidx-master-dev:compose/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/TextInColumnBenchmark.kt;l=48;drc=d2595e3d26d5f4b3b3136c68385cc47a5626f1e8

In that benchmark, it's the number of columns, and run with both values there. For local debugging, you can comment out 10 so you only see the results for 100.

Do the benchmark tests have accessibility manager enabled? (if using ui automator, then accessibility manager is enabled)

I don't expect they'd use UI automator - they're pretty standard instrumentation tests, but it's possible some infrastructure is using ui automator, or enabling the accessibility manager. Can you check while running locally?

ap...@google.com <ap...@google.com> #10Feb 28, 2024 06:49PM

when I run locally, I can see accessibility manager is enabled. I verified it is not enabled manually on my device because when I use other tests, the log shows accessibility manager is not enabled.

So I suppose the benchmarks (at least the TextInColumnBenchmark#toggleRectangleColor_measure) have accessibility manage enabled.

From my current runs, I see the performance degradation is in AndroidAccessibilityDelegateCompatCompat, not in LayoutNodeWrapper (finding the outer semantics).
So it is the building semantic tree and sending too many events caused this.

ha...@google.com <ha...@google.com> #11Apr 12, 2024 04:22PM

Marked as fixed, reassigned to ha...@google.com.

Can you try running a more minimal benchmark, and see if the accessibility manager is enabled? E.g. TrivialKotlinBenchmark.kt in benchmark-benchmark (note, not part of compose project, have to use frameworks/support/)

I'm also curious if it's enabled in standard simple instrumentation tests out of the box (e.g. new empty project in studio, run test there).