AssertDetector warn false positive since AGP4.1 [170657532]

Fixed

Bug

Status Update

No update yet.

Description

ga...@gmail.com

created issue #1

Oct 13, 2020 02:39AM

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: 4.1
Version of Gradle Plugin: 4.1
Version of Gradle: 6.6
Version of Java: 1.8
OS: All

Since AGP 4.1, assert() is working properly because of D8 behavior change.
https://jakewharton.com/d8-optimization-assertions/#tomorrows-behavior

But lint checker still warn with old behavior with following message.

Assertions are never enabled in Android. Use BuildConfig.DEBUG conditional checks instead.

Please disable AssertDetector that can provide misleading help.

Comments

vi...@google.com <vi...@google.com> Oct 13, 2020 03:23AM

Assigned to an...@google.com.

tn...@google.com <tn...@google.com> #2Oct 24, 2020 02:48AM

I think this behavior is tied behind a flag to D8. Jerome and/or Mads, can you confirm that as of 4.1, you're passing --force-enable-assertions to D8/R8?

tn...@google.com <tn...@google.com> #3Oct 24, 2020 02:49AM

Reassigned to je...@google.com.

(I quickly grepped the source code for AGP and didn't see it, but maybe it doesn't appear as that literal string or uses some constant defined by R8 somewhere.)

ga...@gmail.com <ga...@gmail.com> #4Oct 24, 2020 03:13AM

https://android.googlesource.com/platform/tools/base/+/refs/tags/studio-4.1.0/build-system/builder/src/main/java/com/android/builder/dexing/r8Tool.kt#126

ag...@google.com <ag...@google.com> #5Oct 26, 2020 08:13AM

Reassigned to tn...@google.com.

Yes, as comment #4 links to: for all debug builds starting AGP 4.1, AGP asks D8 to enable all assertions at compile time.

tn...@google.com <tn...@google.com> #6Oct 30, 2020 05:01PM

Marked as fixed.

Thanks! This is now fixed in 4.2 and main. In 4.2, the check is just disabled by default. In main, it's deleted (along with more graceful handling, e.g. such that it doesn't complain about unknown issue id's left in build.gradle files, properly ignores these entries in basefiles, etc.)

Issue 170657532