IssueTracker

This issue was migrated from https://crbug.com/1002993.

Project: chromiumos/platform/ec
Branch: main

commit 77d3756d27758276c084cf20693202cfa645df3e
Author: Craig Hesling <hesling@chromium.org>
Date:   Thu Jul 29 14:02:00 2021

    biod: Add fptool.py that will replace flash_fp_mcu
   
    This is similar to gsctool, but this tool would only be in the
    test image.
   
    This comes from the effort to move away from shell script.
    See http://go/deshell.
   
    The idea is that you start with a simple wrapper for the given shell
    script. Over time, features are transplanted or added-new to the python
    wrapper, until the shell script is no longer needed.
   
    BRANCH=none
    BUG=b:172020576
    TEST=./util/fptool.py
         ./util/fptool.py --help
         ./util/fptool.py flash --help
         ./util/fptool.py flash
         # Error about flash_fp_mcu not existing
    TEST=scp util/fptool.py $DUT:/usr/local/bin
         ssh $DUT fptool.py flash /root/doesnotexist
         ssh $DUT fptool.py flash
         ssh $DUT fptool.py flash /opt/google/biod/fw/$(cros_config /fingerprint board)*.bin
   
    Change-Id: I8774bda4a057ee09f70bf474ce3ba2fa0bbcf92d
    Signed-off-by: Craig Hesling <hesling@chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3060744
    Reviewed-by: Josie Nordrum <josienordrum@google.com>

A       util/fptool.py

https://chromium-review.googlesource.com/3060744

Project: chromiumos/overlays/chromiumos-overlay
Branch: main

commit ad739b55f3d7df7e7f5b690f7586c8f885c01326
Author: Craig Hesling <hesling@chromium.org>
Date:   Fri Jul 30 16:19:29 2021

    ec-utils-test: Add fptool to test image
   
    BUG=b:172020576
    TEST=cros-workon-hatch start ec-utils-test
         ./build_packages --board=hatch ec-utils-test
         # Using this deploy without
         cros deploy --root=/usr/local ssh://localhost:2222 ec-utils-test
         ssh localhost -p2222 -- which -a fptool
         ssh localhost -p2222 -- fptool --help
   
    Change-Id: I41959928792ad2719aaca8d161e86107a66dc5d7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/3064302
    Tested-by: Craig Hesling <hesling@chromium.org>
    Commit-Queue: Craig Hesling <hesling@chromium.org>
    Reviewed-by: Mike Frysinger <vapier@chromium.org>
    Reviewed-by: Josie Nordrum <josienordrum@google.com>

M       chromeos-base/ec-utils-test/ec-utils-test-9999.ebuild

https://chromium-review.googlesource.com/3064302

Project: chromiumos/overlays/chromiumos-overlay
Branch: main

commit 8682b4edee16caa2eb16cd70ec80344b8e2b187a
Author: Craig Hesling <hesling@chromium.org>
Date:   Fri Jul 30 16:15:57 2021

    ec-utils-test: Formalize dependency on python
   
    We already install the inject-keys.py script, which can use python2
    or python3. Let's just note that we need python3.
   
    BUG=b:172020576
    TEST=cros-workon-hatch start ec-utils-test
         ./build_packages --board=hatch ec-utils-test
         cros deploy ssh://$DUT ec-utils-test
   
    Change-Id: Iafea15caaced69ed0f7cc82cab5d8232e65ba2fa
    Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/3064301
    Tested-by: Craig Hesling <hesling@chromium.org>
    Reviewed-by: Mike Frysinger <vapier@chromium.org>
    Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
    Commit-Queue: Craig Hesling <hesling@chromium.org>

M       chromeos-base/ec-utils-test/ec-utils-test-9999.ebuild

https://chromium-review.googlesource.com/3064301