Internal Cleanup P3
Status Update
No update yet.
Comments
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/dbf46af3d7f5837db4c5871767cf886b1a7472ad
commit dbf46af3d7f5837db4c5871767cf886b1a7472ad
Author: Yen-lin Lai <yenlinlai@google.com>
Date: Thu Feb 06 19:33:43 2020
network: IwlwifiPCIRescan: wait for shill restart
In current pci_rescan script, we'll restart shill to mitigate bugs
likecrbug.com/1029162 . We should wait for shill to restart before any
further dbus operation or else shill can restart anytime and causing
errors. Also, if the interface is recovered before shill restart, this
test could just end and leaving the restart to harm later tests.
Once thecrbug.com/1048366 is fixed and shill restart is removed, the
test will start failing and we need to revert this commit.
BUG=chromium:953497, chromium:1048366, chromium:1048075
TEST=`tast run $DUT network.IwlwifiPCIRescan` on cyan DUT
Change-Id: Ifa24cdceb72e9e8f194b1971ff2f5c97aa452ef5
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2035570
Tested-by: Yen-lin Lai <yenlinlai@google.com>
Reviewed-by: Shuo-Peng Liao <deanliao@chromium.org>
Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Commit-Queue: Brian Norris <briannorris@chromium.org>
[modify]https://crrev.com/dbf46af3d7f5837db4c5871767cf886b1a7472ad/src/chromiumos/tast/local/bundles/cros/network/iwlwifi_pci_rescan.go
commit dbf46af3d7f5837db4c5871767cf886b1a7472ad
Author: Yen-lin Lai <yenlinlai@google.com>
Date: Thu Feb 06 19:33:43 2020
network: IwlwifiPCIRescan: wait for shill restart
In current pci_rescan script, we'll restart shill to mitigate bugs
like
further dbus operation or else shill can restart anytime and causing
errors. Also, if the interface is recovered before shill restart, this
test could just end and leaving the restart to harm later tests.
Once the
test will start failing and we need to revert this commit.
BUG=chromium:953497, chromium:1048366, chromium:1048075
TEST=`tast run $DUT network.IwlwifiPCIRescan` on cyan DUT
Change-Id: Ifa24cdceb72e9e8f194b1971ff2f5c97aa452ef5
Reviewed-on:
Tested-by: Yen-lin Lai <yenlinlai@google.com>
Reviewed-by: Shuo-Peng Liao <deanliao@chromium.org>
Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Commit-Queue: Brian Norris <briannorris@chromium.org>
[modify]
de...@google.com
Note that once we drop "restart shill" from iwlwifi_rescan, we need to revert the above CL: https://crrev.com/c/2035570
kb...@google.com
This issue was discovered by the WiFi hygiene check and tagged with the 'Partner-WiFi' hotlist.
If this was inappropriate please add the 'CrOSWiFi-OptOut' hotlist and remove 'Partner-WiFi'.
Questions / Concerns? Please ping kbleicher@.
If this was inappropriate please add the 'CrOSWiFi-OptOut' hotlist and remove 'Partner-WiFi'.
Questions / Concerns? Please ping kbleicher@.
br...@google.com
It's time to admit I'm not going to do this --> punt
Description
Filing a proper bug to track the work to finish this CL:
There are many factors in why the 'restart' workarounds where added in the first place, and we need to unravel those before we can really remove the workaround.
This also affects our ability to test rescan behavior (
and that will need to be reverted once we really stop the 'restart' behavio. So it's nice to have a bug specifically to track this workaround.
---
There's some more context on the CLs for what precisely is needed before we can close this out.