Internal Cleanup P3
Status Update
Comments
bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #2
The following revision refers to this bug:
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/aa9a38a328286f45dd9e4f26eaf60a8a36b8309b
commit aa9a38a328286f45dd9e4f26eaf60a8a36b8309b
Author: Shuo-Peng Liao <deanliao@chromium.org>
Date: Tue Nov 26 00:34:18 2019
autotest: Stop packaging tast-ported network_* tests.
network_UdevRename, network_WiFiCaps, network_TwoShills are all ported
to Tast and running.
Noted that for ported network_WlanDriver, it is not going to be
deprecated becausecrbug.com/948805 refrains external developers from
running Tast tests and partners need to run the test.
BUG=chromium:885910, chromium:1024886
TEST=Pass emerge-grunt autotest-tests-shill autotest-tests
Pass Pre-CQ
Change-Id: Ib24912e7909d72389ea18c5c2031db279515b81d
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1917579
Reviewed-by: Brian Norris <briannorris@chromium.org>
Tested-by: Shuo-Peng Liao <deanliao@chromium.org>
Commit-Queue: Brian Norris <briannorris@chromium.org>
[modify]https://crrev.com/aa9a38a328286f45dd9e4f26eaf60a8a36b8309b/chromeos-base/autotest-tests-shill/autotest-tests-shill-9999.ebuild
[modify]https://crrev.com/aa9a38a328286f45dd9e4f26eaf60a8a36b8309b/chromeos-base/autotest-tests/autotest-tests-9999.ebuild
commit aa9a38a328286f45dd9e4f26eaf60a8a36b8309b
Author: Shuo-Peng Liao <deanliao@chromium.org>
Date: Tue Nov 26 00:34:18 2019
autotest: Stop packaging tast-ported network_* tests.
network_UdevRename, network_WiFiCaps, network_TwoShills are all ported
to Tast and running.
Noted that for ported network_WlanDriver, it is not going to be
deprecated because
running Tast tests and partners need to run the test.
BUG=chromium:885910, chromium:1024886
TEST=Pass emerge-grunt autotest-tests-shill autotest-tests
Pass Pre-CQ
Change-Id: Ib24912e7909d72389ea18c5c2031db279515b81d
Reviewed-on:
Reviewed-by: Brian Norris <briannorris@chromium.org>
Tested-by: Shuo-Peng Liao <deanliao@chromium.org>
Commit-Queue: Brian Norris <briannorris@chromium.org>
[modify]
[modify]
de...@google.com <de...@google.com> #3
AI: remove code network_UdevRename, network_WiFiCaps, network_TwoShills.
de...@google.com <de...@google.com> #4
Noted that https://crrev.com/c/1884695 (laded in 12641.0.0) removed network_DefaultProfileServices and network_ConfigureEthernetServiceForProfile
de...@google.com <de...@google.com> #5
AI:
1. stop packaging network_BasicProfileProperties
2. network.DefaultProfile: run it on "wifi" enabled device only [1]
[1]https://stainless.corp.google.com/search?view=matrix&row=board&col=build&first_date=2020-02-06&last_date=2020-02-19&test=network%5C.DefaultProfile&status=FAIL&status=ERROR&exclude_cts=true&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=false&exclude_non_production=false
1. stop packaging network_BasicProfileProperties
2. network.DefaultProfile: run it on "wifi" enabled device only [1]
[1]
de...@google.com <de...@google.com> #6
Re comment 4, network.DefaultProfile fails on the same device about 50% chance. Filed crbug.com/1053852
bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #7
The following revision refers to this bug:
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/40e3b965b9686aba005f1359c011cd3e29793088
commit 40e3b965b9686aba005f1359c011cd3e29793088
Author: Shuo-Peng Liao <deanliao@chromium.org>
Date: Mon Feb 24 20:18:57 2020
autotest-tests-shill: stop packaging network_BasicProfileProperties
network_BasicProfileProperties has been ported to Tast as
network.BasicProfileProperties and it is green now [1].
[1]https://stainless.corp.google.com/search?view=matrix&row=board_model&col=build&first_date=2020-02-13&last_date=2020-02-19&test=network%5C.BasicProfileProperties&exclude_cts=false&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=false&exclude_non_production=false~
BUG=chromium:1024886
TEST=none
Change-Id: I11e309e8963f3db7509970d4a015a40a7213665e
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2064089
Reviewed-by: Arowa Suliman <arowa@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Tested-by: Shuo-Peng Liao <deanliao@chromium.org>
Commit-Queue: Brian Norris <briannorris@chromium.org>
[modify]https://crrev.com/40e3b965b9686aba005f1359c011cd3e29793088/chromeos-base/autotest-tests-shill/autotest-tests-shill-9999.ebuild
commit 40e3b965b9686aba005f1359c011cd3e29793088
Author: Shuo-Peng Liao <deanliao@chromium.org>
Date: Mon Feb 24 20:18:57 2020
autotest-tests-shill: stop packaging network_BasicProfileProperties
network_BasicProfileProperties has been ported to Tast as
network.BasicProfileProperties and it is green now [1].
[1]
BUG=chromium:1024886
TEST=none
Change-Id: I11e309e8963f3db7509970d4a015a40a7213665e
Reviewed-on:
Reviewed-by: Arowa Suliman <arowa@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Tested-by: Shuo-Peng Liao <deanliao@chromium.org>
Commit-Queue: Brian Norris <briannorris@chromium.org>
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #8
The following revision refers to this bug:
https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7e36228c52f34467d31146a4bad0a03dbed6e211
commit 7e36228c52f34467d31146a4bad0a03dbed6e211
Author: Shuo-Peng Liao <deanliao@chromium.org>
Date: Thu Feb 27 15:03:39 2020
autotest: remove network_TwoShill and network_UdevRename.
The two tests are already migrated to Tast (network.TwoShill and
network.UdevRename). They stopped running sincecrrev.com/c/1917579 .
It is time to remove code.
Noted that though network_WiFiCaps is also migrated. It is used in
suite_HWConfig and suite_HWQual. Postpone its code removal.
BUG=chromium:1024886
TEST=None
Change-Id: I4ac6d2ad7ce770483e90f25bda6295ec3b0b40d1
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/2061936
Reviewed-by: Brian Norris <briannorris@chromium.org>
Commit-Queue: Shuo-Peng Liao <deanliao@chromium.org>
Tested-by: Shuo-Peng Liao <deanliao@chromium.org>
[delete]https://crrev.com/9eff29f3bedc573f2e08cfa2a87e3b5ef961be8e/client/site_tests/network_TwoShills/network_TwoShills.py
[delete]https://crrev.com/9eff29f3bedc573f2e08cfa2a87e3b5ef961be8e/client/site_tests/network_UdevRename/network_UdevRename.py
[delete]https://crrev.com/9eff29f3bedc573f2e08cfa2a87e3b5ef961be8e/client/site_tests/network_UdevRename/control
[delete]https://crrev.com/9eff29f3bedc573f2e08cfa2a87e3b5ef961be8e/client/site_tests/network_TwoShills/control
commit 7e36228c52f34467d31146a4bad0a03dbed6e211
Author: Shuo-Peng Liao <deanliao@chromium.org>
Date: Thu Feb 27 15:03:39 2020
autotest: remove network_TwoShill and network_UdevRename.
The two tests are already migrated to Tast (network.TwoShill and
network.UdevRename). They stopped running since
It is time to remove code.
Noted that though network_WiFiCaps is also migrated. It is used in
suite_HWConfig and suite_HWQual. Postpone its code removal.
BUG=chromium:1024886
TEST=None
Change-Id: I4ac6d2ad7ce770483e90f25bda6295ec3b0b40d1
Reviewed-on:
Reviewed-by: Brian Norris <briannorris@chromium.org>
Commit-Queue: Shuo-Peng Liao <deanliao@chromium.org>
Tested-by: Shuo-Peng Liao <deanliao@chromium.org>
[delete]
[delete]
[delete]
[delete]
br...@google.com <br...@google.com> #9
(Note: removing Test>Tast to keep only a single Component -- necessary for b/ migration.)
de...@google.com <de...@google.com> #10
Noted that remote Autotest tests in suite:wifi_matfunc and suite:wifi_perf are excluded. The two suites are critical for WiFi AVL test. We plan to keep them as is until Tast migration is done.
bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #11
The following revision refers to this bug:
https://chromium.googlesource.com/chromiumos/third_party/autotest/+/777b407c7795393e8a7a9072477f9db662ce9b0b
commit 777b407c7795393e8a7a9072477f9db662ce9b0b
Author: Shuo-Peng Liao <deanliao@chromium.org>
Date: Wed Apr 08 11:21:16 2020
autotest: remove network_BasicProfileProperties.
Its Tast counterpart, network.BasicProfileProperties is stable and runs in CQ now.
It is time to retire the Autotest version.
BUG=chromium:1025060, chromium:1024886
TEST=None
Change-Id: Id979c7db3cd66e22780e118972def0cc0e7b1402
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/2140111
Tested-by: Shuo-Peng Liao <deanliao@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Commit-Queue: Shuo-Peng Liao <deanliao@chromium.org>
[delete]https://crrev.com/c920e63e11aff5272002c7b2900cd679eb66feba/client/site_tests/network_BasicProfileProperties/network_BasicProfileProperties.py
[delete]https://crrev.com/c920e63e11aff5272002c7b2900cd679eb66feba/client/site_tests/network_BasicProfileProperties/control
commit 777b407c7795393e8a7a9072477f9db662ce9b0b
Author: Shuo-Peng Liao <deanliao@chromium.org>
Date: Wed Apr 08 11:21:16 2020
autotest: remove network_BasicProfileProperties.
Its Tast counterpart, network.BasicProfileProperties is stable and runs in CQ now.
It is time to retire the Autotest version.
BUG=chromium:1025060, chromium:1024886
TEST=None
Change-Id: Id979c7db3cd66e22780e118972def0cc0e7b1402
Reviewed-on:
Tested-by: Shuo-Peng Liao <deanliao@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Commit-Queue: Shuo-Peng Liao <deanliao@chromium.org>
[delete]
[delete]
Description
After migrating CrOS network tests from autotest to Tast framework, we should:
1. verify Tast test behaves the same as autotest one (at least no regression);
2. stop packaging the autotest
3. remove the code
Refer to
Master issue tracker: