autotest: wifi: network_WiFi_VerifyRouter should check that both antenna have good signal and we see good MIMO rates [172223644]

Feature Request

adexe s nau

Status Update

No update yet.

Description

ki...@google.com

created issue #1

May 23, 2018 12:54AM

Migrated from

https://crbug.com/845755

zmarcus@ found a kefka in pool:wificell that was showing SISO rates in `iw wlan0 station dump` on both AP (managed0) and DUT (wlan0) sides while running VHT80 perf tests.
Signal levels showed -14 and -60, IIRC, indicating one connector was broken.

This was detected in software and a physical check showed that one pigtail was indeed not connected. Augment network_WiFi_VerifyRouter to add a check for good MIMO rates and similar signal on both antenna.

Comments

br...@google.com <br...@google.com> #2May 23, 2018 01:24AM

It seems you should use com.intellij.psi.PsiClass.getSuperClassType() to check

ha...@google.com <ha...@google.com> #3May 23, 2018 01:32AM

Analyzing dynamic features on their own like that doesn't work properly since even though they "depend" on the app they're actually including into an app so for example the unused resource check only makes sense when you look at it from the app perspective, not the other way around.

I believe in 7.0 we've fixed this in the sense that there isn't a lint task on the individual dynamic features.

br...@google.com <br...@google.com> #4May 23, 2018 01:35AM

+1. In AGP 7.0 there are no lint tasks in dynamic-features; instead, any dynamic-features are analyzed when running lint on the app module. OP, can you try with AGP 7.0.0-rc01, run lintRelease on the corresponding application module, and see if you still hit the same issue?

ha...@google.com <ha...@google.com> #5May 23, 2018 02:04AM

Not using dynamic feature modules but have this with an application module and a library module, happening on 7.0.0-rc01. I haven't figured out a repro yet but will upload one if I manage.

br...@google.com <br...@google.com> #6Aug 1, 2018 09:58PM

Re #5, yes, a repro project would be very helpful, thanks!

br...@google.com <br...@google.com> #7Aug 7, 2018 06:37PM

Closing this bug as not reproducible, but please reopen if you have a repro project.

bu...@chromium.org <bu...@chromium.org> #8Aug 23, 2018 02:42PM

The following revision refers to this bug:

https://chromium.googlesource.com/chromiumos/third_party/autotest/+/56964636c685c06b68d85fe91b731d5b6bcaa108

commit 56964636c685c06b68d85fe91b731d5b6bcaa108
Author: Brian Norris <briannorris@chromium.org>
Date: Thu Aug 23 14:37:13 2018

[autotest] network_WiFi_VerifyRouter: reject low signal strength

Add an additional sanity check, so we can detect miswired conductive
Wifi cells.

BUG=chromium:845755
TEST=network_WiFi_VerifyRouter, on whirlwind and stumpy machines in the
lab

Change-Id: I3099a0527c77037a5354509b8a9122986f2a8b9b
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on:

https://chromium-review.googlesource.com/1184162
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify]

https://crrev.com/56964636c685c06b68d85fe91b731d5b6bcaa108/server/site_tests/network_WiFi_VerifyRouter/network_WiFi_VerifyRouter.py

br...@google.com <br...@google.com> #9Aug 30, 2018 05:59PM

Another note, since I was investigating this elsewhere: the new per-antenna signal strength stuff [1] is only supported on a few drivers. It was added to ath10k in v4.13, and it was only recently implemented on brcmfmac. It's still not supported for mwifiex. It was added for iwlwifi in v3.12:

226eb8cd22b6 iwlwifi: mvm: report per-chain signal to mac80211

[1] NL80211_STA_INFO_CHAIN_SIGNAL_AVG / @NL80211_STA_INFO_CHAIN_SIGNAL

kg...@google.com <kg...@google.com> #10Aug 26, 2019 09:14PM

The backing wifi interface class (

http://cs/chromeos_public/src/third_party/autotest/files/client/common_lib/cros/network/interface.py?l=413) used by this test uses the command 'iw dev ${DEVICE} link' to find the signal level, which unlike "iw ${DEVICE} station dump", only outputs the average signal level between the antennas, even for intel devices that are capable of reporting per-channel signal. The two samples below were taken from the same device, ${DEVICE} = 'wlan0'; notice the "signal:" field.

Sample "iw dev ${DEVICE} link" output:

Connected to 44:48:c1:af:d7:31 (on wlan0)
SSID: GoogleGuest
freq: 5765
RX: 24631 bytes (218 packets)
TX: 51059 bytes (383 packets)
signal: -50 dBm
rx bitrate: 400.0 MBit/s VHT-MCS 9 40MHz short GI VHT-NSS 2
tx bitrate: 400.0 MBit/s VHT-MCS 9 40MHz short GI VHT-NSS 2

bss flags: short-slot-time
dtim period: 1
beacon int: 100

Sample "iw ${DEVICE} station dump" output:

Station 44:48:c1:af:d7:31 (on wlan0)
inactive time: 12935 ms
rx bytes: 25103
rx packets: 223
tx bytes: 52311
tx packets: 391
tx retries: 7
tx failed: 0
beacon loss: 0
beacon rx: 126
rx drop misc: 0
signal: -51 [-51, -52] dBm
signal avg: 55 dBm
beacon signal avg: -47 dBm
tx bitrate: 400.0 MBit/s VHT-MCS 9 40MHz short GI VHT-NSS 2
rx bitrate: 400.0 MBit/s VHT-MCS 9 40MHz short GI VHT-NSS 2
authorized: yes
authenticated: yes
associated: yes
preamble: long
WMM/WME: yes
MFP: no
TDLS peer: no
DTIM period: 1
beacon interval:100
short slot time:yes
connected time: 3043 seconds

This leads me to believe the two antenna checking cannot be added to network_WiFi_VerifyRouter.py without also adding two antenna functionality to client/common_lib/cros/network/interface.py (and consequently the wrapper in server/cros/network/wifi_client.py). I can add this functionality (possibly by adding another function which attempts to pull two-antenna results from iw station dump), but I'm not sure if it would be worthwhile to add to it to the autotest suite for this one test. Also, its possible I'm misunderstanding this and there is indeed a way to access individual antenna results from the current framework, in which case please feel free to correct me.

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #11Sep 17, 2019 12:26AM

The following revision refers to this bug:

https://chromium.googlesource.com/chromiumos/third_party/autotest/+/80fd8e5ce7c1de38b703a239ec86ce19a5c0f95d

commit 80fd8e5ce7c1de38b703a239ec86ce19a5c0f95d
Author: Kevin Lund <kglund@google.com>
Date: Tue Sep 17 00:21:18 2019

network_WiFi_VerifyRouter.py: check all antennas for good signals

This change adds functionality to autotest to test the signal to
individual antennas when that information is provided by the device.
network_WiFi_VerifyRouter.py now tests that all antennas on the device
are connected properly with similar connection strengths. In cases
where per antenna signal data is not provided by the device, the
tests behaves normally.

BUG=chromium:845755
TEST=Test passes on a working device/router combo and accurately
parses individual antenna signals when provided. Test behaves
properly when per antenna signal is not provded.

Change-Id: I34cdbacf0a0c088cc969b98e13205d7ccc1cf18f
Reviewed-on:

https://chromium-review.googlesource.com/1772500
Tested-by: Kevin Lund <kglund@google.com>
Commit-Ready: Brian Norris <briannorris@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify]

https://crrev.com/80fd8e5ce7c1de38b703a239ec86ce19a5c0f95d/client/common_lib/cros/network/interface.py
[modify]

https://crrev.com/80fd8e5ce7c1de38b703a239ec86ce19a5c0f95d/server/cros/network/wifi_client.py
[modify]

https://crrev.com/80fd8e5ce7c1de38b703a239ec86ce19a5c0f95d/server/site_tests/network_WiFi_VerifyRouter/network_WiFi_VerifyRouter.py

br...@google.com <br...@google.com> #12Jul 31, 2020 01:44AM

Owner is gone