Status Update
Comments
si...@google.com <si...@google.com> #2
foe example in the example provided in
var text by remember { mutableStateOf("Text") }
val handler = remember { Handler(Looper.getMainLooper()) }
OutlinedTextField(
value = text,
onValueChange = {
handler.removeCallbacksAndMessages(null)
handler.postDelayed({
text = it
}, 10)
},
label = { Text("Label") },
modifier = Modifier.fillMaxWidth()
)
When the above function is called, it is not impossible for CoreTextField to know about it. What happens is
- CoreTextField gets value text
- when user types onValueChange is fired
- (developer delays the new value for recompose)
- CoreTextField after onValueChange requests a recompose
- When recompose happens the changed data is passed to developer, and recompose happens with old data (therefore it is not possible to change the cursor location by user either, since it resets to initial value)
si...@google.com <si...@google.com>
si...@google.com <si...@google.com> #3
While working on the new APi here are the things we want to update in the current API so that we can clear some of the bugs:
- Make TextFieldValue.composition readonly (aosp/1499610)
- I figured that when composition is "reset" to null (which should happen automatically when text has changed), we do not inform the IME about this fact. This requires us to reset the IME with the new information at hand.
- [Optional] provide mechanism to prevent users creating a new TextFieldValue in onValueChange forgetting to set selection, composition. One of the ideas here was to have TextRange.Unspecified that is the default value for selection and composition. This way we can understand the intention of the developer, if they wanted to reset those fields or if they did not change them. This is in order to prevent cases such as
b/171860947
si...@google.com <si...@google.com> #4
Nona's comment on naming of the clearComposition:
"commitComposition/cancelComposition" is better than "clearComposition" it is not clear.
I will change the TextFieldValue.clearComposition as TextFieldValue.commitComposition.
Nona also mentioned that cancelComposition would be the version where the composed text is removed and composition range is cleared (which is the naming in EditorBuffer
). I will add it when requested.
ap...@google.com <ap...@google.com> #5
Branch: androidx-master-dev
commit 5520c565b94ed4735ae3f6ed52961e60b8df79cc
Author: Siyamed Sinir <siyamed@google.com>
Date: Sun Nov 15 21:48:58 2020
Make TextFieldValue.composition readonly
- Maked TextFieldValue.composition readonly
- Removed the exception for invalid selection range, and instead
constrains this value. The exception thrown for invalid ranges
created issues for developers while creating a new copy of
TextFieldValue
- Made the three argument constructor internal so that composition
can be set by the original owner of the object, which is
EditProcessor.
- Changed the way that String overloads remembers the previous
selection/composition since now composition cannot be set by those.
- Removed `data class` from TextFieldValue in order to support above
use cases, adds auto generated equals/hashCode methods.
- Added TextFieldValue.commitComposition in order to clear the
composition range in TextFieldValue.
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:connectedAndroidTest
Test: ./gradlew compose:foundation:foundation:test
Test: ./gradlew compose:foundation:foundation:connectedAndroidTest
Test: ./gradlew compose:material:material:test
Test: ./gradlew compose:material:material:connectedAndroidTest
RelNote: "Updated TextFielValue API
- made TextFieldValue.composition readonly
- removed exception thrown for invalid selection range"
Bug: 172239032
Change-Id: I4a67592c05ab384ad5614cccf50ad6e79be52b55
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeVariousInputField.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldOnValueChangeTextFieldValueTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/TextFieldValue.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/TextFieldValueTest.kt
ap...@google.com <ap...@google.com> #6
Branch: androidx-master-dev
commit fe038a6d89484699e921a2a546e5d15e976fb9cf
Author: Siyamed Sinir <siyamed@google.com>
Date: Sun Nov 15 21:48:58 2020
Reset input when composition or text changes
When the text or composition changes by the application
IME needs to be informed about this fact. Otherwise
IME thinks that their data is correct and in synch. An easy
culprit for this issue is: if onValueChange always rejects the
given input, keyboard still shows/updates suggestions thinking
that the data that was previously sent is visible to user.
When the IME is not informed what is happening, also the duplicate
text issues occurs since IME still thinks that the composition
range is correct, and that is what the user sees.
This CL changes the EditProcessor behavior to compare the previously
suggested state to the new state it gets. If
- the text is different
- the composition is different
It resets the input.
Test: Added new tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:connectedAndroidTest
Test: ./gradlew compose:ui:ui:test
Test: ./gradlew compose:ui:ui:connectedAndroidTest
Test: ./gradlew compose:foundation:foundation:test
Test: ./gradlew compose:foundation:foundation:connectedAndroidTest
RelNote: Added resetInput parameter to TextInputService#onStateUpdated
Bug: 172239032
Bug: 171860947
Change-Id: I3e8f5404553921bd94ae424d2840ca5595b6f90b
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextFieldValueDemo.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldTest.kt
M compose/integration-tests/src/main/java/androidx/ui/integration/test/core/text/TextFieldToggleTextTestCase.kt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/EditProcessor.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/TextFieldValue.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/TextInputService.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextInputServiceTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/EditProcessorTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/RecordingInputConnection.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/TextInputServiceAndroid.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopPlatformInput.kt
A compose/ui/ui/src/test/kotlin/androidx/compose/ui/input/TextInputServiceAndroidOnStateUpdateTest.kt
ap...@google.com <ap...@google.com> #7
Branch: androidx-master-dev
commit d320f0fc8de7e207c27bc475da32f252421fe526
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Nov 19 19:32:16 2020
Fix EditProcessor selection update
We passed selection.start and end, where as we should have
passed selection.min and max since Editing buffer expects
correct ordering.
Bug: 173728118
Bug: 172239032
Bug: 171860947
Test: ./gradlew compose:ui:ui-text:test
Change-Id: If1c04102da5da59cecd127f0d8759b46b153e086
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/EditProcessor.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/EditProcessorTest.kt
ap...@google.com <ap...@google.com> #8
Branch: androidx-master-dev
commit 663ecc0e55e3b1ca5b8a4391215a5ae074fd1197
Author: Siyamed Sinir <siyamed@google.com>
Date: Mon Nov 16 22:51:52 2020
Cleanup TextFieldValue usage
This CLs removes the TextFieldValue usage if it is not
required, and replaces with string versions.
Test: Treehugger
Test: Ran the demo app and checked some screens
Test: ./gradlew compose:foundation:foundation:test
Test: ./gradlew compose:foundation:foundation:connectedAndroidTest
Test: ./gradlew compose:material:material:test
Test: ./gradlew compose:material:material:connectedAndroidTest
Bug: 172239032
Change-Id: Ifa2b14d53be4259e45a6bfd7506712111354d1a5
M compose/androidview/androidview/integration-tests/androidview-demos/src/main/java/androidx/compose/androidview/demos/FocusInteropAndroidInCompose.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeInputField.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeInputFieldFocusTransition.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeInputFieldMinMaxLines.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeInputFieldTrickyUseCase.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeVariousInputField.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TailFollowingTextField.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextFieldWIthScroller.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/SoftwareKeyboardTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldCursorTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldDefaultWidthTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldFocusTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldTest.kt
M compose/integration-tests/demos/src/main/java/androidx/compose/integration/demos/DemoApp.kt
M compose/integration-tests/demos/src/main/java/androidx/compose/integration/demos/DemoFilter.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/OutlinedTextFieldTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldTest.kt
M compose/runtime/runtime/samples/src/main/java/androidx/compose/runtime/samples/ModelSamples.kt
M compose/runtime/runtime/samples/src/main/java/androidx/compose/runtime/samples/MutableStateListSamples.kt
M compose/runtime/runtime/samples/src/main/java/androidx/compose/runtime/samples/MutableStateMapSample.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/TextActionsTest.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/PopupDemo.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/autofill/ExplicitAutofillTypesDemo.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AccessibilityIteratorsTest.kt
M navigation/navigation-compose/integration-tests/navigation-demos/src/main/java/androidx/navigation/compose/demos/NavByDeepLinkDemo.kt
M navigation/navigation-compose/integration-tests/navigation-demos/src/main/java/androidx/navigation/compose/demos/NavSingleTopDemo.kt
M navigation/navigation-compose/integration-tests/navigation-demos/src/main/java/androidx/navigation/compose/demos/NavWithArgsDemo.kt
ap...@google.com <ap...@google.com> #9
Branch: androidx-master-dev
commit 7077c279c44c31eee08cd0db86e63df1d118ab36
Author: Siyamed Sinir <siyamed@google.com>
Date: Fri Nov 20 11:53:59 2020
Prevent extra recomposition in TextField String overload
Test: Ran the TextToggleBenchmark and TextFieldToggleBenchmark
Bug: 172239032
Bug: 173795358
Change-Id: I61a3e343cc4696fe0f74b6f8f96c1d9a360f1daa
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicTextField.kt
M compose/integration-tests/benchmark/src/androidTest/java/androidx/compose/ui/TextFieldToggleTextBenchmark.kt
M compose/integration-tests/src/main/java/androidx/ui/integration/test/core/text/TextFieldToggleTextTestCase.kt
M compose/integration-tests/src/main/java/androidx/ui/integration/test/core/text/TextToggleTextTestCase.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
ap...@google.com <ap...@google.com> #10
Branch: androidx-master-dev
commit 59dcdf10d45c422addfb863a0d98c27a782145da
Author: Siyamed Sinir <siyamed@google.com>
Date: Fri Nov 20 14:55:42 2020
Fix selection not being updated in edit processor
Cursor position and composition clear was being applied
to EditProcessor and therefore we could not know about the
state that came from IME vs internal state changes.
Moved blur and cursor positioning to be an update on the
existing last known TextFieldValue instead of applying
changes to buffer.
Test: ./gradlew compose:foundation:foundation:test
Test: ./gradlew compose:foundation:foundation:connectedAndroidTest
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:connectedAndroidTest
Test: Manual test in the demo app
Bug: 172239032
Change-Id: I7c7763ace19b754bad27e1649c2504869b32aef9
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextFieldDelegateTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/EditProcessor.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/EditProcessorTest.kt
tc...@google.com <tc...@google.com> #11
si...@google.com <si...@google.com>
na...@gmail.com <na...@gmail.com> #12
Could you please elaborate on how this was fixed? I am still experiencing an issue related to this (160257648) in Compose beta09.
si...@google.com <si...@google.com> #13
Some work was done here.
The issue that initiated this ticket
Description
- is very verbose
- the constraints that composition, selection and text have to be returned at once (~atomically) creates challenges for developers
- assumes that the new value will immediately be provided and this does not work for cases such as
We previously talked that a state object similar to Scoll(er) might be better.