Fixed
Status Update
Comments
si...@google.com <si...@google.com>
si...@google.com <si...@google.com> #2
Could you let me know how to run these benchmarks before CL submission? I think I should run them to improve on this. Thanks!
ha...@google.com <ha...@google.com>
ap...@google.com <ap...@google.com> #3
It is generally quite tricky to run all of them locally and do diffs in between. Unless there are some partciular ones where you already know they might be failing :) So detecting later in CI is WAI.
However the command to run them is:
- lock your cpu clocks
./gradlew lockClocks
- run the benchmarks
./gradlew :compose:integration-tests:benchmark:connectedCheck
^- this will run them all which I would not recommend as it takes lot of time
./gradlew :compose:integration-tests:benchmark:connectedCheck -Pandroid.testInstrumentationRunnerArguments.class=<fully-qualified-class>
^- this will run only a specific class with benchmarks in it
And to get the result, typically just Android Studio -> logcat -> filter "Benchmark" keyword
Description
There is a problem if we dynamically change selectable text. If selection outranges new text — it crashes. Code to reproduce: