ThreadDetector: better handling of annotations on functional interface methods [175001233]

Fixed

Feature Request

Status Update

No update yet.

Description

gh...@google.com

created issue #1

Dec 7, 2020 01:14PM

Here is the original example given on lint-dev:

interface Foo {
  @WorkerThread void call();
}

@MainThread void uiMethod() {}

void testing(Foo foo) {}

void testLambda() {
  testing(() -> {
    uiMethod(); // does not trigger violation (but it should)
  });
}

void testMethodRef() {
  testing(this::uiMethod); // does not trigger violation (but it should)
}

void testAnonymousClass() {
  testing(new Foo() {
    @Override
    public void call() {
      uiMethod(); // triggers violation
    }
  });
}

Comments

gh...@google.com <gh...@google.com> Dec 7, 2020 01:14PM

Accepted by gh...@google.com.

gh...@google.com <gh...@google.com> #2Dec 7, 2020 03:36PM

Marked as fixed.

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

Android build
Which Android build are you using? (e.g. PPP5.180610.010)

We tested this bug on Pixel devices and observed, it says:
"a% with valuetext slider".
Please confirm if you have also observed the same.

Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:

https://developer.android.com/studio/debug/bug-report#bugreportdevice

Screen record of the issue
Please capture screen record or video of the issue using following steps:
adb shell screenrecord /sdcard/video.mp4
Subsequently use following command to pull the recorded file:
adb pull /sdcard/video.mp4
Attach the file to this issue.

Note: Please avoid uploading directly to the issue using attachments. Please upload to google drive and share the folder to android-bugreport@google.com, then share the link here.

Issue 175001233

Description

Issue summary

Comments

gh...@google.com <gh...@google.com> Dec 7, 2020 01:14PM

gh...@google.com <gh...@google.com> #2Dec 7, 2020 03:36PM

Add comment

Issue metadata