NullPointerException on Leanback GridLayoutMAnager [177338150]

Duplicate

of 292114537

Bug

Status Update

No update yet.

Description

jo...@alticelabs.com

created issue #1

Jan 13, 2021 03:54PM

Component used: androidx.leanback:leanback Version used: 1.1.0-beta01 Devices/Android versions reproduced on: Multiple Devices with at least AndroidTv version 9 and 10. (Our app only supports this two versions)

Got at least 2 similar NullPointerException crashes registered on crashlytics, that seem to be originated on the lenaback GridlayoutManager getEdge function not checking for null values.

        public int getEdge(int index) {
            View v = findViewByPosition(index - mPositionDeltaInPreLayout);
            return (mFlag & PF_REVERSE_FLOW_PRIMARY) != 0 ? getViewMax(v) : getViewMin(v);
        }

I haven't found an consistent way to replicate the crash, but it seems to happen when scrolling through the lists.

I leave here part of the stack trace registered on crashlytics:

Crash #1:

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.ViewGroup$LayoutParams android.view.View.getLayoutParams()' on a null object reference
       at androidx.recyclerview.widget.OrientationHelper$1.getDecoratedStart(OrientationHelper.java:305)
       at androidx.leanback.widget.GridLayoutManager.getViewMin(GridLayoutManager.java:1165)
       at androidx.leanback.widget.GridLayoutManager$2.getEdge(GridLayoutManager.java:1749)
       at androidx.leanback.widget.SingleRow.findRowMin(SingleRow.java:181)
       at androidx.leanback.widget.Grid.findRowMin(Grid.java:289)
       at androidx.leanback.widget.GridLayoutManager.updateScrollLimits(GridLayoutManager.java:2578)
       at androidx.leanback.widget.GridLayoutManager$2.addItem(GridLayoutManager.java:1722)
       at androidx.leanback.widget.SingleRow.appendVisibleItems(SingleRow.java:126)
       at androidx.leanback.widget.Grid.appendOneColumnVisibleItems(Grid.java:389)
       at androidx.leanback.widget.GridLayoutManager.appendOneColumnVisibleItems(GridLayoutManager.java:1856)
       at androidx.leanback.widget.GridLayoutManager.onLayoutChildren(GridLayoutManager.java:2286)
       at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:4134)
       at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:3851)
       at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4404)
       at android.view.View.layout(View.java:21934)
       at android.view.ViewGroup.layout(ViewGroup.java:6260)
       at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)
       at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)
       at android.widget.LinearLayout.onLayout(LinearLayout.java:1582)
       at android.view.View.layout(View.java:21934)
       at android.view.ViewGroup.layout(ViewGroup.java:6260)
       at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)
       at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)
       at android.widget.LinearLayout.onLayout(LinearLayout.java:1582)
       at android.view.View.layout(View.java:21934)
       at android.view.ViewGroup.layout(ViewGroup.java:6260)
       at androidx.recyclerview.widget.RecyclerView$LayoutManager.layoutDecoratedWithMargins(RecyclerView.java:9587)
       at androidx.leanback.widget.GridLayoutManager.layoutChild(GridLayoutManager.java:1793)
       at androidx.leanback.widget.GridLayoutManager.fastRelayout(GridLayoutManager.java:2012)
       at androidx.leanback.widget.GridLayoutManager.onLayoutChildren(GridLayoutManager.java:2270)
       at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:4134)
       at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:3851)
       at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4404)
       at android.view.View.layout(View.java:21934)
       at android.view.ViewGroup.layout(ViewGroup.java:6260)
       at androidx.leanback.widget.ScaleFrameLayout.onLayout(ScaleFrameLayout.java:173)
       at android.view.View.layout(View.java:21934)
       at android.view.ViewGroup.layout(ViewGroup.java:6260)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
       at android.view.View.layout(View.java:21934)
       at android.view.ViewGroup.layout(ViewGroup.java:6260)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
       at android.view.View.layout(View.java:21934)
       at android.view.ViewGroup.layout(ViewGroup.java:6260)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
       at android.view.View.layout(View.java:21934)
       at android.view.ViewGroup.layout(ViewGroup.java:6260)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
       at android.view.View.layout(View.java:21934)
       at android.view.ViewGroup.layout(ViewGroup.java:6260)
       at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)
       at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)
       at android.widget.LinearLayout.onLayout(LinearLayout.java:1582)
       at android.view.View.layout(View.java:21934)
       at android.view.ViewGroup.layout(ViewGroup.java:6260)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
       at com.android.internal.policy.DecorView.onLayout(DecorView.java:779)
       at android.view.View.layout(View.java:21934)
       at android.view.ViewGroup.layout(ViewGroup.java:6260)
       at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:3080)
       at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2590)
       at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1721)
       at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7598)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:966)
       at android.view.Choreographer.doCallbacks(Choreographer.java:790)
       at android.view.Choreographer.doFrame(Choreographer.java:725)
       at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:951)
       at android.os.Handler.handleCallback(Handler.java:883)
       at android.os.Handler.dispatchMessage(Handler.java:100)
       at android.os.Looper.loop(Looper.java:214)
       at android.app.ActivityThread.main(ActivityThread.java:7356)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)
``

Crash #2
Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.ViewGroup$LayoutParams android.view.View.getLayoutParams()' on a null object reference
       at androidx.recyclerview.widget.OrientationHelper$1.getDecoratedStart(OrientationHelper.java:305)
       at androidx.leanback.widget.GridLayoutManager.getViewMin(GridLayoutManager.java:1165)
       at androidx.leanback.widget.GridLayoutManager$2.getEdge(GridLayoutManager.java:1749)
       at androidx.leanback.widget.Grid.removeInvisibleItemsAtEnd(Grid.java:416)
       at androidx.leanback.widget.GridLayoutManager.removeInvisibleViewsAtEnd(GridLayoutManager.java:1843)
       at androidx.leanback.widget.GridLayoutManager.scrollDirectionPrimary(GridLayoutManager.java:2474)
       at androidx.leanback.widget.GridLayoutManager.scrollHorizontallyBy(GridLayoutManager.java:2397)
       at androidx.recyclerview.widget.RecyclerView.scrollStep(RecyclerView.java:1838)
       at androidx.recyclerview.widget.RecyclerView$ViewFlinger.run(RecyclerView.java:5302)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:966)
       at android.view.Choreographer.doCallbacks(Choreographer.java:790)
       at android.view.Choreographer.doFrame(Choreographer.java:721)
       at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:951)
       at android.os.Handler.handleCallback(Handler.java:883)
       at android.os.Handler.dispatchMessage(Handler.java:100)
       at android.os.Looper.loop(Looper.java:214)
       at android.app.ActivityThread.main(ActivityThread.java:7356)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

Comments

an...@disney.com <an...@disney.com> #2May 28, 2021 05:29PM

We are seeing crash #2 as well in our Android TV and Fire TV applications. We are using the androidx.leanback:leanback:1.0.0 version.

p4...@gmail.com <p4...@gmail.com> #3Aug 9, 2021 03:13AM

we also find this crash, with androidx.leanback:leanback:1.0.0 and 'androidx.leanback:leanback:1.1.0-rc01'
it happens random and we can't reproduce crash and it also happen with particular device with android 9
Could anyone help?

nc...@gmail.com <nc...@gmail.com> #4Sep 15, 2021 09:45AM

Also the same crash! It's the top crash.

ja...@google.com <ja...@google.com> #5Sep 28, 2021 08:40AM

Reassigned to ja...@google.com.

This issue is being reported by multiple partners - do we have visibility on how widespread it is?

ja...@google.com <ja...@google.com> #6Sep 28, 2021 10:06PM

Reassigned to ja...@google.com.

I looked at Pitot and can't find these errors. In fact errors reported for leanback apps seem to be pretty low.

Pitot link(Google only)

da...@google.com <da...@google.com> #7Sep 28, 2021 10:27PM

There a few reports, but never had a way to reproduce it.

It will be helpful if you can find a reliable way to reproduce and paste a sample app with source code.

da...@google.com <da...@google.com> #8Sep 28, 2021 10:30PM

Also: that if an app is using the wrong way to using recyclerview, for example doing adapter change out of UI thread, or the app is breaking the contract of the adapter.
It can runs into error like this, which is very hard to debug.

an...@disney.com <an...@disney.com> #9Oct 7, 2021 02:25PM

We have never been able to pin down reproducible steps to get the application to crash, but I can tell you that all of the changes made to the adapter are done on the UI thread. Our app has a Fragment that extends the BrowseSupportFragment class that uses LiveData via a ViewModel to update the UI. The app does the following once it receives that data:

It first checks to see if the updated data contains the same number of rows that the base adapter contains
If the number of rows are the same, it then iterates over each row and, using a DiffCallback, updates each row's adapter
If the number of rows are different, it clears the base adapter and simply adds all of the new data to that base adapter

Most of the time, we notice that this crash occurs after the user has navigated back to this Fragment after navigating away for a long period of time. So for example, a user selects an item on the Fragment and that starts up a new Activity that plays video for an hour or so, then navigates back to Fragment.

[Deleted User] <[Deleted User]> #10Oct 29, 2021 09:53AM

any news on this? we are also having a lot of crash with this issue

ja...@google.com <ja...@google.com> Oct 29, 2021 09:56AM

Reassigned to da...@google.com.

jo...@alticelabs.com <jo...@alticelabs.com> #11Dec 30, 2021 09:39AM

Any clues on this? Can we help in anyway? This is the top crash on our app.

nc...@gmail.com <nc...@gmail.com> #12Jan 5, 2022 09:43AM

Same here!

ma...@redge.com <ma...@redge.com> #13Jan 31, 2022 09:58PM

Any news?

da...@google.com <da...@google.com> #14Mar 9, 2022 09:38PM

we are still trying to reproduce it locally in a test for the leanback library, there is no luck yet.

pl...@google.com <pl...@google.com> #15Apr 4, 2022 11:15AM

As the team has so far been unable to reproduce the issue, if you are able to reproduce the issue in a minimal reproducible example, please share with us:

The minimal code for reproducing the issue, and
Detailed steps to reproduce.

ru...@joyn.de <ru...@joyn.de> #16Jun 15, 2022 01:45PM

In our case, the fix was making sure any adapter update triggered made sense and avoided redundant `notifyX` calls.
We were using a combination of `notifyDataSetChanged` and `notifyItemRangeRemoved` in the same frame, which seemed to cause this issue during fast scrolling events.

I was trying to create a sample app to reproduce this problem, but that didn't lead anywhere. Never got the crash there.

To anyone having this issue, please double check your adapter notify calls and make sure you test fast scroll scenarios.

pl...@google.com <pl...@google.com> #17Jun 17, 2022 03:02PM

Thanks for the insights and clarification!

ru...@gmail.com <ru...@gmail.com> #18Nov 6, 2022 02:28AM

To anyone interested, please check this: https://github.com/rubensousa/DpadRecyclerView

di...@gmail.com <di...@gmail.com> #19Nov 24, 2022 06:54PM

https://issuetracker.google.com/issues/177338150#comment18

Can't verify if it really avoids the issue, since can't override. Opened an issue: https://github.com/rubensousa/DpadRecyclerView/issues/13

di...@gmail.com <di...@gmail.com> #20Nov 24, 2022 06:56PM

I can confirm that after

replacing

androidx.leanback:leanback:1.1.0-rc02

with

androidx.leanback:leanback:1.2.0-alpha02

issue disappeared, at least in our app.

di...@gmail.com <di...@gmail.com> #21Nov 28, 2022 07:57AM

Please ignore above, #20.

After some testing, we are still able to reproduce it.

I think the problem is specifically in calling notifyDataSetChanged() rapidly (3-4 times) with a fairly complex rendering, while something else is ON at the main thread, e.g. fast scrolling backwards the list (press and hold DPad UP button) right when these calls are just happening.

We've fixed the issue by:

removing notifyDataSetChanged() at any places where it is not needed
replacing any left notifyDataSetChanged() with notifyItemRangeChanged(0, itemCount)

eu...@gmail.com <eu...@gmail.com> #22Mar 31, 2023 03:11PM

Comment has been deleted.

Message last modified on Mar 31, 2023 03:13PM

eu...@gmail.com <eu...@gmail.com> #23Mar 31, 2023 03:13PM

In my scenario, it happened because of `DefaultItemAnimator` (with `VerticalGridView`)

An example:
0 1 2 -> not visible in the top direction
3 4 5 -> currently visible on the screen
6 7 8 -> not visible to the bottom direction.

on focusing item #8 - data requested.
Attempt to navigate to item #0 before data is received.
During the attempt, data was received and `animateMove`/`animateAdd` has been called which lead to the crash.

`setItemAnimator(null)` OR overriding `DefaultItemAnimator` with disabled ability to animate during scrolling helped in my case.

ru...@gmail.com <ru...@gmail.com> #24Apr 2, 2023 10:11PM

Disabling animations isn't really a fix. For anyone still interested, please check this: https://github.com/rubensousa/DpadRecyclerView The API is now stable

ka...@gmail.com <ka...@gmail.com> #25Apr 12, 2023 04:01PM

when i try to run in signed Build i am getting this error but if it's debug build it's working currently i am using 1.0.0-alpha04 but if i update the version it requires compileSDKVersion 33 but my project compactable with 32 version

FATAL EXCEPTION: main
Process: com.abpnewslive, PID: 2483
java.lang.NullPointerException: Attempt to invoke virtual method 'void androidx.recyclerview.widget.RecyclerView.defaultOnMeasure(int, int)' on a null object reference
at androidx.recyclerview.widget.RecyclerView$LayoutManager.onMeasure(Unknown Source:2)
at androidx.recyclerview.widget.RecyclerView.onMeasure(Unknown Source:30)
at android.view.View.measure(View.java:25466)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6957)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1552)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:842)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:721)
at android.view.View.measure(View.java:25466)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6957)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1552)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:842)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:721)
at android.view.View.measure(View.java:25466)
at android.widget.RelativeLayout.measureChildHorizontal(RelativeLayout.java:735)
at android.widget.RelativeLayout.onMeasure(RelativeLayout.java:481)
at android.view.View.measure(View.java:25466)
at androidx.core.widget.NestedScrollView.measureChildWithMargins(Unknown Source:38)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
at androidx.core.widget.NestedScrollView.onMeasure(Unknown Source:0)
at android.view.View.measure(View.java:25466)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6957)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
at android.view.View.measure(View.java:25466)
at androidx.constraintlayout.widget.ConstraintLayout$Measurer.measure(Unknown Source:539)
at androidx.constraintlayout.solver.widgets.ConstraintWidgetContainer.measure(Unknown Source:271)
at androidx.constraintlayout.solver.widgets.ConstraintWidgetContainer.layout(Unknown Source:137)
at androidx.constraintlayout.solver.widgets.analyzer.BasicMeasure.solveLinearSystem(Unknown Source:29)
at androidx.constraintlayout.solver.widgets.analyzer.BasicMeasure.solverMeasure(Unknown Source:294)
at androidx.constraintlayout.solver.widgets.ConstraintWidgetContainer.measure(Unknown Source:23)
at androidx.constraintlayout.widget.ConstraintLayout.h(:2)
at androidx.constraintlayout.widget.ConstraintLayout.onMeasure(Unknown Source:149)
at android.view.View.measure(View.java:25466)
at androidx.slidingpanelayout.widget.SlidingPaneLayout.onMeasure(Unknown Source:237)
at android.view.View.measure(View.java:25466)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6957)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
at android.view.View.measure(View.java:25466)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6957)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1552)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:842)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:721)
at android.view.View.measure(View.java:25466)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6957)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
at com.android.internal.policy.DecorView.onMeasure(DecorView.java:747)
at android.view.View.measure(View.java:25466)
at android.view.ViewRootImpl.performMeasure(ViewRootImpl.java:3397)
at android.view.ViewRootImpl.measureHierarchy(ViewRootImpl.java:2228)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2486)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1952)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8184)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:972)
at android.view.Choreographer.doCallbacks(Choreographer.java:796)
at android.view.Choreographer.doFrame(Choreographer.java:731)
2023-04-12 06:34:17.945 2483-2483 AndroidRuntime com.abpnewslive E at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:957)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:223)
at android.app.ActivityThread.main(ActivityThread.java:7656)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

da...@google.com <da...@google.com> #26Jul 20, 2023 11:03PM

Status: Duplicate of

292114537

It is root caused in recyclerview library

ja...@google.com <ja...@google.com> #27Oct 9, 2023 04:12PM

Fix should be in here:

https://developer.android.com/jetpack/androidx/releases/leanback#1.2.0-alpha03

da...@google.com <da...@google.com> #28Oct 9, 2023 04:59PM

The fix is not in leanback library,
the fix is in recyclerview, which hasn't released yet.

Please refer to

b/292114537

ru...@joyn.de <ru...@joyn.de> #29Oct 30, 2023 09:05AM

When can we expect a new leanback release with this fix? https://android-review.googlesource.com/2808353 was merged with the RecyclerView update