Fixed
Status Update
Comments
si...@google.com <si...@google.com>
si...@google.com <si...@google.com>
si...@google.com <si...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c5567dc9121066b3f1031d26e7ccc114a3be3d99
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Apr 20 18:01:12 2020
Initial InteractionState / Interaction implementation
Adds Interaction interface, and InteractionState, which allows folding the state from multiple Interactions into one State object.
Also adds InteractionState to Clickable and draggable.
In the future InteractionState will be consumed by ripple / other indications, allowing for indications that handle multiple Interactions, not just press. Additional work includes adding focus support to InteractionState.
Bug: b/152525426
Test: ClickableTest, DraggableTest
Change-Id: Icfe2590a97f5df73e999334b88dd69faa91651b7
Relnote: "Added InteractionState and Interaction, making it easier to build components that react to UI state changes such as press, and drag"
M ui/ui-foundation/api/0.1.0-dev10.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev10.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev10.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/FoundationDemos.kt
A ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/InteractionStateSample.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ClickableTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DraggableTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
A ui/ui-foundation/src/main/java/androidx/ui/foundation/Interaction.kt
A ui/ui-foundation/src/main/java/androidx/ui/foundation/InteractionState.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/gestures/Draggable.kt
D ui/ui-foundation/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
https://android-review.googlesource.com/1271883
Branch: androidx-master-dev
commit c5567dc9121066b3f1031d26e7ccc114a3be3d99
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Apr 20 18:01:12 2020
Initial InteractionState / Interaction implementation
Adds Interaction interface, and InteractionState, which allows folding the state from multiple Interactions into one State object.
Also adds InteractionState to Clickable and draggable.
In the future InteractionState will be consumed by ripple / other indications, allowing for indications that handle multiple Interactions, not just press. Additional work includes adding focus support to InteractionState.
Bug:
Test: ClickableTest, DraggableTest
Change-Id: Icfe2590a97f5df73e999334b88dd69faa91651b7
Relnote: "Added InteractionState and Interaction, making it easier to build components that react to UI state changes such as press, and drag"
M ui/ui-foundation/api/0.1.0-dev10.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev10.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev10.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/FoundationDemos.kt
A ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/InteractionStateSample.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ClickableTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DraggableTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
A ui/ui-foundation/src/main/java/androidx/ui/foundation/Interaction.kt
A ui/ui-foundation/src/main/java/androidx/ui/foundation/InteractionState.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/gestures/Draggable.kt
D ui/ui-foundation/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
Description
Forked from https://buganizer.corp.google.com/issues/175687466#comment3
I wonder if it is better to return an Object to the developer after the result of startInput. This way, we differentiate the currently used service that you can call, stop, updateState etc. Using integer increments for a service that can be used at any time is a little dangerous.