Remote onSurfaceDestroyed onFailure call failed [179800224]

Fixed

Bug

Status Update

No update yet.

Description

el...@gmail.com

created issue #1

Feb 10, 2021 11:25AM

Library version used: 1.0.0-beta.1

Devices/Android versions reproduced on: Galaxy S10e (SM-G9700) / Galaxy M51 (SM-M515F) / Galaxy S9+ (SM-G965F)

Android Auto version reproduced on: 6.0.615334-release

Sample project to trigger the issue.

The issue reported by end users and we see in crashlytics breadcrumbs that it occurs on AndroidAuto Service shutdown.

The issue could be related to https://issuetracker.google.com/u/1/issues/178107274 where CarSurfaceListener could not be set to null during the shutdown.

A bug report.

com.google.android.libraries.car.app.HostException: Remote onSurfaceDestroyed onFailure call failed
        at com.google.android.libraries.car.app.utils.RemoteUtils.zza(RemoteUtils:5)
        at com.google.android.libraries.car.app.utils.RemoteUtils.zza(RemoteUtils:13)
        at com.google.android.libraries.car.app.utils.zzb.run(zzb:8)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:237)
        at android.app.ActivityThread.main(ActivityThread.java:8167)
        at java.lang.reflect.Method.invoke(Method.java:-2)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:496)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1100)

Caused by: java.lang.IllegalStateException: Fragment [62a7b85: com.tomtom.gplaybeta.navapp.nds/com.tomtom.mykonosapp.MykonosCarService] not attached to a context.
        at android.os.Parcel.createException(Parcel.java:2096)
        at android.os.Parcel.readException(Parcel.java:2056)
        at android.os.Parcel.readException(Parcel.java:2004)
        at com.google.android.gms.internal.car_app.zzb.transactAndReadExceptionReturnVoid(zzb:22)
        at com.google.android.libraries.car.app.IOnDoneCallback$Stub$Proxy.onFailure(IOnDoneCallback:9)
        at com.google.android.libraries.car.app.utils.RemoteUtils.zza(RemoteUtils:15)
        at com.google.android.libraries.car.app.utils.zzc.zza(zzc:1)
        at com.google.android.gms.base.R$string.com.google.android.libraries.car.app.utils.RemoteUtils.zza(RemoteUtils:2)
        at com.google.android.libraries.car.app.utils.RemoteUtils.zza(RemoteUtils:13)
        at com.google.android.libraries.car.app.utils.zzb.run(zzb:8)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:237)
        at android.app.ActivityThread.main(ActivityThread.java:8167)
        at java.lang.reflect.Method.invoke(Method.java:-2)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:496)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1100)

Comments

li...@google.com <li...@google.com> #2Feb 10, 2021 05:23PM

Assigned to li...@google.com.

In SystemJobService, it can expect null, and able to tolerance null from WorkManagerImpl.getInstance, due to auto-backup reason.

@Override
public void onCreate() {
super.onCreate();
mWorkManagerImpl = WorkManagerImpl.getInstance(getApplicationContext());
if (mWorkManagerImpl == null) {
// This can occur if...
// 1. The app is performing an auto-backup. Prior to O, JobScheduler could erroneously
// try to send commands to JobService in this state (

b/32180780

). Since neither
// Application#onCreate nor ContentProviders have run, WorkManager won't be
// initialized. In this case, we should ignore all JobScheduler commands and tell it
// to retry.
But, current WorkManagerImpl.getInstance(Context context) implementation is that, it will never return null but throw IllegalStateException.

Isn't there's conflict among these 2 SystemJobService.onCreate logic, and WorkManagerImpl.getInstance logic?

li...@google.com <li...@google.com> #3Feb 12, 2021 10:42PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e14104eb7008f82edd50b37e16bd119b307e0554
Author: Sumir Kataria <sumir@google.com>
Date: Mon Jun 24 10:50:57 2019

Fix for JobScheduler calls when backup is in progress.

The original fix (ag/Ia1604b7c4b98f6b31869e1161a0c1efce7fe46f2) relied
on a null-check, but the new version of WorkManager.getInstance(Context)
with the Context param doesn't return null; it throws an Exception. This
CL updates the three places where we explicitly check for the return value
internally:

1. SystemJobService (the main place where this would manifest)
2. RescheduleReceiver
3. WorkManagerTestInitHelper (for consistency)

Fixes: 135858602
Test: Ran existing tests
Change-Id: Ia232869712d0c78fd80e91d0a863b8c50a080400

M work/workmanager-testing/src/main/java/androidx/work/testing/WorkManagerTestInitHelper.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemalarm/RescheduleReceiver.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java

https://android-review.googlesource.com/988026

https://goto.google.com/android-sha1/e14104eb7008f82edd50b37e16bd119b307e0554

kr...@tomtom.com <kr...@tomtom.com> #4Feb 15, 2021 01:32PM

Thanks you so much for the speedy fixed!

May I know when will it be ready for production? As, currently, this IllegalStateException is impacting our users.

kr...@tomtom.com <kr...@tomtom.com> #5Feb 17, 2021 12:52PM

Hello, please look for this later in the week. If you want to work around this bug specifically and don't need on-demand initialization, you can use the old (deprecated) WorkManager.getInstance() method for now.

li...@google.com <li...@google.com> #6Feb 17, 2021 09:17PM

Hello. Thanks for respond. I surely will keep a pair of eye on the next release :)

Yes. We don't need on-demand initialization. May I know how does using old (deprecated) WorkManager.getInstance() in our app code, able to bypass this problem? Isn't the crash is origin from library internal SystemJobService?

We once thinking to bypass this problem, by switching back to Version 2.0.1 (The version just before WorkManager.getInstance(Context) is introduced). However, we notice Room version is being changed in between. Downgrading WorkManager version, might cause additional SQLite problem.

li...@google.com <li...@google.com> Feb 18, 2021 05:56PM

Accepted by li...@google.com.

kr...@tomtom.com <kr...@tomtom.com> #7Mar 8, 2021 09:19PM

Sorry, you are correct that moving to the deprecated method will not help you here. I would advise waiting for the release later this week. And thank you very much for finding this bug and doing the research to find the underlying issue.

I am curious: do you actually have reports of this bug on Android 9? It should've been fixed in the platform layer at that point. If possible, can you share any Android 9 specific logs/bugreports/stacktraces with device models?

li...@google.com <li...@google.com> #8Mar 10, 2021 12:28AM

Marked as fixed.

OK. Finger crossed users will not leave our app. I will follow the Green Dinosaur in Twitter, to wait for his announcement.

Based on your code comment, I thought this problem shouldn't occur in new Android but it happens some how. This is the log

Asus ZenFone 5 (ZE620KL) (ASUS_X00QD), Android 9 (Happen 2 times)
Asus ZenFone 5Z (ZS620KL/ZS621KL) (ASUS_Z01R_1), Android 9 (Happen 1 time)

3 incidents are having same log trace as below

java.lang.RuntimeException:
at android.app.ActivityThread.handleCreateService (ActivityThread.java:3570)
at android.app.ActivityThread.access$1300 (ActivityThread.java:200)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1672)
at android.os.Handler.dispatchMessage (Handler.java:106)
at android.os.Looper.loop (Looper.java:198)
at android.app.ActivityThread.main (ActivityThread.java:6732)
at java.lang.reflect.Method.invoke (Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:858)
Caused by: java.lang.IllegalStateException:
at androidx.work.impl.WorkManagerImpl.getInstance (WorkManagerImpl.java:142)
at androidx.work.impl.background.systemjob.SystemJobService.onCreate (SystemJobService.java:53)
at android.app.ActivityThread.handleCreateService (ActivityThread.java:3558)
at android.app.ActivityThread.access$1300 (ActivityThread.java:200)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1672)
at android.os.Handler.dispatchMessage (Handler.java:106)
at android.os.Looper.loop (Looper.java:198)
at android.app.ActivityThread.main (ActivityThread.java:6732)
at java.lang.reflect.Method.invoke (Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:858)

I attach the screenshot of Google Play Console as well. (I expect the stack trace should print programmer's message side-by-side with IllegalStateException. But it doesn't)

Feel free to let me know if you need any information from my side. Happy to help.

ap...@google.com <ap...@google.com> #9Mar 10, 2021 12:28AM

Thanks, we'll investigate this internally.