When using Fragment 1.3.0 together with Leanback, GuidedStepSupportFragment will run the wrong transition animation and can crash. [179934757]

Fixed

Bug

Status Update

No update yet.

Description

lc...@gmail.com

created issue #1

Feb 11, 2021 03:38AM

Component used:

Fragment 1.3.0
Leanback 1.1.0-beta01 Devices/Android versions reproduced on: GoogleTV

When using the above components together, there are two problems:

GuidedStepSupportFragment transition (both UI_STYLE_ENTRANCE and UI_STYLE_REPLACE style) doesn't run properly
The App crashed the second time calling GuidedSupportFragment.add.

2021-02-11 12:15:58.811 29784-29784/com.example.guided_step_transition_bug E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.example.guided_step_transition_bug, PID: 29784
    java.lang.IllegalArgumentException: Unique transitionNames are required for all sharedElements
        at androidx.fragment.app.FragmentTransaction.addSharedElement(FragmentTransaction.java:599)
        at androidx.leanback.app.GuidedStepSupportFragment.addNonNullSharedElementTransition(GuidedStepSupportFragment.java:557)
        at androidx.leanback.app.GuidedStepSupportFragment.onAddSharedElementTransition(GuidedStepSupportFragment.java:534)
        at androidx.leanback.app.GuidedStepSupportFragment.add(GuidedStepSupportFragment.java:511)
        at androidx.leanback.app.GuidedStepSupportFragment.add(GuidedStepSupportFragment.java:476)
        at com.example.guided_step_transition_bug.ExampleGuidedStepFragment.onGuidedActionClicked(MainActivity.kt:35)
        at androidx.leanback.app.GuidedStepSupportFragment$2.onGuidedActionClicked(GuidedStepSupportFragment.java:1107)
        at androidx.leanback.widget.GuidedActionAdapter.performOnActionClick(GuidedActionAdapter.java:451)
        at androidx.leanback.widget.GuidedActionAdapter$1.onClick(GuidedActionAdapter.java:130)
        at android.view.View.performClick(View.java:7140)
        at android.view.View.performClickInternal(View.java:7117)
        at android.view.View.onKeyUp(View.java:14165)
        at android.view.KeyEvent.dispatch(KeyEvent.java:2824)
        at android.view.View.dispatchKeyEvent(View.java:13374)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1917)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1922)
        at androidx.leanback.widget.BaseGridView.dispatchKeyEvent(BaseGridView.java:1081)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1922)
        at androidx.leanback.widget.GuidedActionsRelativeLayout.dispatchKeyEvent(GuidedActionsRelativeLayout.java:75)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1922)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1922)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1922)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1922)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1922)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1922)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1922)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1922)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1922)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1922)
        at android.view.ViewGroup.dispatchKeyEvent(ViewGroup.java:1922)
        at com.android.internal.policy.DecorView.superDispatchKeyEvent(DecorView.java:453)
        at com.android.internal.policy.PhoneWindow.superDispatchKeyEvent(PhoneWindow.java:1839)
        at android.app.Activity.dispatchKeyEvent(Activity.java:3968)
        at androidx.core.app.ComponentActivity.superDispatchKeyEvent(ComponentActivity.java:122)
        at androidx.core.view.KeyEventDispatcher.dispatchKeyEvent(KeyEventDispatcher.java:84)
        at androidx.core.app.ComponentActivity.dispatchKeyEvent(ComponentActivity.java:140)
        at androidx.appcompat.app.AppCompatActivity.dispatchKeyEvent(AppCompatActivity.java:535)
        at androidx.appcompat.view.WindowCallbackWrapper.dispatchKeyEvent(WindowCallbackWrapper.java:59)
        at androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.dispatchKeyEvent(AppCompatDelegateImpl.java:2533)
        at com.android.internal.policy.DecorView.dispatchKeyEvent(DecorView.java:367)
        at android.view.ViewRootImpl$ViewPostImeInputStage.processKeyEvent(ViewRootImpl.java:5413)
        at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:5281)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:4788)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:4841)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:4807)
        at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:4947)
        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:4815)
        at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:5004)
2021-02-11 12:15:58.813 29784-29784/com.example.guided_step_transition_bug E/AndroidRuntime:     at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:4788)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:4841)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:4807)
        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:4815)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:4788)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:4841)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:4807)
        at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:4980)
        at android.view.ViewRootImpl$ImeInputStage.onFinishedInputEvent(ViewRootImpl.java:5141)
        at android.view.inputmethod.InputMethodManager$PendingEvent.run(InputMethodManager.java:3064)
        at android.view.inputmethod.InputMethodManager.invokeFinishedInputEventCallback(InputMethodManager.java:2607)
        at android.view.inputmethod.InputMethodManager.finishedInputEvent(InputMethodManager.java:2598)
        at android.view.inputmethod.InputMethodManager$ImeInputEventSender.onInputEventFinished(InputMethodManager.java:3041)
        at android.view.InputEventSender.dispatchInputEventFinished(InputEventSender.java:143)
        at android.os.MessageQueue.nativePollOnce(Native Method)
        at android.os.MessageQueue.next(MessageQueue.java:336)
        at android.os.Looper.loop(Looper.java:174)
        at android.app.ActivityThread.main(ActivityThread.java:7356)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

When using Fragment 1.2.5, there is no problem.

Sample project attached.

fragment_1_3_transition_bug.tar.gz

4.2 MB

Download

Comments

il...@google.com <il...@google.com> Feb 12, 2021 07:44PM

Assigned to da...@google.com.

da...@google.com <da...@google.com> #2Feb 17, 2021 07:19PM

Reassigned to il...@google.com.

We'll track fixing specifically DialogFragment in this issue.

il...@google.com <il...@google.com> Feb 17, 2021 07:27PM

Reassigned to jb...@google.com.

da...@google.com <da...@google.com> #3Feb 17, 2021 07:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit 75ee4a9efb5e1f8ff1b1dfca5bfeb151a7605f54
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Feb 22 15:44:08 2021

Set ViewTree owners for dialogs in DialogFragment

While Fragments with a view set their ViewTree owners automatically,
since DialogFragments do not always have a view (as in the case of only
using onCreateDialog), it is possible to have a DialogFragment but no
ViewTree owners set.

We should set the ViewTree owners on the DialogFragment dialog's decor
view. This way it can be accessed.

RelNote: "Dialogs within a DialogFragment can now get access to ViewTree
owners through their DecorView"
Test: testDialogFragmentViewTree
Bug: 180691023

Change-Id: Ib92905306e16dcaee63c985f22b5e36b6718dd39

A fragment/fragment/src/androidTest/java/androidx/fragment/app/DialogFragmentViewTreeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java

https://android-review.googlesource.com/1600577

MainActivity.kt

4.9 KB

Download

fragment_1_3_0_with_workaround.webm

474 KB

Download

fragment_1_2_5.webm

545 KB

Download

da...@google.com <da...@google.com> #4Feb 17, 2021 08:42PM

This has been fixed internally and will be released as part of the Fragment 1.3.1 version.

You can verify this by following the snapshot instructions with build id 7166224 and switching your fragment dependency to 1.4.0-SNAPSHOT.

jb...@google.com <jb...@google.com> #5Mar 4, 2021 04:55AM

With this bug essentially meaning that DialogFragments cannot be used with Compose, would it be possible to please backport this fix into the Fragment 1.3.0 version?

jb...@google.com <jb...@google.com> Mar 4, 2021 06:08PM

Reassigned to da...@google.com.

da...@google.com <da...@google.com> #6Mar 4, 2021 06:32PM

Reassigned to jb...@google.com.

Re #5 - as per comment#4, this will be made available in Fragment 1.3.1.

da...@google.com <da...@google.com> #7Mar 4, 2021 06:38PM

Reassigned to da...@google.com.

I will do some more investigation.

jb...@google.com <jb...@google.com> #8Mar 5, 2021 12:39AM

Reassigned to jb...@google.com.

We are going to address the issue with clearing the transition names that is causing the crash.

The transitions themselves are working as intended. The old system would only look at named views, not the children at all when targeting the shared element transition. We now look at the entire view hierarchy so children are transitioned properly.

ap...@google.com <ap...@google.com> #9Mar 8, 2021 05:04PM

Project: platform/frameworks/support
Branch: androidx-main

commit ae6aff9326ce2b4f25731635230f600be18a3ba6
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Mar 04 15:28:27 2021

Ensure Fragments do not clear view transitionNames

When transitioning views are nested within ViewGroups that have
transitionNames but are not transitioning groups, the views are captured
as sharedElement views multiple times within the DefaultSpecialEffects
controller. As a result of this, as we collect and clear the transition
names, we capture a null name and end up restoring the null name to the
view once the shared element transition has finished.

We should only capture each shared element view once and therefore we
only restore it once, with the proper transition name.

RelNote: "Views within in a shared element hierarchy will no longer have
their transition name cleared when doing a shared element transition."
Test: testNestedSharedElementView
Bug: 179934757

Change-Id: I4d4a6d7770d5c6d54e4c647559d5cabae71f0051

A fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentSharedElementTransitionTest.kt
A fragment/fragment/src/androidTest/res/layout/nested_transition_groups.xml
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java

https://android-review.googlesource.com/1620026

jb...@google.com <jb...@google.com> #10Mar 10, 2021 08:52PM

Marked as fixed.

This has been fixed internally and will be available in the next version of Fragments.

da...@google.com <da...@google.com> #11Mar 10, 2021 09:32PM

Thanks Jeremy!

Issue 179934757

Description

Issue summary

Comments

il...@google.com <il...@google.com> Feb 12, 2021 07:44PM

da...@google.com <da...@google.com> #2Feb 17, 2021 07:19PM

il...@google.com <il...@google.com> Feb 17, 2021 07:27PM

da...@google.com <da...@google.com> #3Feb 17, 2021 07:47PM

da...@google.com <da...@google.com> #4Feb 17, 2021 08:42PM

jb...@google.com <jb...@google.com> #5Mar 4, 2021 04:55AM

jb...@google.com <jb...@google.com> Mar 4, 2021 06:08PM

da...@google.com <da...@google.com> #6Mar 4, 2021 06:32PM

da...@google.com <da...@google.com> #7Mar 4, 2021 06:38PM

jb...@google.com <jb...@google.com> #8Mar 5, 2021 12:39AM

ap...@google.com <ap...@google.com> #9Mar 8, 2021 05:04PM

jb...@google.com <jb...@google.com> #10Mar 10, 2021 08:52PM

da...@google.com <da...@google.com> #11Mar 10, 2021 09:32PM

Add comment

Issue metadata