Status Update
Comments
yi...@google.com <yi...@google.com> #2
so...@google.com <so...@google.com> #3
see
cl...@google.com <cl...@google.com> #4
Can you please check if this task can be finished before June, and if not remove `Jetpack Compose Major Release (May 2020)` hotlist?
(apologies if this is a double comment)
Thank you
ma...@google.com <ma...@google.com> #5
Please ignore last comment related to the June release. It was caused by a mistake in the query I used. Thank you.
ma...@google.com <ma...@google.com> #6
further postponing to category 3, since it doesn't look like we can accomplish this one. If time allows one of us will pick it up during category 2.
yi...@google.com <yi...@google.com> #7
out of curiousity… if this isnt immediately planned, have you considered changing he default colors at all? a couple things i noticed:
(1) i could see the choice of purple + blue clashing with a number of existing apps, and maybe there are some better defaults that could be used to at least make the colors stand out less.
(2) the defaults don’t support dark mode very well. in our app, the dark purple handles on top of a primary dark mode background has only a 2.14:1 color contrast ratio (whereas in light mode the contrast is 8.98:1)
ap...@google.com <ap...@google.com> #8
I agree with
Siyamed, if you / your team does not have time to look at this, feel free to assign to me - happy to take this over. As well as allowing changing the color, MaterialTheme
should also be configured to set a color from the theme by default so that it is correct out of the box for typicaly use cases.
Description
We have a
selectableGroup
modifier for non-lazy lists which iterates through all the 'selectable' nodes to get the indices and number of elements (to setCollectionInfo
andCollectionItemInfo
). Obviously, this does not play well with lazy lists as it only reports the number of visible elements.We need to figure out what it the right approach/API for lazy lists.