Status Update
No update yet.
Comments
ad...@google.com
ad...@google.com
Connie, do you think we can just remove it? And recommend ModalBottomSheet or BottomSheetScaffold instead?
ad...@google.com
22...@gmail.com
I think it's worth noting in M2 that ModalBottomSheet is a layout while bottomdrawer functions more as a truly modal object, even though it does not have perfect dialog-like functionality. For the usecase recommended (bottom app bar menus), BottomDrawer seems like a better fit than ModalBottomSheetLayout. However in M3 it makes sense to explicitly use ModalBottomSheet once implemented.
Wdyt Matvei?
22...@gmail.com
I think it's worth noting in M2 that ModalBottomSheet is a layout while bottomdrawer functions more as a truly modal object
Could you comment on that? What's the actual difference in the behaviour?
pe...@gmail.com
Bottom Drawer is an atomic component that can be placed on top of content on the screen while ModalBottomSheet is a layout that wraps around all the screen content and places accordingly. BottomDrawer is much more of a splashable component in M2 and asking users to migrate BottomDrawer uses may be cumbersome.
rg...@google.com
Ok, sounds good. I'm happy to keep it if you think it brings value to m2 users.
If we are not removing it, we need to make it stable in this case.
pe...@gmail.com
Found some outstanding bugs I will look into before deciding to promote, especially the swipeable migrations which will likely update the API
rg...@google.com
Given the planned work to migrate the swipeable logic of bottomdrawer, this API should remain experimental. Closing for now.
zy...@gmail.com
If these are still experimental, please keep this bug open and just target the next release
zy...@gmail.com
Where can i find the respective hotlist for the next release?
Description
* Are you an Android developer?" Y
* Which Android Developer Preview build are you using? adt3-user-spp1.210122.020.a3-factory-028c5269.zip
* Is this a regression from Android 11 to 12? N
* What device are you using? ADT-3
* What are the steps to reproduce the problem? (Please provide the minimal reproducible test case.)
(1) Current ADT-3 version : ADT-3/adt3/adt3:11/RTT1.200909.003.A2/6832896:user/release-keys
In Settings->Developer options, Enable OEM unlocking.
(2) Download and Unzip Developer-Preview images from
: adt3-user-spp1.210122.020.a3-factory-028c5269.zip
(3) WIth fastboot connected, run flash-all.sh. Flashing failed on following step.
fastboot flashing unlock
FAILED (remote: 'unlock_ability is 0, can not unlock')
* Issue Category : Framework (platform) - Flashing
* What was the expected result?
Fastboot unlock works, then ADT-3 be flashed successfully.
* Can you provide the API document where this expected behavior is explained?
* What was the actual result?
Even if OEM-unlocking is enabled on Settings->Develop options,
fastboot cannot unlock bootloader (refer to following commands)
$ fastboot flashing get_unlock_ability
(bootloader) get_unlock_ability: 0
Please cross-check the flashing procedure with ADT-3 version RTT1.200909.003.A2/6832896.