IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit ed90c9a382eb2afe65b62765519e6256edc76195
Author: Siyamed Sinir <siyamed@google.com>
Date:   Thu Apr 15 11:12:47 2021

    Add ParagraphStyle/SpanStyle Saver
   
    Preparation for TextFieldValue/AnnotatedString Savers.
    - After a concern about dependencies collected all
      savers to the same file un ui-text.
    - We want to make those savers public, however since
      the module of those Savers requires discussion,
      will move the Savers in another CL.
   
    RelNote: "Added TextUnit constructor function
     TextUnit(value: Float, type: TextUnitType)"
   
    Test: Added tests
    Test: ./gradlew compose:ui:ui-text:test
    Test: ./gradlew compose:ui:ui-text:cAT
   
    Bug: 178446304
    Change-Id: I7eccedda948c374d0cab1e883a56294aa9007b68

M       compose/ui/ui-text/api/1.0.0-beta06.txt
M       compose/ui/ui-text/api/current.txt
M       compose/ui/ui-text/api/public_plus_experimental_1.0.0-beta06.txt
M       compose/ui/ui-text/api/public_plus_experimental_current.txt
M       compose/ui/ui-text/api/restricted_1.0.0-beta06.txt
M       compose/ui/ui-text/api/restricted_current.txt
A       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
A       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M       compose/ui/ui-unit/api/public_plus_experimental_1.0.0-beta06.txt
M       compose/ui/ui-unit/api/public_plus_experimental_current.txt
M       compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/TextUnit.kt

https://android-review.googlesource.com/1675372

Project: platform/frameworks/support
Branch: androidx-main

commit 3e6425cb44d32cd39f9bc7e1daacd78dfaa56552
Author: Siyamed Sinir <siyamed@google.com>
Date:   Fri Apr 16 23:52:31 2021

    Add LocaleList.Saver
   
    Test: Added tests
    Test: ./gradlew compose:ui:ui-text:test
    Test: ./gradlew compose:ui:ui-text:cAT
   
    Bug: 178446304
    Change-Id: I24412b7f8e19191e2450c7241e256fd0fa47e9f7

M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
M       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/TextFieldValueTest.kt

https://android-review.googlesource.com/1678467

Project: platform/frameworks/support
Branch: androidx-main

commit 9d7ad4e2c349f6c47555b15f7789068361b5006c
Author: Siyamed Sinir <siyamed@google.com>
Date:   Fri Apr 16 20:39:10 2021

    Add AnnotatedString Saver
   
    - Added AnnotatedString Saver
    - Added TextRange.Saver
    - changed TextFieldValue.Saver to use
      AnnotatedStringSaver and TextRange.Saver
    - Added missing API
      AnnotatedString.Builder.addTtsAnnotation
    - Added missing API
      AnnotatedString.Builder.withAnnotation for
      String and TtsAnnotation
   
    RelNote: "AnnotatedString save support to
     TextFieldValue.Saver. Added addTtsAnnotation
     and withAnnotation utility functions to
     AnnotatedString.Builder
    "
   
    Test: Added tests
    Test: ./gradlew compose:ui:ui-text:test
    Test: ./gradlew compose:ui:ui-text:cAT
   
    Bug: 178446304
    Change-Id: I8cbdcfcdbe167ff7c68c760aebdd8affe2d8434e

M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M       compose/ui/ui-text/api/public_plus_experimental_1.0.0-beta06.txt
M       compose/ui/ui-text/api/public_plus_experimental_current.txt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/AnnotatedString.kt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TtsAnnotation.kt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/TextFieldValue.kt
M       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/TextFieldValueTest.kt

https://android-review.googlesource.com/1678466

Project: platform/frameworks/support
Branch: androidx-main

commit d0853b60893256b272ed9b3bd444b209de707118
Author: Siyamed Sinir <siyamed@google.com>
Date:   Thu Apr 07 15:32:11 2022

    Line height behavior and vertical alignment
   
    This CL adds LineHeightBehavior to the TextStyle and
    ParagraphStyle. LineHeightBehavior controls whether line height is
    applied to the top of the first line and to the bottom of the last
    line. It also defines the alignment of line in the space provided
    by TextStyle(lineHeight).
   
    go/compose-lineheight-distribution
   
    RelNote: "Added LineHeightBehavior to the TextStyle and
    ParagraphStyle. LineHeightBehavior controls whether line height is
    applied to the top of the first line and to the bottom of the last
    line. It also defines the alignment of line in the space provided
    by TextStyle(lineHeight).
   
    For example it is possible to get a behavior similar to what CSS
    defines via LineHeightBehavior(
    alignment = LineVerticalAlignment.Center,
    trimFirstLineTop=false,
    trimLastLineBottom = false).
   
    trimFirstLineTop, trimLastLineBottom configurations works correctly
    only when includeFontPadding is false."
   
    Test: Added demo
    Test: Added tests
    Test: ./gradlew text:text:test
    Test: ./gradlew text:text:cAT
    Test: ./gradlew compose:ui:ui-text:test
    Test: ./gradlew compose:ui:ui-text:cAT
    Test: ./gradlew compose:foundation:foundation:test
    Test: ./gradlew compose:foundation:foundation:cAT
   
    Bug: 181155707
    Change-Id: I973329a540ca9f5a6e225f1e5aaffeaa1ff9cc61

M       compose/ui/ui-inspection/src/androidTest/java/androidx/compose/ui/inspection/inspector/ParameterFactoryTest.kt
A       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemoMetrics.kt
M       compose/ui/ui-text/api/restricted_current.txt
M       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextStyleLayoutAttributesTest.kt
A       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeLineHeight.kt
A       compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationLineHeightBehaviorTest.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/ParagraphStyle.kt
M       text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.kt
M       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextStyleTest.kt
A       text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightBehaviorSpan.kt
M       text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightSpan.kt
A       text/text/src/androidTest/java/androidx/compose/ui/text/android/style/LineHeightBehaviorSpanTest.kt
A       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/LineHeightBehavior.kt
M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphHelper.android.kt
M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraph.android.kt
M       compose/ui/ui-text/api/public_plus_experimental_current.txt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
A       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/style/LineHeightBehaviorTest.kt
M       compose/ui/ui-text/api/current.txt
M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt
M       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/ParagraphStyleTest.kt

https://android-review.googlesource.com/2058653

Project: platform/frameworks/support
Branch: androidx-main

commit 8f0b7683ecd7e786ba894e0833752ca2c763e5cd
Author: Siyamed Sinir <siyamed@google.com>
Date:   Fri Apr 15 15:07:50 2022

    Make LineHeightBehavior.Default the default
   
    This CL assigns LineHeightBehavior.Default as the default line
    height behavior for includeFontPadding = false case.
   
    Test: Tested on Demo app
    Test: ./gradlew text:text:test
    Test: ./gradlew text:text:cAT
    Test: ./gradlew compose:ui:ui-text:test
    Test: ./gradlew compose:ui:ui-text:cAT
   
    Bug: 181155707
    Change-Id: I265f53c7c2a4dd135722a21f53d795b4361779c6

M       text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightSpan.kt
M       compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/platform/AndroidParagraphTest.kt
M       compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphFillBoundingBoxesTest.kt
M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphHelper.android.kt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/ParagraphStyle.kt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
M       compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationTest.kt
M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt

https://android-review.googlesource.com/2064622

Project: platform/frameworks/support
Branch: androidx-main

commit 4b23d9be8cfe80dcd00d065e9375ba5b58a8d495
Author: Siyamed Sinir <siyamed@google.com>
Date:   Fri Apr 15 19:39:52 2022

    Introduce LineHeightTrim
   
    LineHeightBehavior worked with two booleans conceptually related to
    each other: trimFirstLineTop, trimLastLineBottom
   
    This CL unifies those two boolean values in a single enum named
    LineHeightTrim.
   
    LineHeightTrim have values of 4 states defined by two booleans:
    - FirstLineTop
    - LastLineBottom
    - Both
    - None
   
    RelNote: "trimFirstLineTop, trimLastLineBottom attributes of
    LineHeightBehavior changed into a single enum: LineHeightTrim.
    LineHeightTrim have values of 4 states defined by two booleans:
    FirstLineTop, LastLineBottom, Both and None"
   
    Test: ./gradlew compose:ui:ui-text:test
    Test: ./gradlew compose:ui:ui-text:cAT
   
    Bug: 181155707
    Change-Id: Ifc6a5912eab7a0e41ae6cd4045ea9cbdf3c0a146

M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/LineHeightBehavior.kt
M       compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphFillBoundingBoxesTest.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeLineHeight.kt
M       compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationLineHeightBehaviorTest.kt
M       compose/ui/ui-text/api/public_plus_experimental_current.txt
M       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextStyleTest.kt
M       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/style/LineHeightBehaviorTest.kt
M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt

https://android-review.googlesource.com/2065892

Project: platform/frameworks/support
Branch: androidx-main

commit 5095a557ff762472327d950541786ae9828ad036
Author: Siyamed Sinir <siyamed@google.com>
Date:   Mon Apr 25 15:35:47 2022

    LineHeightBehavior API Review updates
   
    Based on API review, this CL
    - Renames LineHeightBehavior into LineHeightStyle
    - Renames LineVerticalAlignment into LineHeightStyle.Alignment
    - Renames LineHeightTrim into LineHeightStyle.Trim
    - Removes default constructor values from LineHeightStyle
   
    RelNote: "
    - LineHeightBehavior is renamed as LineHeightStyle
    - LineVerticalAlignment is renamed as LineHeightStyle.Alignment
    - Renames LineHeightTrim is renamed as LineHeightStyle.Trim
    - Default constructor values from LineHeightStyle is removed
    "
   
    Test: ./gradlew compose:ui:ui-text:test
    Test: ./gradlew compose:ui:ui-text:cAT
    Test: ./gradlew text:text:test
    Test: ./gradlew text:text:cAT
   
    Bug: 230347691
    Bug: 181155707
    Change-Id: I582bf09152d60b30362b3cce9bd60d57fc488fe7

M       compose/ui/ui-text/api/restricted_current.txt
M       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextStyleLayoutAttributesTest.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeLineHeight.kt
M       compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationLineHeightStyleTest.kt
M       compose/ui/ui-inspection/src/main/java/androidx/compose/ui/inspection/inspector/ParameterFactory.kt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/ParagraphStyle.kt
M       text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.kt
M       text/text/src/androidTest/java/androidx/compose/ui/text/android/TextLayoutTest.kt
M       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextStyleTest.kt
M       text/text/src/androidTest/java/androidx/compose/ui/text/android/style/LineHeightStyleSpanTest.kt
D       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/LineHeightBehavior.kt
M       compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphFillBoundingBoxesTest.kt
M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphHelper.android.kt
A       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/LineHeightStyle.kt
A       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/style/LineHeightStyleTest.kt
M       text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightStyleSpan.kt
M       compose/ui/ui-text/api/public_plus_experimental_current.txt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
D       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/style/LineHeightBehaviorTest.kt
M       compose/ui/ui-text/api/current.txt
M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt
M       compose/ui/ui-text/src/test/java/androidx/compose/ui/text/ParagraphStyleTest.kt

https://android-review.googlesource.com/2075370

Project: platform/frameworks/support
Branch: androidx-main

commit 5ddf42b0308c9c64303dd378baae8b13aa1f5614
Author: Siyamed Sinir <siyamed@google.com>
Date:   Mon Apr 18 11:09:47 2022

    Use LineHeightStyle as default for includeFontPadding=true
   
    LineHeightStyle(Alignment.Proportional, Trim.Both) is the current default for
    includeFontPadding=false.
   
    This CL makes it the default for includeFontPadding=true as well.
   
    The previous behavior includeFontPadding=true should not change since
    it was the same or similar as LineHeightStyle(proportional, trim
    both).
   
    The change required no update in regular tests. Treehugger will
    validate screenshot tests.
   
    Test: ./gradlew compose:ui:ui-text:test
    Test: ./gradlew compose:ui:ui-text:cAT
    Test: ./gradlew text:text:test
    Test: ./gradlew text:text:cAT
   
    Bug: 181155707
    Change-Id: Ib22aaeef41d2b2b6888be7a295524a2baa43c615

M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphHelper.android.kt
M       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt
M       text/text/src/androidTest/java/androidx/compose/ui/text/android/TextLayoutIntrinsicWidthTest.kt
D       text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightSpan.kt
M       text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightStyleSpan.kt

https://android-review.googlesource.com/2066014