Add arguments/deeplink arguments on the navigation element for nested graphs [182545357]

Fixed

Feature Request

Status Update

No update yet.

Description

de...@gmail.com

created issue #1

Mar 13, 2021 02:53AM

In the current navigation-compose version (alpha09), there is no way to add arguments to nested graph declared with the navigation element.

Comments

mu...@gmail.com <mu...@gmail.com> #2May 25, 2021 03:17PM

We have logic to match exact deep links, since you have a path argument maybe this doesn't fall within that case.

But definitely feel free to upload a pull request with tests for this particular test case and we can work it out there.

mu...@gmail.com <mu...@gmail.com> #3Aug 6, 2021 08:19AM

I've created a pull request on GitHub. Can you check it?

I not sure about names picked for test functions.

jb...@google.com <jb...@google.com> Aug 26, 2021 11:47PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #4Sep 2, 2021 11:52PM

When will you have time to review this pull request? This change is important for our project.

jb...@google.com <jb...@google.com> #5Sep 9, 2021 04:39AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 4eea9cb436ba82a6f61ff97a69bbe7c393df0132
Author: Osip Fatkullin <osip.fatkullin@gmail.com>
Date: Thu Apr 15 09:34:16 2021

[GH] [Navigation] Make deep link path arguments to not include slash

## Proposed Changes

Slash is used for URI path splitting. Arguments should not include more than one path section.
I purpose to replace `(.+?)` with `([^/]+?)` in resulting regexp.

## Testing

Added corresponing tests to `NavDestinationAndroidTest`

Test: ./gradlew test connectedCheck

## Issues Fixed

Fixes: [

b/184072811

](

https://issuetracker.google.com/issues/184072811)

This is an imported pull request from

https://github.com/androidx/androidx/pull/153.

Resolves #153
Github-Pr-Head-Sha: f16861bc1f6b0bbba03e752cc378aa795a8522e7
GitOrigin-RevId: 5da0cf583393bce4f68ab11305f1bab3d89f0480
Change-Id: I9f147ead04b611febd2a3214cf8736b5a9afcc65

M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt

https://android-review.googlesource.com/1676867

ap...@google.com <ap...@google.com> #6Sep 27, 2021 05:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit b5d27ff4f0f239583f829487c7bbfd1c8f3c3ec7
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Sep 03 13:27:17 2021

Add a sample for arguments in the nested NavGraph

Added a sample for the recently added navigation API to show how to add
arguments to the nested NavGraph.

Test: ./gradlew bOS
Bug: 182545357
Change-Id: Ied3bcb47005df7f1d5eabf5ec81bd354e42f58a7

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt
M navigation/navigation-compose/samples/src/main/java/androidx/navigation/compose/samples/NavigationSamples.kt

https://android-review.googlesource.com/1818835

Issue 182545357