Status Update
No update yet.
Comments
il...@google.com
[Deleted User] <[Deleted User]>
I see that this issue was assigned. I can create Pull Request if need.
jb...@google.com
Feel free to do so and we will review.
il...@google.com
ca...@gmail.com
I think your PR also fixes our problem: we have links like
.../search/
.../search?documentId=123
.../search?folder=123
And each should be redirected to different navigation destinations. Currently they all redirect to one page, and sometimes crash.
jb...@google.com
Thank you for the PR!
This has been fixed internally and will be available as part of the Navigation 2.4.0-alpha08 release.
da...@gmail.com
Just a quick note. It seems like NavInflater don't set defaultValue when using android:defaultValue="@null" and thus the check will fail. You will have to add the query argument in your Uri : "
br...@gmail.com
I filed an issue RE: #8 ... an @null default value should not be flagged as "required", and should not fail and cause the app to crash.
Description
Component used: Navigation
Version used: 2.3.5
Devices/Android versions reproduced on: Any
Problem
We have deep link:
myapp://example.io/messages/{userId}?message={messageId}&source={source}Where all arguments are required.
And we have a link:
myapp://example.io/messages/anonymous?message=1This link will be caught by the deep link and an app will crash because the required parameter
sourceis missing.Purposed solution
When checking deep link match, check if query parameters are required.
If this solution is right, I can create pull request on GitHub.