IssueTracker

Analyzing dynamic features on their own like that doesn't work properly since even though they "depend" on the app they're actually including into an app so for example the unused resource check only makes sense when you look at it from the app perspective, not the other way around.

I believe in 7.0 we've fixed this in the sense that there isn't a lint task on the individual dynamic features.

+1. In AGP 7.0 there are no lint tasks in dynamic-features; instead, any dynamic-features are analyzed when running lint on the app module. OP, can you try with AGP 7.0.0-rc01, run lintRelease on the corresponding application module, and see if you still hit the same issue?

Not using dynamic feature modules but have this with an application module and a library module, happening on 7.0.0-rc01. I haven't figured out a repro yet but will upload one if I manage.

Re #5, yes, a repro project would be very helpful, thanks!

Closing this bug as not reproducible, but please reopen if you have a repro project.

Here is project that reproduces the issue. Running ./gradlew aDAT creates android test APK with missing classes.

Thanks for investigating and reproducing it so quickly! Let me know if I can help further. I very much want to understand this issue.

Running ./gradlew :lib:outgoingVariants there is

Secondary variants (*)
    - Variant : classes
       - Attributes
          - org.gradle.category                 = library
          - org.gradle.dependency.bundling      = external
          - org.gradle.jvm.version              = 8
          - org.gradle.libraryelements          = classes
          - org.gradle.usage                    = java-runtime
          - org.jetbrains.kotlin.localToProject = public
          - org.jetbrains.kotlin.platform.type  = jvm
       - Artifacts
          - build/classes/java/main (artifactType = java-classes-directory)
          - build/classes/kotlin/main (artifactType = java-classes-directory)

and this results in having ArtifactCollection.getArtifactFiles() return both files, but ArtifactCollection.getArtifacts() returns only 1 artifact. As already mentioned in previous comments, we can probably fix this in SubtractingArtifactCollection in AGP.

The issue is triggered when application consumes kotlin-only module and desugaring is not needed (either using java 7 lang level or deploying to device with API 24+).

Is it expected for ArtifactCollection.getArtifacts() to return only 1 artifact, when there are two? Meaning, is Gradle working as intended?

FWIW, I had a slightly different output from running outgoingVariants

--------------------------------------------------
Variant apiElements
--------------------------------------------------
Description = API elements for main.

Capabilities
    - register.common.rx2-utilities-jvm:testing:unspecified (default capability)
Attributes
    - org.gradle.category                 = library
    - org.gradle.dependency.bundling      = external
    - org.gradle.jvm.version              = 8
    - org.gradle.libraryelements          = jar
    - org.gradle.usage                    = java-api
    - org.jetbrains.kotlin.localToProject = public
    - org.jetbrains.kotlin.platform.type  = jvm

Artifacts
    - build/libs/testing.jar (artifactType = jar)

Secondary variants (*)
    - Variant : classes
       - Attributes
          - org.gradle.category                 = library
          - org.gradle.dependency.bundling      = external
          - org.gradle.jvm.version              = 8
          - org.gradle.libraryelements          = classes
          - org.gradle.usage                    = java-api
          - org.jetbrains.kotlin.localToProject = public
          - org.jetbrains.kotlin.platform.type  = jvm
       - Artifacts
          - build/classes/java/main (artifactType = java-classes-directory)
          - build/classes/kotlin/main (artifactType = java-classes-directory)
          - build/classes/kotlin/main (artifactType = java-classes-directory)

I'm not 100% sure why my build shows three artifacts vs your two, but I suspect it's because my build has two separate packages in the Kotlin source (i.e., more than one Kotlin source file, in different packages), whereas yours only has one Kotlin source file.

I've also filled https://github.com/gradle/gradle/issues/17213, to check if this Gralde behavior is expected.

FYI, we also see this issue in a slightly different context, which results in flaky builds, rather than deterministically-incorrect builds. Here's the module with multiple artifacts:

Secondary variants (*)
    - Variant : classes
       - Attributes                                                                                                                                            - org.gradle.category                 = library
          - org.gradle.dependency.bundling      = external
          - org.gradle.jvm.version              = 8
          - org.gradle.libraryelements          = classes
          - org.gradle.usage                    = java-api
          - org.jetbrains.kotlin.localToProject = public
          - org.jetbrains.kotlin.platform.type  = jvm
       - Artifacts
          - build/classes/java/main (artifactType = java-classes-directory)
          - build/classes/kotlin/main (artifactType = java-classes-directory)
          - build/classes/kotlin/main (artifactType = java-classes-directory)

This module only has Kotlin source, but it also uses Dagger, so there is generated code.

After one first build (./gradlew :path:to:module:assembleDebugAndroidTest), I inspected the resultant test APK:

$ find bad -type f -name "NoopTmn*"
bad/smali_classes2/com/squareup/tmn/NoopTmnTimings_Factory.smali
bad/smali_classes2/com/squareup/tmn/NoopTmnTimings_Factory$InstanceHolder.smali

I know the name is meaningless to you, but it's missing the class NoopTmnTimings.smali.

After re-running that build, I get a different artifact:

$ find new -type f -name "NoopTmn*"
new/smali_classes2/com/squareup/tmn/NoopTmnTimings_Factory.smali
new/smali_classes2/com/squareup/tmn/NoopTmnTimings.smali
new/smali_classes2/com/squareup/tmn/NoopTmnTimings_Factory$InstanceHolder.smali

So, this is flaky. Sometimes I get the expected file, other times I don't.

I can't explain why this is flaky, but we are hopeful that AGP 4.2.2 will also resolve this issue. We suspect/are irrationally worried it's related to the build cache somehow.

This is now fixed in studio-main and also cherry-picked to 4.2 and 7.0 branches.

You can also work around this issue by having your own version of SubtractingArtifactCollection in buildSrc which has this fix - https://cs.android.com/android-studio/platform/tools/base/+/447e6cb62d1520074572fb26c27f3d40e3ee78dd:build-system/gradle-core/src/main/java/com/android/build/gradle/internal/dependency/SubtractingArtifactCollection.kt;dlc=c499ed9775b4b7aa9d9e7942d385ae279065d0de.

Yup, we've already patched it locally :)

steamkar id,sappowt