Marking method as default in interface considered as breaking change [188691010]

Obsolete

Bug

Status Update

No update yet.

Description

se...@google.com

created issue #1

May 19, 2021 08:17PM

Steps to reproduce:

Mark an existent method as default;
run updateApi;
method that was marked as default disappears from existing classes that implement that interface;

For example in ViewModelProvider.Factory mark a method create as default:

@NonNull
default <T extends ViewModel> T create(@NonNull Class<T> modelClass) {
  throw new UnsupportedOperationException();
}

then run ./gradlew :lifec:lifec-view:updateApi

It will fail with:

/Users/sergeyv/android/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/api/2.3.0-beta01.txt:37: error: Removed method androidx.lifecycle.ViewModelProvider.NewInstanceFactory.create(Class<T>) [RemovedMethod]/Users/sergeyv/android/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/api/restricted_2.3.0-beta01.txt:37: error: Removed method androidx.lifecycle.ViewModelProvider.NewInstanceFactory.create(Class<T>) [RemovedMethod]
Aborting: Found compatibility problems checking the public API (/Users/sergeyv/android/androidx-main/out/androidx/lifecycle/lifecycle-viewmodel/build/api/current.txt) against the API in /Users/sergeyv/android/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/api/2.3.0-beta01.txt

Comments

au...@google.com <au...@google.com> #2May 19, 2021 11:36PM

Thank you for your feedback. Team may reach out for more feedback in reproducing or triaging this issue.

au...@google.com <au...@google.com> #3May 19, 2021 11:53PM

Could you try AGP 3.3.0-rc01 or 3.4.0-alpha06 and see if it fixes the issue?

If not, could you provide a sample project (as the error message above is not enough for us to debug the issue)?

se...@google.com <se...@google.com> #4Jun 25, 2021 01:25PM

FYI there's a reddit comment that says this is still a problem in the 3.3 RC:

https://www.reddit.com/r/androiddev/comments/a3qjsn/android_studio_33_release_candidate_2_available/eb8lhs9

au...@google.com <au...@google.com> #5Jul 8, 2021 09:54PM

(Note that the comment mentions using Kotlin as well. And this bug report references "kotterknife" which I'm guessing is Kotlinified butterknife.

au...@google.com <au...@google.com> #6Jul 8, 2021 10:04PM

Status: Won't Fix (Obsolete)

KotterKnife is just using property delegation. Use your first company's
product to find out what it is exactly (i.e. Google search).

On Fri, Dec 7, 2018, 10:19 PM <buganizer-system@google.com> wrote:

- Show quoted text -

ap...@google.com <ap...@google.com> #7Sep 26, 2021 08:30PM

Gradle has improved the error message to indicate exactly what transform has failed (

https://github.com/gradle/gradle/issues/7950).

Their fix is scheduled for Gradle 5.1-rc-01 (not available as of today), but you can grab their latest builds at

https://services.gradle.org/distributions-snapshots/.

Could you update the Gradle wrapper file to use the latest Gradle snapshot (e.g.,

https://services.gradle.org/distributions-snapshots/gradle-5.1-20181210080012+0000-bin.zip) and attach the new stack trace here?

Issue 188691010