Marking method as default in interface considered as breaking change [188691010]

Obsolete

Bug

Status Update

No update yet.

Description

se...@google.com

created issue #1

May 19, 2021 08:17PM

Steps to reproduce:

Mark an existent method as default;
run updateApi;
method that was marked as default disappears from existing classes that implement that interface;

For example in ViewModelProvider.Factory mark a method create as default:

@NonNull
default <T extends ViewModel> T create(@NonNull Class<T> modelClass) {
  throw new UnsupportedOperationException();
}

then run ./gradlew :lifec:lifec-view:updateApi

It will fail with:

/Users/sergeyv/android/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/api/2.3.0-beta01.txt:37: error: Removed method androidx.lifecycle.ViewModelProvider.NewInstanceFactory.create(Class<T>) [RemovedMethod]/Users/sergeyv/android/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/api/restricted_2.3.0-beta01.txt:37: error: Removed method androidx.lifecycle.ViewModelProvider.NewInstanceFactory.create(Class<T>) [RemovedMethod]
Aborting: Found compatibility problems checking the public API (/Users/sergeyv/android/androidx-main/out/androidx/lifecycle/lifecycle-viewmodel/build/api/current.txt) against the API in /Users/sergeyv/android/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/api/2.3.0-beta01.txt

Comments

au...@google.com <au...@google.com> #2May 19, 2021 11:36PM

To use Lifecycle 2.8.0-alpha03, ensure you are using at least Compose UI 1.7.0-alpha05.

The issue is happening because, starting from Lifecycle 2.8.0-alpha03 and Compose UI 1.7.0-alpha05, LocalLifecycleOwner has been moved from androidx.compose.ui to lifecycle-runtime-compose, as outlined in their respective release notes. For compatibility reasons, you must update both dependencies.

For context, note these changes were made to enable the utilization of its Compose-based helper APIs beyond Compose UI (such as in Molecule). Further information can be found at b/328263448.

If the issue persists even after updating your Compose UI, please let us know.

Edit: please see https://issuetracker.google.com/336842920#comment8 for a workaround.

au...@google.com <au...@google.com> #3May 19, 2021 11:53PM

Thanks for your answer.
If this change has made both libraries version dependent, it seems that guide them to the release note so that users will not experience difficulties :)

se...@google.com <se...@google.com> #4Jun 25, 2021 01:25PM

lifecycle 2.8.0 is now stable but compose UI 1.7.0 is still in beta.

au...@google.com <au...@google.com> #5Jul 8, 2021 09:54PM

Same problem here. Lifecycle 2.8.0 is now stable but Compose UI 1.7.0 is still beta. Of course our Dependabot didn't know about this relationship between dependencies 😬

au...@google.com <au...@google.com> #6Jul 8, 2021 10:04PM

Status: Won't Fix (Obsolete)

Something like that really shouldn't happen... 🤦🏻‍♂️

ap...@google.com <ap...@google.com> #7Sep 26, 2021 08:30PM

Thats really really bad. I would always expect the latest stable versions to be compatible. Please add this requirement to the changelog or better add a warning at compile time if used with incompatible combinations.

Issue 188691010