IssueTracker

Artifact used: androidx.navigation:navigation-safe-args-gradle-plugin:2.3.5

Unfortunately the navigation library sometimes seems to produce some unnecessary navigation functions during some builds on some machines. (This is a nightmare to track down... :-/)

This is our project at this commit that exhibits the problem: https://codeberg.org/corona-contact-tracing-germany/cwa-android/src/commit/1918990d0d62094f3de78b71e6aa693070c20f42

So far 2 of the generated nav classes seemed to be problematic (either both or none of them):

./Corona-Warn-App/build/generated/source/navigation-args/device/release/de/rki/coronawarnapp/ui/onboarding/OnboardingDeltaAnalyticsFragmentDirections.kt

and

./Corona-Warn-App/build/generated/source/navigation-args/device/release/de/rki/coronawarnapp/release/NewReleaseInfoFragmentDirections.kt

The nav graph can be found here: https://codeberg.org/corona-contact-tracing-germany/cwa-android/src/commit/1918990d0d62094f3de78b71e6aa693070c20f42/Corona-Warn-App/src/main/res/navigation/nav_graph.xml

In both files these functions are only sometimes generated. I suppose they are not used anywhere. I also believe R8 will correctly discard them... but the final apk still doesn't end up being reproducible because of the embedded pg-map-id which will differ.

    public fun actionSubmissionTestResultPendingFragment(skipInitialTestResultRefresh: Boolean =
        true, testType: CoronaTest.Type): NavDirections =
        NavGraphDirections.actionSubmissionTestResultPendingFragment(skipInitialTestResultRefresh,
        testType)

    public fun actionToSubmissionTestResultAvailableFragment(testType: CoronaTest.Type):
        NavDirections = NavGraphDirections.actionToSubmissionTestResultAvailableFragment(testType)

    public fun actionToSubmissionDeletionWarningFragment(
      isConsentGiven: Boolean = false,
      coronaTestQrCode: CoronaTestQRCode? = null,
      coronaTestTan: CoronaTestTAN? = null
    ): NavDirections = NavGraphDirections.actionToSubmissionDeletionWarningFragment(isConsentGiven,
        coronaTestQrCode, coronaTestTan)

    public fun actionSubmissionConsentFragment(qrCode: String? = null): NavDirections =
        NavGraphDirections.actionSubmissionConsentFragment(qrCode)
  }

I've attached the diffoscope output of comparing the resulting classes2.dex file (with R8 completely disabled).