Fixed
Status Update
Comments
da...@google.com <da...@google.com> #2
Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:
Android build
Which Android build are you using? (e.g. OPP1.170223.012)
Device used
Which device did you use to reproduce this issue?
Steps to reproduce
What steps are needed to reproduce this issue?
Frequency
How frequently does this issue occur? (e.g 100% of the time, 10% of the time)
Expected output
What is the expected output?
Current output
What is the current output?
Screen record of the issue, for clarity
Please capture screen record or video of the issue using following steps:
adb shell screenrecord /sdcard/video.mp4
Subsequently use following command to pull the recorded file:
adb pull /sdcard/video.mp4
Attach the file to this issue.
Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.
Android build
Which Android build are you using? (e.g. OPP1.170223.012)
Device used
Which device did you use to reproduce this issue?
Steps to reproduce
What steps are needed to reproduce this issue?
Frequency
How frequently does this issue occur? (e.g 100% of the time, 10% of the time)
Expected output
What is the expected output?
Current output
What is the current output?
Screen record of the issue, for clarity
Please capture screen record or video of the issue using following steps:
adb shell screenrecord /sdcard/video.mp4
Subsequently use following command to pull the recorded file:
adb pull /sdcard/video.mp4
Attach the file to this issue.
Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.
ap...@google.com <ap...@google.com> #3
Hello;
Android build: Anything between api 23 and 27 (It appears only on biometric compat dialog)
Device used: Emulator api 26
Steps to reproduce: Set a dark theme to the app, but set a light theme to the dialog, or override colors of surface, text, buttons etc. Project I shared above has all, except you need to switch using implementation 'androidx.biometric:biometric:1.0.0-alpha03' instead of local library, which I applied a quick fix.
Frequency: Always
Expected output: fingerprint description and fingerprint subtitle should respect dialog theme instead of ignoring it and using only activity theme.
Current output: fingerprint dialog uses activity theme and results in white text over white background.
Screen record of the issue: I have captured screenshot and it is attached to previous message.
Android build: Anything between api 23 and 27 (It appears only on biometric compat dialog)
Device used: Emulator api 26
Steps to reproduce: Set a dark theme to the app, but set a light theme to the dialog, or override colors of surface, text, buttons etc. Project I shared above has all, except you need to switch using implementation 'androidx.biometric:biometric:1.0.0-alpha03' instead of local library, which I applied a quick fix.
Frequency: Always
Expected output: fingerprint description and fingerprint subtitle should respect dialog theme instead of ignoring it and using only activity theme.
Current output: fingerprint dialog uses activity theme and results in white text over white background.
Screen record of the issue: I have captured screenshot and it is attached to previous message.
el...@google.com <el...@google.com>
ma...@justpinch.com <ma...@justpinch.com> #4
Thank you for the details. We’ve investigated, but have been unable to reproduce it with the steps provided (video attached for reference). If you are able to reproduce the issue again or have additional information to help us (to identify what steps were missing to reproduce the issue), please let us know.
Below is the code snippet used.
dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
implementation 'androidx.appcompat:appcompat:1.1.0-alpha02'
implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
implementation 'com.google.android.material:material:1.1.0-alpha03'
//implementation 'androidx.biometric:biometric:1.0.0-alpha03'
implementation project(':library')
testImplementation 'junit:junit:4.12'
androidTestImplementation 'androidx.test:runner:1.1.1'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.1'
Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.
Below is the code snippet used.
dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
implementation 'androidx.appcompat:appcompat:1.1.0-alpha02'
implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
implementation 'com.google.android.material:material:1.1.0-alpha03'
//implementation 'androidx.biometric:biometric:1.0.0-alpha03'
implementation project(':library')
testImplementation 'junit:junit:4.12'
androidTestImplementation 'androidx.test:runner:1.1.1'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.1'
Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.
da...@google.com <da...@google.com> #5
Hello;
As mentioned previously, you have to uncomment original library
implementation 'androidx.biometric:biometric:1.0.0-alpha03'
and comment out following line as:
// implementation project(':library'). Because on :library, I have fixed the problem.
Please apply this change and re-try.
As mentioned previously, you have to uncomment original library
implementation 'androidx.biometric:biometric:1.0.0-alpha03'
and comment out following line as:
// implementation project(':library'). Because on :library, I have fixed the problem.
Please apply this change and re-try.
ma...@justpinch.com <ma...@justpinch.com> #6
Thank you for the details. Please provide the following additional information:
Screen record of the issue, for clarity
Please capture screen record or video of the issue using following steps:
adb shell screenrecord /sdcard/video.mp4
Subsequently use following command to pull the recorded file:
adb pull /sdcard/video.mp4
Attach the file to this issue.
Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.
Screen record of the issue, for clarity
Please capture screen record or video of the issue using following steps:
adb shell screenrecord /sdcard/video.mp4
Subsequently use following command to pull the recorded file:
adb pull /sdcard/video.mp4
Attach the file to this issue.
Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.
Description
Component used:androidx.room:room-*
Version used: 2.3.0, 2.4.0-alpha02
Devices/Android versions reproduced on: N/A -> code-gen error (kapt)
The documentation on states:
@Transaction
But unless I'm misunderstanding what this is trying to communicate, reality seems to be different.
Given the following dao:
Although implementations are generated, errors are thrown for the
@Transaction
annotated functions returningLiveData
andFlowable
:This seems to contradict the earlier statement from the documentation on
@Transaction
? Is there another way to use@Transaction
with a deferred/async return type?What's also interesting is that the
@Transaction
annotated function returning aFlow
does not yield any errors. Isn'tFlow
also a deferred/async return type? Does this mean that Room can in fact guarantee that all queries in the method are performed on the same thread? If so, how?The generated code looks like this:
This function is no longer deferred, because the transactional operations involve blocking I/O, and there are assertions in place that will fail if this is called from the main thread. And even if we were to make this function suspendable (we would then have a suspendable function returning a Flow?🤨), it would still not be main-safe.
In conclusion, I suspect:
@Transaction
is no longer accurate?@Transaction
annotation returning aFlow
should also yield a code-gen error?